From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f68.google.com (mail-ua1-f68.google.com [209.85.222.68]) by dpdk.org (Postfix) with ESMTP id 0E7261B614 for ; Mon, 17 Dec 2018 11:15:57 +0100 (CET) Received: by mail-ua1-f68.google.com with SMTP id t8so4231796uap.0 for ; Mon, 17 Dec 2018 02:15:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0g/y+3fa7zHFwnEQLT+lg5NT2BoG9vbljDD/IXhoHFc=; b=qBrRzsc+k1xD+cAPiv+9jxtD8nFo3+j6zY7Ey0uq2dVLRfYEm6B9gIPex2dF1G6Pnv cbVcjTjBnNSQSTnqvHNbtPAQwG6Q+r4DvcvRDgRj8mlKGBvAuo2kCBYodovtndtY7S4X QYFYft0EQALsyF3d6MMF3O2CSzQhNITWW4A3rASyXIvJwu0Z/gnJqjQvj5a1NtjWTHWh yIsPYZPxtJQgrl5ffxp3Tb+beBGBQa/dM8RM0OCFPhoBuBhH45/WDPZa7qOMkkR+Zsrq rDnOkI7NVgPErbF+eMs8jRZLwdEGn8faSlgsnnMqLGZK6qkn/XdimfloKIFdptaU+Hp+ 1PSA== X-Gm-Message-State: AA+aEWbrjCQh1J/NPXEjFmCjTzPrdg1BLY+PaVAmd41VGSDh0s+QNg9f aK0VGyrAzKW70ksA/b/NbvRWY8hirpazB9Pr+hd16A== X-Google-Smtp-Source: AFSGD/XW9vfvbn61xWZ+lDrWCzQMvenjCszv+/0eaE2KUWkxF3RGsxmcx55v/9UaQi8Dbu1Hrnlttlrv3PLu1cDwo/w= X-Received: by 2002:ab0:2508:: with SMTP id j8mr5769036uan.130.1545041756388; Mon, 17 Dec 2018 02:15:56 -0800 (PST) MIME-Version: 1.0 References: <1544773540-89825-1-git-send-email-jia.guo@intel.com> <1544773540-89825-2-git-send-email-jia.guo@intel.com> In-Reply-To: <1544773540-89825-2-git-send-email-jia.guo@intel.com> From: David Marchand Date: Mon, 17 Dec 2018 11:15:45 +0100 Message-ID: To: jia.guo@intel.com Cc: bernard.iremonger@intel.com, Wenzhuo Lu , shahafs@mellanox.com, thomas@monjalon.net, matan@mellanox.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, dev@dpdk.org, stephen@networkplumber.org, gaetan.rivet@6wind.com, qi.z.zhang@intel.com, arybchenko@solarflare.com, bruce.richardson@intel.com, shaopeng.he@intel.com, anatoly.burakov@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 10:15:57 -0000 On Fri, Dec 14, 2018 at 8:41 AM Jeff Guo wrote: > This command-line option will enable hotplug event detecting and enable > hotplug handling for device hotplug. > > Signed-off-by: Jeff Guo > Is there a reason why we would want this disabled by default and enabled via option ? diff --git a/lib/librte_eal/common/eal_options.h > b/lib/librte_eal/common/eal_options.h > index 5271f94..4d8a12e 100644 > --- a/lib/librte_eal/common/eal_options.h > +++ b/lib/librte_eal/common/eal_options.h > @@ -65,7 +65,9 @@ enum { > OPT_SINGLE_FILE_SEGMENTS_NUM, > #define OPT_IOVA_MODE "iova-mode" > OPT_IOVA_MODE_NUM, > - OPT_LONG_MAX_NUM > + OPT_LONG_MAX_NUM, > +#define OPT_DEV_HOTPLUG "dev-hotplug" > + OPT_DEV_HOTPLUG_NUM, > }; > > extern const char eal_short_options[]; > OPT_LONG_MAX_NUM is supposed to be the last enum. -- David Marchand