From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35EA4A054F; Tue, 18 Feb 2020 17:39:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6254E1BFD3; Tue, 18 Feb 2020 17:39:17 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 7FB811BFD2 for ; Tue, 18 Feb 2020 17:39:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582043955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lf+P7Z+aeZha8TZ+W8V7tA/r1Ee44rRhCKkiPJVlITc=; b=NnojaQ3PLLneAU547hnASqR4qc65YSLV6emok++FaLCmcHUR9YA2yr5UkZcpwo17weVmPv qrBCxWUTKPc7eDtiR6lM30kv+mnhk5dt6r33LXTC8CbguCIlP8MFkccOUOjH7PLfluz5GZ 11RbMiKax80o3l/PlMpE798SxU05di4= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-8kBrLAvcMgGgO86jNrw-_Q-1; Tue, 18 Feb 2020 11:38:59 -0500 Received: by mail-vk1-f199.google.com with SMTP id e13so8409930vkd.13 for ; Tue, 18 Feb 2020 08:38:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ioBNPhom+XaB6Q3KIyGtLVCDuSl032mYEZBuWR+EPIg=; b=joTidcL+W25qec1uFOM12oPU/arpNdAFtBavzb4GzD+hQqVI6jagiFcoON2GnuN/1f meu87l7b8zO1y20fnz21WkElAMNWFwtKZVQhzixU+eT4NGxpCWrswg4mOfjigY+gBBFt qYI8kzjTUNPaJLXeLwC1mpuoe0ijOLrlenCRuw00JhaEI0tJRVTszy4FpArC6y+VcWSZ L48Y36I73o7bqlwSn2qYoy+O+n8bLdVAUl7AylDb/QcjqNx9qHbTIcR53XfHbNrvMYeO nha0LOKBv4rNpMIgMrTSrWExYpqZx5QfbseXzvTHMGL+XEQD2Wn6KmXVA1Klg1diK99f 7nxA== X-Gm-Message-State: APjAAAUrLYYI/hn0qFzI/J47+CT8e1L5wy0nfT28KsTwpeJUQ+byrjUG rx2Rl0z8i5bSiJ2NmYZ0NPByjGhDTYRvkXuk9QHqRgUMAEi6V4CbD88lugFS66SLakwOuu3mSQ1 9WZcU3eGCJABqPRpwDcc= X-Received: by 2002:a67:905:: with SMTP id 5mr11755318vsj.105.1582043938592; Tue, 18 Feb 2020 08:38:58 -0800 (PST) X-Google-Smtp-Source: APXvYqxklLJt8yzIjOSX6P4kp2P8pdwTZL1bT4Qr3OLyzhIdTFyIO+hyrnbePVyiJL6VMowXmgW6Es+DeEtT/9VAJNI= X-Received: by 2002:a67:905:: with SMTP id 5mr11755306vsj.105.1582043938342; Tue, 18 Feb 2020 08:38:58 -0800 (PST) MIME-Version: 1.0 References: <20200217135929.30987-1-david.marchand@redhat.com> <20200218142916.657-1-david.marchand@redhat.com> <4348229.k3LOHGUjKi@xps> In-Reply-To: <4348229.k3LOHGUjKi@xps> From: David Marchand Date: Tue, 18 Feb 2020 17:38:47 +0100 Message-ID: To: Thomas Monjalon Cc: dev , Aaron Conole , Christian Ehrhardt , Dodji Seketeli , Kevin Laatz , Michael Santana X-MC-Unique: 8kBrLAvcMgGgO86jNrw-_Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] ci: build and use libabigail 1.6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 18, 2020 at 4:46 PM Thomas Monjalon wrote= : > > 18/02/2020 15:29, David Marchand: > > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > > breakage [1]. > > This was fixed upstream in libabigail 1.4 [2], and a bug has been opene= d > > in launchpad [3]. > > > > But for now, build and use the last version 1.6 so that the ABI checks > > can be kept. > > > > 1: https://travis-ci.com/DPDK/dpdk/jobs/287872118#L2242 > > 2: https://sourceware.org/git/gitweb.cgi?p=3Dlibabigail.git;a=3Dcommitd= iff;h=3D215b7eb4fe8b > > 3: https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607 > > > > Signed-off-by: David Marchand > > Acked-by: Thomas Monjalon > > I suggest few improvements below: > > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > if [ "$ABI_CHECKS" =3D "1" ]; then > > What do you think about moving the libabigail install in a function? No strong opinion, we had everything inline so far. > > We could justify this with a comment about installing the latest version. > > > + LIBABIGAIL_REPO=3D${LIBABIGAIL_REPO:-https://sourceware.org/git/li= babigail.git} > > + LIBABIGAIL_VERSION=3D${LIBABIGAIL_VERSION:-libabigail-1.6} > > + > > + if [ "$(cat libabigail/VERSION 2>/dev/null)" !=3D "$LIBABIGAIL_VER= SION" ]; then > > + rm -rf libabigail > > + # if we change libabigail, invalidate existing abi cache > > + rm -rf reference > > + fi > > + > > + if [ ! -d libabigail ]; then > > + git clone --single-branch -b $LIBABIGAIL_VERSION $LIBABIGAIL_R= EPO libabigail/src > > Why not using the tarball? > http://mirrors.kernel.org/sourceware/libabigail/libabigail-1.6.tar.gz No good reason "now". I was first bitten by a reference to redhat-hardened-ld in some libtool script in the tarball (/me looks in Dodji direction). I then considered switching to different versions of libabigail by just setting the LIBABIGAIL_VERSION env variable from .travis.yml. I ended up with the current latest version which is also what is in Ubuntu latest releases. The tarball is smaller than a git clone, so best to use it. v3 incoming. --=20 David Marchand