From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59CCE44028; Tue, 14 May 2024 09:31:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9A3D402D1; Tue, 14 May 2024 09:31:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A4D49402AE for ; Tue, 14 May 2024 09:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715671894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6H9I9foF6PGVI0NHCE3gfOsQREeqUnVG5mYQYG0ZcGM=; b=hPXxsYILNJ/4Gs8bKt5cXDF77lwFNJqWDTO5r5Oqd1jNaGEwN13ZCVT1aotYQBg5M4cYpx qs55i4V+SMHATnFWXcupnF8KpFtBsseYpgYEMhObJNw8+l0XLwUw6bAei5oOT52aswthCH 9INrJT/dnO2IKvnfmwvTSNwL2YQrvaA= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-131-_WHw98_2MmO4G7Npe9JL4g-1; Tue, 14 May 2024 03:31:32 -0400 X-MC-Unique: _WHw98_2MmO4G7Npe9JL4g-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2e22623b573so47861391fa.3 for ; Tue, 14 May 2024 00:31:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715671891; x=1716276691; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6H9I9foF6PGVI0NHCE3gfOsQREeqUnVG5mYQYG0ZcGM=; b=VxoG7Z8NsZp0zsR7XjjDElBeypA2jHb5/Zdt8XKGYHoq7l/f8Yd9XKDAdUPNXqvs7e wYhxRuL0gHIymZ7qBqanjWUcat6OaHDWcTBtDOPMJfRy02gYZZLUszNUC5496C9t+vCh /aTHE0yAciCzCLjiQQ3eQ8xkL2Z/lQGM/+zM2QR7kLXYMFAjT37lUAvHhItbsLN66DAA o44Bp6mggbkvCizrSCk9zK+kRGyu480KMlrXdj6M48IoXQl67MUSIPizp+fpbJaP+wnK 2BqH48ejbNu9LH4xE6jVr0KynG/aEnGUBzyVwHJo/PFOacyIgcQQZISUbzBtXwksHKX9 TFTQ== X-Forwarded-Encrypted: i=1; AJvYcCUEcWmE+vkw64xkMFb+QDfIenkI2NLla6PeZcp5gMgiK+bDFYhQ0rgQIs/jV0f0xwKShJEyV725ux2O4ak= X-Gm-Message-State: AOJu0YxhDoMwQDj+1KHqFTIG/SEVZrIFYlDgQOkT8bQ1WyxyAnafYrbO E2QexX9/y6rnGWuTnopUSJDL/NjzGl/ldyEGYoSDXNR8TgUyDz35UIqQH+o1HmZBrxJ3Z1+Wxrw WDWf3rPmHXeNOASTpM7vEVga5veKBsR88Vyu8+9GGkpsBAqsl7+kpo5TTlwVj9MJLwJ7Bsz+vYZ ux33Ppr5qq9EnbBaQ= X-Received: by 2002:a2e:9ed9:0:b0:2e5:2eaf:b0a4 with SMTP id 38308e7fff4ca-2e52eafb1e4mr68556341fa.41.1715671891307; Tue, 14 May 2024 00:31:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdKgkPVdcVBGdy3AJiMBd/7G2sFeG/JpZuzk9VvZs+hpWC3Et23vuHk17W4CjotRp2PkXk/IzonBzO9Ks8OKw= X-Received: by 2002:a2e:9ed9:0:b0:2e5:2eaf:b0a4 with SMTP id 38308e7fff4ca-2e52eafb1e4mr68555671fa.41.1715671890844; Tue, 14 May 2024 00:31:30 -0700 (PDT) MIME-Version: 1.0 References: <1710967892-7046-1-git-send-email-roretzla@linux.microsoft.com> <1715018306-13741-1-git-send-email-roretzla@linux.microsoft.com> <1715018306-13741-32-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35E9F448@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F448@smartserver.smartshare.dk> From: David Marchand Date: Tue, 14 May 2024 09:31:18 +0200 Message-ID: Subject: Re: [PATCH v5 31/45] baseband/acc: use rte stdatomic API To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , Tyler Retzlaff Cc: "Chautru, Nicolas" , dev@dpdk.org, =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , "Sevincer, Abdullah" , Ajit Khaparde , Alok Prasad , "Burakov, Anatoly" , Andrew Rybchenko , Anoob Joseph , "Richardson, Bruce" , "Marohn, Byron" , Chenbo Xia , Chengwen Feng , "Loftus, Ciara" , "Power, Ciara" , Dariusz Sosnowski , "Hunt, David" , Devendra Singh Rawat , "Carrillo, Erik G" , Guoyang Zhou , Harman Kalra , "Van Haaren, Harry" , "Nagarahalli, Honnappa" , Jakub Grajciar , Jerin Jacob , Jeroen de Borst , Jian Wang , Jiawen Wu , Jie Hai , "Wu, Jingjing" , Joshua Washington , Joyce Kong , "Guo, Junfeng" , "Laatz, Kevin" , Konstantin Ananyev , Liang Ma , Long Li , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Ori Kam , Pavan Nikhilesh , "Mccarthy, Peter" , Rahul Lakkireddy , "Pattan, Reshma" , "Xu, Rosen" , Ruifeng Wang , Rushil Gupta , "Gobriel, Sameh" , Sivaprasad Tummala , Somnath Kotur , Stephen Hemminger , Suanming Mou , Sunil Kumar Kori , Sunil Uttarwar , Tetsuya Mukawa , Vamsi Attunuru , Viacheslav Ovsiienko , "Medvedkin, Vladimir" , Xiaoyun Wang , "Wang, Yipeng1" , Yisen Zhuang , Ziyang Xuan X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 13, 2024 at 9:05=E2=80=AFPM Morten Br=C3=B8rup wrote: > > Tyler, it looks like the line continuations in /drivers/baseband/acc/rte_= vrb_pmd.c are indented with four spaces instead of double . For Tyler defence, indentation is a nice mess in a lot of DPDK code (for legacy, superficial reviews, not enough coffee etc... reasons). mlx5 code is also a big pain as it seems to have its own coding style. I was in the progress of taking this series yesterday and I was looking at those indents before getting EINTR. Tyler, can you please fix those? This will save me some time and I can get this merged soon. Thanks. --=20 David Marchand