From: David Marchand <david.marchand@redhat.com>
To: Dengdui Huang <huangdengdui@huawei.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
fengchengwen@huawei.com, haijie1@huawei.com,
lihuisong@huawei.com, liuyonglong@huawei.com
Subject: Re: [PATCH] devtools: fix version variable not initialized
Date: Thu, 27 Jun 2024 16:28:40 +0200 [thread overview]
Message-ID: <CAJFAV8wd4+0AqcmssAF7WzSTmQh1VpLQpf5uU+SrnFDbxSvVCg@mail.gmail.com> (raw)
In-Reply-To: <20240417093236.3786106-1-huangdengdui@huawei.com>
On Wed, Apr 17, 2024 at 11:32 AM Dengdui Huang <huangdengdui@huawei.com> wrote:
>
> The version variable is not initialized. Therefore, if the -V option
> is not specified, the value of $version is obtained from the context,
> which may cause the version map parsing failure.
>
> Fixes: 6edec7f202ac ("devtools: list symbols by version")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
This is an internal script and I wonder how the mentionned issue is hit.
In any case this fix is correct.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2024-06-27 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 9:32 Dengdui Huang
2024-06-27 14:28 ` David Marchand [this message]
2024-06-28 6:55 ` huangdengdui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wd4+0AqcmssAF7WzSTmQh1VpLQpf5uU+SrnFDbxSvVCg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=haijie1@huawei.com \
--cc=huangdengdui@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).