From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F7754550C; Thu, 27 Jun 2024 16:28:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B67E40E09; Thu, 27 Jun 2024 16:28:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AB98F40BA3 for ; Thu, 27 Jun 2024 16:28:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719498535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=joFOGf61xDx4Bgo8olYG72k8l0MqHJ7aySsU8OTtCxs=; b=C3d49UKGgUFcatSalKq48EKHHRiYOh5iJr5e6aZqGGf61qJsJ5Ztv44/seVM/dSfnB4a5X ehHF9cn4sFjirN3zuJ6M5rugOO9L15UCT2i0o4aD6drYfCI3IgUJ0jiWzPo1Av7v2m98ie Tfywxt8cT4jcnluOrkhk9qcT9/LR6NI= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-mN9SmJUzP8eNvpd9WIACpQ-1; Thu, 27 Jun 2024 10:28:54 -0400 X-MC-Unique: mN9SmJUzP8eNvpd9WIACpQ-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ee4eb9ab1fso1437041fa.1 for ; Thu, 27 Jun 2024 07:28:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719498532; x=1720103332; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=joFOGf61xDx4Bgo8olYG72k8l0MqHJ7aySsU8OTtCxs=; b=qGJu3L5+lHUmL4uZEcFIFtlgeUxwEasRMaHI3OPjWgb8polAKXuhJi77+nTNRcbzei uZN5uRGo5kb+dycv/C/R7CPN3v0FUEg/lnifH2n7u87dReMXgShfN5JikagbG5Y4aTZS pOj8C1j4CxTYEK46q0SGSYPRvqgFE5vVz3jlFe98KVyy6ZafFpP5SEAes4PrqZft8Zo6 B+tEQ2PrI9NuM4h+vgYeDc280U8ft3qSIT28ic402p8sT9y4W718PAnFLZpycjXIXnD/ JerjHTibynJUmlu0Fb1KmOy2UoYZqrU1QJ4WOixy3/qs1BXQX97hZVydYs7fuqzMsAtm /rIw== X-Gm-Message-State: AOJu0YzrRZVMivRpzA8nPajtYLmXgxq7TCizF9raDR8Hbk3/hDf0VZc1 wdlk7Ak6/7jACDGZIrjx7IhbSTIIgyiNHpi0MrVw5JPISrxt6n76SAT/KRpe9uPEN+CMMYg+OR9 3Wlyy8Bktq25vLMto2J2DiLab/Kg/yxz/gx6kqWDkvl7KWZJw4JrM25DYa6iKLG+Z6jf0fx60jd cDfNk1KlElD0eJ5tA= X-Received: by 2002:a05:651c:1581:b0:2ee:493f:d5be with SMTP id 38308e7fff4ca-2ee493fd616mr19533591fa.3.1719498532684; Thu, 27 Jun 2024 07:28:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFy3JmSYH47DmwB08wzfsMhu/SPVzmpzwo7P4zG+l542v+Ge6QF7RqRcKSj1g6yNyemZWLNhiS3QMSzxuH5lGU= X-Received: by 2002:a05:651c:1581:b0:2ee:493f:d5be with SMTP id 38308e7fff4ca-2ee493fd616mr19533491fa.3.1719498532362; Thu, 27 Jun 2024 07:28:52 -0700 (PDT) MIME-Version: 1.0 References: <20240417093236.3786106-1-huangdengdui@huawei.com> In-Reply-To: <20240417093236.3786106-1-huangdengdui@huawei.com> From: David Marchand Date: Thu, 27 Jun 2024 16:28:40 +0200 Message-ID: Subject: Re: [PATCH] devtools: fix version variable not initialized To: Dengdui Huang Cc: dev@dpdk.org, bruce.richardson@intel.com, fengchengwen@huawei.com, haijie1@huawei.com, lihuisong@huawei.com, liuyonglong@huawei.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 17, 2024 at 11:32=E2=80=AFAM Dengdui Huang wrote: > > The version variable is not initialized. Therefore, if the -V option > is not specified, the value of $version is obtained from the context, > which may cause the version map parsing failure. > > Fixes: 6edec7f202ac ("devtools: list symbols by version") > Cc: stable@dpdk.org > > Signed-off-by: Dengdui Huang This is an internal script and I wonder how the mentionned issue is hit. In any case this fix is correct. Reviewed-by: David Marchand --=20 David Marchand