From: David Marchand <david.marchand@redhat.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Li Han <han.li1@zte.com.cn>,
Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue
Date: Thu, 24 Oct 2019 09:37:43 +0200 [thread overview]
Message-ID: <CAJFAV8we-SEE=Zew+Du41Y0Vr9y4QqSqqRtkJHETzii-Zc=ydQ@mail.gmail.com> (raw)
In-Reply-To: <cd3129c8-7d08-a8b0-35f0-c028e99c8361@intel.com>
On Wed, Oct 23, 2019 at 7:47 PM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
>
> On 23-Oct-19 11:42 AM, Li Han wrote:
> > In rte_eal_config_reattach(),the secondary mmap may fail
> > due to the rte_mem_cfg_addr already be used by others.do
> > the change just as the rte_fbarray_init() do.if no
> > base_virtaddr,use the default 0x100000000.
> >
> > v2/v3:
> > -fix code style issues
> >
> > Signed-off-by: Li Han <han.li1@zte.com.cn>
> > ---
>
> Nack. There's a reason why we map it at the same address, and it's to
> have all pointers working across processes. Remapping it at a different
> address has potential to break things.
Marked as rejected.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2019-10-24 7:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 10:42 Li Han
2019-10-23 17:46 ` Burakov, Anatoly
2019-10-24 7:37 ` David Marchand [this message]
2019-10-24 8:30 ` [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime configmmap issue han.li1
2019-10-24 11:13 ` [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue Burakov, Anatoly
2019-10-24 11:23 ` David Marchand
2019-10-24 12:22 ` Burakov, Anatoly
2019-10-24 12:39 ` Burakov, Anatoly
2019-10-25 11:37 ` [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime configmmap issue han.li1
2019-10-25 12:20 ` Burakov, Anatoly
2019-10-26 16:07 ` David Marchand
2019-11-05 14:14 ` David Marchand
2019-11-13 7:38 ` David Marchand
2019-10-24 11:13 ` [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue Burakov, Anatoly
2019-10-24 12:38 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8we-SEE=Zew+Du41Y0Vr9y4QqSqqRtkJHETzii-Zc=ydQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=han.li1@zte.com.cn \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).