From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9612A32A1 for ; Thu, 24 Oct 2019 09:38:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0FEE1D127; Thu, 24 Oct 2019 09:38:01 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 8B5261C135 for ; Thu, 24 Oct 2019 09:38:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571902679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TvkZUY0J79zqmgBkTM5C1M5dquLee3u+PHZI2XkO6Tc=; b=NWeXOE/rjGVK1Qug5wUqQ4TstsoQj1nJ81PMG3+xfrMxyhla2GhuFFlP+xPDrJaODt1ITR tDVJkF2oCATeAytder3iGVP6eIbbQNL27smr7AtqgcG++shIBHwbP1342MTLmAXbgYomgI DZ58wI0un/9y8+xcr5GeYD/E4cEDjO4= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-p7YCwhjOPb-5c7Ai9r-VhQ-1; Thu, 24 Oct 2019 03:37:55 -0400 Received: by mail-vk1-f200.google.com with SMTP id g144so4397277vkf.8 for ; Thu, 24 Oct 2019 00:37:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5aIJnkUOHvoaAV3iUhe2Zzhcqn+Xo4TVKhSxS8yU3/8=; b=Dv+bfy8NBwj+pX0DQjZLR5755d43d5VW5IlDQRU347vEGYsjvMbeQqQXI1CpWI+X5X P6f6rXtEh9G8TQLjnZu6scsBuGNWi/d4O6g++tuy+v1Z2Z4n7XRjze99j/ugLUb4n+5f ak/cBUD28+j+JeXhTg5rljWoa/SJ23bXYgGT3ReV8NtVIGbxvy2h/wJhAtxkUnYl+i2v wZ4FKSQa5B4lGqbV8OvV6f9ebCbeYOFtPhuK/DC2xAAOMxzB8RBox2AU7fN1yYy1DSzg G81C+5pw26CLvk6NoV2NhXAtfcbBptYbsvcDC7EXJ/+TRY9SgalhNNbxJ7cjCZrlQf/k kkVQ== X-Gm-Message-State: APjAAAVnLc0fv+uto6HwlUH/5iI19UroH1tJYdvsvkBGjcVzyF45LsHw lxyE4hgYTbRCk6e7XA3oGzsQ89h35xjHjfFIvYiaJMg8nOxmdGAlmXxX0jCjfJjXTS7POc+rLed 4TSWVRKN5x3Mr62fQZ5k= X-Received: by 2002:ab0:5968:: with SMTP id o37mr8092557uad.53.1571902674766; Thu, 24 Oct 2019 00:37:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqygJoglYSg8sRHp9gey6g+4cnh22MF0dBtvMCc3gHPo5B67ohEbvcEFrIN0YG6wrnt9SEHwqyhwn/e0Vin8ytM= X-Received: by 2002:ab0:5968:: with SMTP id o37mr8092541uad.53.1571902674464; Thu, 24 Oct 2019 00:37:54 -0700 (PDT) MIME-Version: 1.0 References: <1571827361-30578-1-git-send-email-han.li1@zte.com.cn> In-Reply-To: From: David Marchand Date: Thu, 24 Oct 2019 09:37:43 +0200 Message-ID: To: "Burakov, Anatoly" Cc: Li Han , Thomas Monjalon , dev X-MC-Unique: p7YCwhjOPb-5c7Ai9r-VhQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 23, 2019 at 7:47 PM Burakov, Anatoly wrote: > > On 23-Oct-19 11:42 AM, Li Han wrote: > > In rte_eal_config_reattach(),the secondary mmap may fail > > due to the rte_mem_cfg_addr already be used by others.do > > the change just as the rte_fbarray_init() do.if no > > base_virtaddr,use the default 0x100000000. > > > > v2/v3: > > -fix code style issues > > > > Signed-off-by: Li Han > > --- > > Nack. There's a reason why we map it at the same address, and it's to > have all pointers working across processes. Remapping it at a different > address has potential to break things. Marked as rejected. Thanks. --=20 David Marchand