From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1498942547; Fri, 8 Sep 2023 13:50:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E18EF402AF; Fri, 8 Sep 2023 13:50:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 94ABE40042 for ; Fri, 8 Sep 2023 13:50:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694173819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RKPKAAKBPcag0Rnnm3Q6P4pon0QOIeFT3IKbo4ru+j8=; b=NZ5BEjR3PD4IuhZenb0y9MPNd+FCzGJlZkNHUxj1zyPxJuz2+0H2TiBa3mI/U3k7YYnaaV 5qfqUmcntZ61feosiC3p2DRw3iPj7zLDwW7HEGQZqFT0OdwRe1H5VnRA68IiIIZcv5ltk8 y9L0rlCkl7XS2Yad8a1MtXfq89lrsBQ= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-SZes5MFnOi-hkmCBJbk-7Q-1; Fri, 08 Sep 2023 07:50:18 -0400 X-MC-Unique: SZes5MFnOi-hkmCBJbk-7Q-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-502974f6bafso1478317e87.1 for ; Fri, 08 Sep 2023 04:50:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694173816; x=1694778616; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RKPKAAKBPcag0Rnnm3Q6P4pon0QOIeFT3IKbo4ru+j8=; b=MKZEs/X9YZunS815XR/2WzXiaZscBgJ6HgBq/XqZwqbXiPKKRPJch+Yru/SGOVVih9 cypwDm06bz02cASQoDGDoIzM8TQesMzrbO+sfyY1t1yTfbJme6rZuMoT6MOJqVe1dVYC LWfRjKlnkNjKHqYel1DGF1ulD2JhamWdtSJXSDcbG/i/3KpGmoFsQOJWnJlXoOYuof4w LGwUvNaU6dtzU3tnyr26Aio3lq9lEEyaarw4YdERg6jftjbd3t5YCv3YRo9upsfLsfYO K894rm0oSdW5sKQcxPTNrAtbEGa1J3A10PaFOmPzIiwfe6Uw4C+XVs9W3wQ2UWg/32I3 JV5g== X-Gm-Message-State: AOJu0Yw0TFeXUq8pVJKhcxf8EATS62K94AivI2W+AkNL+SXSmLC+XbB/ xgdmlhfrZIp2MkclV1KJEsS1BchSxfsJ0VpesCggUidECabUoFieprlqL/qjmZ2Gcj98v4J24sd dVFKWY0m/UoLx3+GBtTA= X-Received: by 2002:a05:6512:ad3:b0:4fb:745e:dd01 with SMTP id n19-20020a0565120ad300b004fb745edd01mr1749126lfu.45.1694173816656; Fri, 08 Sep 2023 04:50:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHe6lRqeKREJ0D2CLAdDQYckiUx99nRKPnkRM9yfbsfbPgwwA9KYl9Uuv7HOO0Kkt1TYzV2JDPb0MWwrte1bYU= X-Received: by 2002:a05:6512:ad3:b0:4fb:745e:dd01 with SMTP id n19-20020a0565120ad300b004fb745edd01mr1749111lfu.45.1694173816341; Fri, 08 Sep 2023 04:50:16 -0700 (PDT) MIME-Version: 1.0 References: <20230908112901.1169869-1-haijie1@huawei.com> In-Reply-To: <20230908112901.1169869-1-haijie1@huawei.com> From: David Marchand Date: Fri, 8 Sep 2023 13:50:05 +0200 Message-ID: Subject: Re: [PATCH 00/36] fix Rx and Tx queue state To: Jie Hai Cc: dev@dpdk.org, lihuisong@huawei.com, Ferruh Yigit , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 8, 2023 at 1:32=E2=80=AFPM Jie Hai wrote: > > The DPDK framework reports the queue state, which is stored in > dev->data->tx_queue_state and dev->data->rx_queue_state. The > state is maintained by the driver. Users may determine whether > a queue participates in packet forwarding based on the state, > for example, The driver is maintaining this state in dev_start / dev_stop and per queue start/stop handlers. > > [1] 5028f207a4fa ("app/testpmd: fix secondary process packet forwarding" > [2] 141a520b35f7 ("app/testpmd: fix primary process not polling all queue= s") > > Therefore, the drivers need to modify the queue state in time > according to the actual situation, especially when dev_start > and dev_stop are called. see [3] for more information. > > [3] https://inbox.dpdk.org/dev/20230721160422.3848154-1-ferruh.yigit@amd.= com/ > > This patchset also resubmit the patch [2] and makes some fixes on the pat= ch. I just had a quick look at some patches and I wonder if a better fix would be at the ethdev level, rather than fixing all drivers. --=20 David Marchand