From: David Marchand <david.marchand@redhat.com>
To: Huichao Cai <chcchc88@163.com>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit
Date: Tue, 9 Nov 2021 10:16:24 +0100 [thread overview]
Message-ID: <CAJFAV8wePVCMqW4cwEx1rmz5xihB_sA8b=cUU9U6a2BC99QSAQ@mail.gmail.com> (raw)
In-Reply-To: <30a079c3.399a.17d03efe9e8.Coremail.chcchc88@163.com>
On Tue, Nov 9, 2021 at 10:03 AM Huichao Cai <chcchc88@163.com> wrote:
> >It could (should?) have been a single patch.
> --Yes, it can.I think the test unit is missing the offsets test content, so add this patch, and can also test the previous patch.
Too late, Thomas merged the fix in the library already.
Please consider this for future contributions.
> >A link to patchwork would avoid me wasting time looking for it.
>
> >I guess this is the patch Thomas merged last night.
> --I can see a link in my sent message，As in the screenshot below：
> --But I'm not sure why you didn't get the link when you got the email, I'm sorry.
I filter html.
I just saw your other reply: yes prefer plain text.
>
> >On the patch itself, the title is vague.
> >It should summarize what the change adds to the unit tests.
>
> >test/ipfrag: check fragment offsets
> --Thank you for reminding me, do I need to send another patch to modify the title?
You seem ok with this title, I'll go with it.
--
David Marchand
next prev parent reply other threads:[~2021-11-09 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 7:58 huichao cai
2021-10-28 12:24 ` Ananyev, Konstantin
2021-11-10 10:46 ` David Marchand
2021-11-08 20:28 ` David Marchand
2021-11-09 2:21 ` Huichao Cai
2021-11-09 8:14 ` David Marchand
2021-11-09 9:03 ` Huichao Cai
2021-11-09 9:16 ` David Marchand [this message]
2021-11-09 9:29 ` Huichao Cai
2021-11-09 9:14 ` Huichao Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wePVCMqW4cwEx1rmz5xihB_sA8b=cUU9U6a2BC99QSAQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chcchc88@163.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).