From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F669A0C4B; Tue, 9 Nov 2021 10:16:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E642F40E03; Tue, 9 Nov 2021 10:16:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8C6524068B for ; Tue, 9 Nov 2021 10:16:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636449398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6XOyW/Lg5yI4LqJTHYWQGD8ymV3WGtRUVXioSF0hdPs=; b=dW1ZEQsGvq/ysn/q2sedS+Ch+afVhxt/hrSDHh1Gzc3e1aiEYIeGUnpY/RWhNepT4ovKKs QOpuvcrG5uHW4Pee+UwiTWaMBIVcD5ZSDmbd1LlKZWjbeAVvSuO9ZhS/Kzrjlxt1icyQNB hukyAH6KsoyAO8mg30nxhvKNvGe55iw= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-598-mQqYK_bkPzGvZfC2SGQgNA-1; Tue, 09 Nov 2021 04:16:36 -0500 X-MC-Unique: mQqYK_bkPzGvZfC2SGQgNA-1 Received: by mail-lf1-f70.google.com with SMTP id bp10-20020a056512158a00b0040376f60e35so2276993lfb.8 for ; Tue, 09 Nov 2021 01:16:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6XOyW/Lg5yI4LqJTHYWQGD8ymV3WGtRUVXioSF0hdPs=; b=4ePgs7VuhRZnL5QIU517aikAy4N8hB4hLDI0RbcxYmodXxn0TO3boYlAGTp7f6N/qA AycEVMJEUCUdhtP6edPGmpFJFCKqobO2BH60QUq5zk4xJT4hx5/Op1MJRcnJJM/y5sB2 TOelSM5m8yuNiZD6vSSRLrvFvAw7vgRffVQ0iheBOzcbPjHus9yV0oqAXMPJAY1swiu8 1n9KvNhGGQVaHRTkIZTQlN/A/9eyFQ5i0Sa3Zr8x2CZoMJQ5LRqQBi+G+CeiX3cjXYcd GV+fpUlY7CmrXGdMi2W1sRMzCV7e1ikdI0GXlzihdPPS7L3TR6O7bKLPA3mQ/QT/NmZq cBIQ== X-Gm-Message-State: AOAM533av6eW3HCQJ76TEzc5E0HcffmXRdpkYVRgWAUvMAtRKS6VcE2A 7Y3Z1CMCsbyWu/bEuRs3DKQJaIG0LxmE6MO8A9Xl/3jb2+MInLNbsaSMylB2I4WmnmPS3T/sg9U LFdq9ujFCByk3ocG4H3g= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr5332311lfv.560.1636449395396; Tue, 09 Nov 2021 01:16:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJwVMqAhAXmZTP1DAIQOfH7sg8acEPtCy9Ah/wmdTDROoqomGsfIWNdJPMaQutDlLUP3qgXL+0eQuVV5l9hPB48= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr5332291lfv.560.1636449395208; Tue, 09 Nov 2021 01:16:35 -0800 (PST) MIME-Version: 1.0 References: <1635148739-61415-1-git-send-email-chcchc88@163.com> <79a325b9.dfd.17d0280731a.Coremail.chcchc88@163.com> <30a079c3.399a.17d03efe9e8.Coremail.chcchc88@163.com> In-Reply-To: <30a079c3.399a.17d03efe9e8.Coremail.chcchc88@163.com> From: David Marchand Date: Tue, 9 Nov 2021 10:16:24 +0100 Message-ID: To: Huichao Cai Cc: "Ananyev, Konstantin" , dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 9, 2021 at 10:03 AM Huichao Cai wrote: > >It could (should?) have been a single patch. > --Yes, it can.I think the test unit is missing the offsets test content, = so add this patch, and can also test the previous patch. Too late, Thomas merged the fix in the library already. Please consider this for future contributions. > >A link to patchwork would avoid me wasting time looking for it. > > >I guess this is the patch Thomas merged last night. > --I can see a link in my sent message=EF=BC=8CAs in the screenshot below= =EF=BC=9A > --But I'm not sure why you didn't get the link when you got the email, I'= m sorry. I filter html. I just saw your other reply: yes prefer plain text. > > >On the patch itself, the title is vague. > >It should summarize what the change adds to the unit tests. > > >test/ipfrag: check fragment offsets > --Thank you for reminding me, do I need to send another patch to modify t= he title? You seem ok with this title, I'll go with it. --=20 David Marchand