From: David Marchand <david.marchand@redhat.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, rjarry@redhat.com,
Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] ci: configure Coderabbit
Date: Thu, 2 Oct 2025 13:54:21 +0200 [thread overview]
Message-ID: <CAJFAV8wed4TtWKeD5D7dpxZB074NPLfOPhNvK7G8hXPZCeV2iQ@mail.gmail.com> (raw)
In-Reply-To: <99b9882b-d5a0-467a-be09-5bc88af2cba8@intel.com>
On Thu, 2 Oct 2025 at 12:34, Burakov, Anatoly <anatoly.burakov@intel.com> wrote:
>
> On 10/1/2025 4:23 PM, David Marchand wrote:
> > On Wed, 1 Oct 2025 at 16:12, David Marchand <david.marchand@redhat.com> wrote:
> >> On Wed, 1 Oct 2025 at 16:04, Burakov, Anatoly <anatoly.burakov@intel.com> wrote:
> >>> Can you provide a little more details on what exactly you are proposing?
> >>>
> >>> On the back of this patch, I installed CodeRabbit in my IDE (VSCode),
> >>> and did a review of one of my recent patchsets - it's quite interesting,
> >>> actually, and the comments provided were basic but meaningful, alas the
> >>> free version is limited to like 1 review per 30 minutes or something so
> >>> it's a bit limiting. On top of that, I found the tool a lot more usable
> >>> than GitHub Copilot reviews, which are attached to GH pull requests
> >>> rather than Git branches, and they take a lot less time to boot, so I
> >>> feel like this tool has potential.
> >>>
> >>> That said, I'm not sure what this patch is supposed to do - is it to
> >>> have it set up to review patches automatically?
> >>
> >> The ovsrobot creates pull requests in its dpdk github repository, and
> >> Coderabbit and sourcery are invoked on them.
> >> Look for a link in patchwork, under the name "ci/github-robot-post".
> >>
> >> For example, this exact patch got a branch and pr in ovsrobot/dpdk:
> >> https://github.com/ovsrobot/dpdk/tree/series_36267
> >> https://github.com/ovsrobot/dpdk/pull/124
> >
> > Btw, you'll notice a bit of noise, due to how the PR is created
> > against ovsrobot/main, and not the exact DPDK main branch at the
> > moment the patch is submitted on the ml.
> >
> >
>
> Wow, I didn't know this was a thing! Sourcery actually seems like the
> more impressive one in terms of summarizing the changes and aiding in
> review, but those two in tandem look pretty cool indeed. Makes me think
Well, Robin gave better feedback on Coderabbit than on Sourcery so far.
Coderabbit seems less picky on credits when it comes to opensource
projects (I did not check in details, that's *my* feeling when looking
at reviews in DPDK PRs where I see sourcery complaining we consumed
too many credits recently).
One important difference between the two is that it does not seem
possible to tweak sourcery with settings stored in your repo like what
is done in this patch.
This may be a problem for the DPDK github org, where we have DPDK and
grout starting to use AI bot for reviews, and may have different
opinions on how to configure the tools.
> of an alternate reality where we use GitHub (or something else more
> modern) to review code :)
Erm, my personal opinion, the github PR webui is a *mess*.
--
David Marchand
next prev parent reply other threads:[~2025-10-02 11:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 8:18 David Marchand
2025-10-01 14:03 ` Burakov, Anatoly
2025-10-01 14:12 ` David Marchand
2025-10-01 14:23 ` David Marchand
2025-10-02 10:34 ` Burakov, Anatoly
2025-10-02 11:54 ` David Marchand [this message]
2025-10-02 13:02 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wed4TtWKeD5D7dpxZB074NPLfOPhNvK7G8hXPZCeV2iQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=rjarry@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).