From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2BA545C13; Wed, 30 Oct 2024 11:24:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3617433A9; Wed, 30 Oct 2024 11:24:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8FBBD40263 for ; Wed, 30 Oct 2024 11:24:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730283872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g1AI7jJzkDMKmTNF50JTgPLcqnqiF9LJtwTLWfgtRrg=; b=gUURRXbs17MtT99BPQbvkDwOJzV1ohAJFZxSbjP0aI8/DX87hdsbae12FTuU/eJ/trOrQv UPtHVzcCWCulSGLHvg6L/2z/QVw1fLWnObBQFD4y2ZE852I/X1929JItMkEz3hdzdSJ8g0 vnU9IqoAoDzB30Eol7dH1unQnx2mWxw= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-100-aF_QRHRHNHaiW_y7lYU5Tw-1; Wed, 30 Oct 2024 06:24:30 -0400 X-MC-Unique: aF_QRHRHNHaiW_y7lYU5Tw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2fb60277fb2so42870231fa.0 for ; Wed, 30 Oct 2024 03:24:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730283869; x=1730888669; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g1AI7jJzkDMKmTNF50JTgPLcqnqiF9LJtwTLWfgtRrg=; b=MjNUtMj3PWKAonnd1mbjQ3wqWcauRHa9drlFfMDkdMfZLf+rAfDBNL16rzP77zqws5 8/K790TW70Ptpl7XxRBu0kFDI3LeJcBZLfV/IPKFnwFDlx4MOxBH3KUTa68eLhnR0/XV DMfwjt0lgJmacwe/+iKXGUU05ua3lZL7y5j1GJZz9qCxKqWWZ4WWHkMy6QY4Zoq4vBQq rG+HU+aiDhsg662TXO/9Z8mV1INNcRw/VU1W0Z+mZFWUAxeoBQSQp96i2yM1Ab+d+IT5 gEOqUvShUjz5uX9EfdT3lZzf2Ifh4sxllPpITV79SKFcT+NSK86r+AmgBRAKiXwzrJT0 jyuw== X-Gm-Message-State: AOJu0YxN4Iq9+7BNtI+2OtpgixLniVfZjZAXg/fq+4FsfQXt9gQechKH A42Wwb6klDwYQK2nSNKo5MzoRhMQZgwIOEtNHCUe7eVa6kLN+rzvHD/w7YHf/I/QrAAjddgV1bJ d1xWNl5CfaYyUZ3BHlSb38qvSaW7ypwxjlrsrisyVxd2ehVNw0VueIyPPGA+yKSfdPCCXxxIvbG SyffSk5CN/vt+PEmw= X-Received: by 2002:a05:6512:401a:b0:53a:1337:5ff7 with SMTP id 2adb3069b0e04-53b3490effcmr8385264e87.40.1730283869269; Wed, 30 Oct 2024 03:24:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTXOMvw5CzX4Y41wUOzjcxNwgbb0WFCL7N7e65HZzhmBkCrfty/3f8EYpcuO7YVXB8Knp6eq9rLU/t3B1i8g8= X-Received: by 2002:a05:6512:401a:b0:53a:1337:5ff7 with SMTP id 2adb3069b0e04-53b3490effcmr8385246e87.40.1730283868871; Wed, 30 Oct 2024 03:24:28 -0700 (PDT) MIME-Version: 1.0 References: <20241024120535.2722316-1-david.marchand@redhat.com> <20241025070424.3916007-1-david.marchand@redhat.com> In-Reply-To: <20241025070424.3916007-1-david.marchand@redhat.com> From: David Marchand Date: Wed, 30 Oct 2024 11:24:17 +0100 Message-ID: Subject: Re: [PATCH v2 0/6] Clean up many __builtin_* in drivers. To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, stephen@networkplumber.org, mattias.ronnblom@ericsson.com, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Hemant Agrawal X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 9:04=E2=80=AFAM David Marchand wrote: > > Here is a series cleaning up most of uses of __builtin_* helpers in > drivers when they have a direct replacement in EAL. > > checkpatch is extended to forbid new additions. > > -- > David Marchand > > Changes since v1: > - more fixes in crypto/openssl, > > David Marchand (6): > devtools: handle multiple pattern for skipping files > devtools: forbid use of builtin helpers > common/dpaax: use prefetch macros > crypto/openssl: fix 3DES-CTR with big endian CPUs > drivers: use branch prediction macros > drivers: use bitops API instead of compiler builtins > > devtools/check-forbidden-tokens.awk | 21 +++++++++++++----- > devtools/checkpatches.sh | 7 +++--- > drivers/bus/fslmc/qbman/include/compat.h | 6 ++--- > drivers/common/dpaax/compat.h | 6 +++-- > drivers/common/nfp/nfp_platform.h | 4 +++- > drivers/crypto/openssl/rte_openssl_pmd.c | 28 ++++++++---------------- > drivers/dma/hisilicon/hisi_dmadev.h | 3 ++- > drivers/ml/cnxk/cn10k_ml_ocm.c | 7 +++--- > drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 4 ++-- > drivers/net/bnxt/tf_ulp/ulp_flow_db.c | 6 +++-- > drivers/net/bnxt/tf_ulp/ulp_gen_hash.c | 4 +++- > drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- > drivers/net/cpfl/cpfl_flow_engine_fxp.c | 5 ++++- > drivers/net/enetfec/enet_ethdev.c | 5 +++-- > drivers/net/enetfec/enet_ethdev.h | 6 ----- > drivers/net/hns3/hns3_rxtx_vec_neon.h | 4 +++- > drivers/net/i40e/i40e_rxtx_vec_neon.c | 4 +++- > drivers/net/iavf/iavf_rxtx_vec_neon.c | 4 +++- > drivers/net/mlx5/hws/mlx5dr_definer.c | 8 ++++--- > drivers/net/mlx5/mlx5_flow_dv.c | 3 ++- > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 12 +++++----- > drivers/net/mlx5/mlx5_tx.c | 2 +- > drivers/net/qede/base/bcm_osal.h | 4 +++- > drivers/net/vmxnet3/base/vmxnet3_osdep.h | 4 +++- > 24 files changed, 90 insertions(+), 70 deletions(-) Series applied, thanks. --=20 David Marchand