Re: [PATCH v6 1/6] dpdk: do not force C linkage on include file dependencies

[David Marchand <david.marchand@redhat.com>]

Addendum to previous mail.
I missed some issues, but the CI did catch them.

On Tue, Sep 10, 2024 at 10:41 AM Mattias Rönnblom
<mattias.ronnblom@ericsson.com> wrote:
> diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h
> index b774625d9f..06b249dca0 100644
> --- a/lib/eal/include/rte_vfio.h
> +++ b/lib/eal/include/rte_vfio.h
> @@ -10,10 +10,6 @@
>   * RTE VFIO. This library provides various VFIO related utility functions.
>   */
>
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> -
>  #include <stdbool.h>
>  #include <stdint.h>
>
> @@ -36,6 +32,10 @@ extern "C" {
>
>  #include <linux/vfio.h>
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  #define VFIO_DIR "/dev/vfio"
>  #define VFIO_CONTAINER_PATH "/dev/vfio/vfio"
>  #define VFIO_GROUP_FMT "/dev/vfio/%u"

This hunk above should be out of the #idef VFIO_PRESENT.


> diff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h
> index 132f37506d..5234c1697f 100644
> --- a/lib/hash/rte_thash_gfni.h
> +++ b/lib/hash/rte_thash_gfni.h
> @@ -5,10 +5,6 @@
>  #ifndef _RTE_THASH_GFNI_H_
>  #define _RTE_THASH_GFNI_H_
>
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> -
>  #include <rte_compat.h>
>  #include <rte_log.h>
>
> @@ -16,6 +12,10 @@ extern "C" {
>
>  #include <rte_thash_x86_gfni.h>
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  #endif
>
>  /**

This hunk above should be out of the #idef RTE_ARCH_X86.



-- 
David Marchand