From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D7A4459AE; Mon, 16 Sep 2024 14:13:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A54B4025F; Mon, 16 Sep 2024 14:13:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3A6B640150 for ; Mon, 16 Sep 2024 14:13:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726488812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6xs4o1JhEb1orimj7MFc9KVoSwjErPJ0SVp9H6GLZaA=; b=BCnD85bVGzsqqZd0LUxFX2bzva8UWeR6zd/YtiBMEadAO/WXrdXEZAMVOKLUyxEFopkSVB DPeu9Aklh6uH4yV/yttfwK3a0omTJGanHd21jMNOHaQxsgEZD7yD4PD7vbslXQHY9P/G5Y AZK8hmsGw1ZRuath2ntQXjYXGhpUk/g= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-kG3g9zpeOpCffIXb7lgrNQ-1; Mon, 16 Sep 2024 08:13:31 -0400 X-MC-Unique: kG3g9zpeOpCffIXb7lgrNQ-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2f7586de61cso30932021fa.3 for ; Mon, 16 Sep 2024 05:13:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726488810; x=1727093610; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6xs4o1JhEb1orimj7MFc9KVoSwjErPJ0SVp9H6GLZaA=; b=Mepga658gSRFFylJVaOPfF5QpLjb6inzbGO3BRdrFm9EqnunJmZ6gEcfLHxkYepWYh NIbRyKUWGd9VsBFCccuYP+B/WflRrPiHjlEnGN8L30YjTP1Yx2hMzfJorprtQyEGPdot VYmBGq69wf32Z3jkaf/w1f8zD2qeElHAJeN1l0bHZk9zxJmVarsRTWF2Jck+OAdOVWL4 odpBXgjh5SiqWCkNSLUBvN25L0dNCh01taj9aIr8eqAuyz9QKzTtn4VEuNEOPr5dU2KG 9H59kOJPqkprDWqrAmDF16TASmWC8+/k43diDmtJB8eswwHnyedQUIiQEXcHLCVUsK4/ RBTA== X-Gm-Message-State: AOJu0YzpKKOmOiUfnFj6fP4ZTd2hDRAXOzW0Ef/6zEwvuSM97F0gOCT7 73M33k4UBwIZ2z/rLmVCGq0jt7fWDlhJwKiu7phTbqukFUEyQhQ8kjbYskoUC5hNMXZtI8At9U9 iy8aRQ8EXToax70FDZNUIdy+zuGDXQfbA/egph2D/p24KkwC5sbHcfZspvwEZC9y6iE9j/YOOcp yNz3kqxQxhf9LqQI0= X-Received: by 2002:a2e:9003:0:b0:2f5:806:5d00 with SMTP id 38308e7fff4ca-2f787f3b98bmr60932011fa.32.1726488809908; Mon, 16 Sep 2024 05:13:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF52j8prT44Hx/IL+PNRCIJVBUt/vYo6CrpcQa4We2dk2c0WGtHFi4eKcdqAIoymwX1+9SDNJjUJTgDk3Ju5Zg= X-Received: by 2002:a2e:9003:0:b0:2f5:806:5d00 with SMTP id 38308e7fff4ca-2f787f3b98bmr60931761fa.32.1726488809328; Mon, 16 Sep 2024 05:13:29 -0700 (PDT) MIME-Version: 1.0 References: <20240910062051.699096-2-mattias.ronnblom@ericsson.com> <20240910083139.699291-1-mattias.ronnblom@ericsson.com> <20240910083139.699291-2-mattias.ronnblom@ericsson.com> In-Reply-To: <20240910083139.699291-2-mattias.ronnblom@ericsson.com> From: David Marchand Date: Mon, 16 Sep 2024 14:13:16 +0200 Message-ID: Subject: Re: [PATCH v6 1/6] dpdk: do not force C linkage on include file dependencies To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev@dpdk.org, hofors@lysator.liu.se, Heng Wang , Stephen Hemminger , Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Jack Bond-Preston , Chengwen Feng X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Addendum to previous mail. I missed some issues, but the CI did catch them. On Tue, Sep 10, 2024 at 10:41=E2=80=AFAM Mattias R=C3=B6nnblom wrote: > diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h > index b774625d9f..06b249dca0 100644 > --- a/lib/eal/include/rte_vfio.h > +++ b/lib/eal/include/rte_vfio.h > @@ -10,10 +10,6 @@ > * RTE VFIO. This library provides various VFIO related utility function= s. > */ > > -#ifdef __cplusplus > -extern "C" { > -#endif > - > #include > #include > > @@ -36,6 +32,10 @@ extern "C" { > > #include > > +#ifdef __cplusplus > +extern "C" { > +#endif > + > #define VFIO_DIR "/dev/vfio" > #define VFIO_CONTAINER_PATH "/dev/vfio/vfio" > #define VFIO_GROUP_FMT "/dev/vfio/%u" This hunk above should be out of the #idef VFIO_PRESENT. > diff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h > index 132f37506d..5234c1697f 100644 > --- a/lib/hash/rte_thash_gfni.h > +++ b/lib/hash/rte_thash_gfni.h > @@ -5,10 +5,6 @@ > #ifndef _RTE_THASH_GFNI_H_ > #define _RTE_THASH_GFNI_H_ > > -#ifdef __cplusplus > -extern "C" { > -#endif > - > #include > #include > > @@ -16,6 +12,10 @@ extern "C" { > > #include > > +#ifdef __cplusplus > +extern "C" { > +#endif > + > #endif > > /** This hunk above should be out of the #idef RTE_ARCH_X86. --=20 David Marchand