From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by dpdk.org (Postfix) with ESMTP id 574711B5C4 for ; Wed, 17 Apr 2019 10:46:32 +0200 (CEST) Received: by mail-ua1-f65.google.com with SMTP id p13so7631657uaa.11 for ; Wed, 17 Apr 2019 01:46:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0iyHZmPIbBs9CnHgKRZvPvTVcRHqVuYgR11zkBcLFVo=; b=WBNcP8pMcDc1xDqIywHrFtKQ9X9WjjBKblttblebFIrHk3BvMROx3yU/r2ZRHHiutg G5ZneIMT8ZbMqfwKVYwxNfkQowy0fj/FXYTbiFNN25Z8SVrxOAw7JgXQ1ukUb2Aiq5BR Gb9qumylIwSLUIgF7kZXc28VDF2OSGhcpvAn29mmGWs08lbryhSv+oiCoiFXfjZ17Dq1 GK6spdGiUot7b45x2XcXdxBlLXlQfKzPu5Str2zHcSSLvRE1nMkABWceR34SI30jM2L4 cLf+FXnbSCH+IEXshQWp6d2Hlbpf0klG8SPnICJHZjAuePzZiV7Ehq9e0j58rKXoF/KA tD5w== X-Gm-Message-State: APjAAAUxZg+wmpFuFHE/sfGnVrW4qz2Cgxwjth5DyoerflnqkjW4K3jL PH+262uQSnzy5eKiWEweIjppZ4yOPyr2VqqDh2Debg== X-Google-Smtp-Source: APXvYqxkVXC0qJ2TnU0liRDVIuoqxXLkp+9mKwnpyTdj12brWjEzielGz7mvCg4ndv46nHqe/0VDfjyGArMb5JypK+0= X-Received: by 2002:ab0:6994:: with SMTP id t20mr35750005uaq.105.1555490791662; Wed, 17 Apr 2019 01:46:31 -0700 (PDT) MIME-Version: 1.0 References: <20190417160834.75103-1-qiming.yang@intel.com> In-Reply-To: <20190417160834.75103-1-qiming.yang@intel.com> From: David Marchand Date: Wed, 17 Apr 2019 10:46:20 +0200 Message-ID: To: Qiming Yang Cc: dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix info get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 08:46:32 -0000 On Wed, Apr 17, 2019 at 10:41 AM Qiming Yang wrote: > iavf driver reset the dev_info structure. This action will clear > the setting in core library. This patch fix that issue. > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > "Cc: stable@dpdk.org" is supposed to be part of the commitlog. See http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported > Signed-off-by: Qiming Yang > --- > drivers/net/iavf/iavf_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_ethdev.c > b/drivers/net/iavf/iavf_ethdev.c > index 846e604..7825cbc 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -498,7 +498,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > { > struct iavf_info *vf = > IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > > - memset(dev_info, 0, sizeof(*dev_info)); > dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs; > dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs; > dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN; > -- > 2.9.5 > > Reviewed-by: David Marchand -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AB388A00E6 for ; Wed, 17 Apr 2019 10:46:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7EE971B5C5; Wed, 17 Apr 2019 10:46:33 +0200 (CEST) Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by dpdk.org (Postfix) with ESMTP id 574711B5C4 for ; Wed, 17 Apr 2019 10:46:32 +0200 (CEST) Received: by mail-ua1-f65.google.com with SMTP id p13so7631657uaa.11 for ; Wed, 17 Apr 2019 01:46:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0iyHZmPIbBs9CnHgKRZvPvTVcRHqVuYgR11zkBcLFVo=; b=WBNcP8pMcDc1xDqIywHrFtKQ9X9WjjBKblttblebFIrHk3BvMROx3yU/r2ZRHHiutg G5ZneIMT8ZbMqfwKVYwxNfkQowy0fj/FXYTbiFNN25Z8SVrxOAw7JgXQ1ukUb2Aiq5BR Gb9qumylIwSLUIgF7kZXc28VDF2OSGhcpvAn29mmGWs08lbryhSv+oiCoiFXfjZ17Dq1 GK6spdGiUot7b45x2XcXdxBlLXlQfKzPu5Str2zHcSSLvRE1nMkABWceR34SI30jM2L4 cLf+FXnbSCH+IEXshQWp6d2Hlbpf0klG8SPnICJHZjAuePzZiV7Ehq9e0j58rKXoF/KA tD5w== X-Gm-Message-State: APjAAAUxZg+wmpFuFHE/sfGnVrW4qz2Cgxwjth5DyoerflnqkjW4K3jL PH+262uQSnzy5eKiWEweIjppZ4yOPyr2VqqDh2Debg== X-Google-Smtp-Source: APXvYqxkVXC0qJ2TnU0liRDVIuoqxXLkp+9mKwnpyTdj12brWjEzielGz7mvCg4ndv46nHqe/0VDfjyGArMb5JypK+0= X-Received: by 2002:ab0:6994:: with SMTP id t20mr35750005uaq.105.1555490791662; Wed, 17 Apr 2019 01:46:31 -0700 (PDT) MIME-Version: 1.0 References: <20190417160834.75103-1-qiming.yang@intel.com> In-Reply-To: <20190417160834.75103-1-qiming.yang@intel.com> From: David Marchand Date: Wed, 17 Apr 2019 10:46:20 +0200 Message-ID: To: Qiming Yang Cc: dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix info get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417084620.oS93wTIVgxZFqZroKJO1Yi-qJ8i7qN_uaE4TjCb5JbI@z> On Wed, Apr 17, 2019 at 10:41 AM Qiming Yang wrote: > iavf driver reset the dev_info structure. This action will clear > the setting in core library. This patch fix that issue. > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > "Cc: stable@dpdk.org" is supposed to be part of the commitlog. See http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported > Signed-off-by: Qiming Yang > --- > drivers/net/iavf/iavf_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_ethdev.c > b/drivers/net/iavf/iavf_ethdev.c > index 846e604..7825cbc 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -498,7 +498,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > { > struct iavf_info *vf = > IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > > - memset(dev_info, 0, sizeof(*dev_info)); > dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs; > dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs; > dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN; > -- > 2.9.5 > > Reviewed-by: David Marchand -- David Marchand