From: David Marchand <david.marchand@redhat.com>
To: Eelco Chaudron <echaudro@redhat.com>
Cc: Beilei Xing <beilei.xing@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
Date: Thu, 12 Sep 2019 14:02:12 +0200 [thread overview]
Message-ID: <CAJFAV8whJfx4+ZSfh4SOBFdZRAMAcgmkabrtLK1XrA5o6eU7AQ@mail.gmail.com> (raw)
In-Reply-To: <8daee65a8edeae439ba9c2542877744b5be53684.1568284682.git.echaudro@redhat.com>
On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com> wrote:
>
> When receiving the unsupported AQ messages, it's taken as an
> error. It's not appropriate and triggers too much unnecessary print.
>
> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
> unnecessary error log") which made the same change for the PF instance.
>
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index c77b30c54..7b1d485c6 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
> }
> break;
> default:
> - PMD_DRV_LOG(ERR, "Request %u is not supported yet",
> + PMD_DRV_LOG(DEBUG, "Request %u is not supported yet",
> aq_opc);
> break;
> }
> --
> 2.18.1
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2019-09-12 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 10:38 Eelco Chaudron
2019-09-12 12:02 ` David Marchand [this message]
2019-09-12 12:40 ` Ye Xiaolong
2019-09-12 12:56 ` Eelco Chaudron
2019-09-13 9:00 ` Eelco Chaudron
2019-09-13 13:24 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8whJfx4+ZSfh4SOBFdZRAMAcgmkabrtLK1XrA5o6eU7AQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).