From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09FECA2EEB for ; Thu, 12 Sep 2019 14:02:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C44751E94E; Thu, 12 Sep 2019 14:02:27 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B67531BF40 for ; Thu, 12 Sep 2019 14:02:25 +0200 (CEST) Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 263FD59465 for ; Thu, 12 Sep 2019 12:02:25 +0000 (UTC) Received: by mail-vk1-f199.google.com with SMTP id j8so9496335vkn.16 for ; Thu, 12 Sep 2019 05:02:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/8EvDFLQA5OtD989Aex37hBgVUDCc2roABvSKLkW9yo=; b=i/Uc5OUiDo/rKsTi52+6jX7m0sgA/LMnhMimNoaUBG8MHI6EmaoMgrgBr5+C0zkOcQ VK3pKTixZFBECkibfI+bqSiH+cRw8ZuI+vcG9J95m2D95C/nZozT9ErnVgGWZ/9tGJfS 1R+uejqtztRte3LCuafGt8M8UNolYmT6cSthq88cPKykOe4rV+8Vn7NsCZ7HrcnlQ17N YtGIJ3IwmkkG10vex5P3vDJJgx0Xh5MJx1a8ODoiTLOq+Urm++G7+BqkErwB7Z6+d35E PvNae7aTb7bTo1u9+8x5oISlEQmfe9arY1Jz5iodHfuzavlvFbYeQM/UQITOUp+NcYqJ DE/w== X-Gm-Message-State: APjAAAUcjim7YwYe/hqSyzubm6BSLSXd+ryK7ikWJH69p0wa0m0IOlHC jbuSgT8Bs1Ean2PFED+7YlHcfHqZsWiWZh/4oZKqzAAQTixenWcQzr/viYEDmroiegCN2v26lqO ZcbVk++a4Yo3v4CO1WOM= X-Received: by 2002:a1f:f2cd:: with SMTP id q196mr19500219vkh.31.1568289744289; Thu, 12 Sep 2019 05:02:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwPNvS2QEnQccDBDF9g3fpfmSSCbQ/5qjKtGYNqLIrt6AGE+hJIOanOL6fTny5dmEDW+0/L3v96c9DjKvW20d8= X-Received: by 2002:a1f:f2cd:: with SMTP id q196mr19500198vkh.31.1568289743905; Thu, 12 Sep 2019 05:02:23 -0700 (PDT) MIME-Version: 1.0 References: <8daee65a8edeae439ba9c2542877744b5be53684.1568284682.git.echaudro@redhat.com> In-Reply-To: <8daee65a8edeae439ba9c2542877744b5be53684.1568284682.git.echaudro@redhat.com> From: David Marchand Date: Thu, 12 Sep 2019 14:02:12 +0200 Message-ID: To: Eelco Chaudron Cc: Beilei Xing , Qi Zhang , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron wrote: > > When receiving the unsupported AQ messages, it's taken as an > error. It's not appropriate and triggers too much unnecessary print. > > This commit is similar to commit e130425300b0 ("net/i40e: downgrade > unnecessary error log") which made the same change for the PF instance. > > Signed-off-by: Eelco Chaudron > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index c77b30c54..7b1d485c6 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev) > } > break; > default: > - PMD_DRV_LOG(ERR, "Request %u is not supported yet", > + PMD_DRV_LOG(DEBUG, "Request %u is not supported yet", > aq_opc); > break; > } > -- > 2.18.1 > Reviewed-by: David Marchand -- David Marchand