From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00F4B42CA8; Tue, 13 Jun 2023 11:51:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EA7941149; Tue, 13 Jun 2023 11:51:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 09B2040698 for ; Tue, 13 Jun 2023 11:51:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686649862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Sm5tZB5dDVKREYoQ6d48eJfN3gtdtGl1UoIZdPQO7s=; b=Sa7+BXne+q7Yl8X76Q2KZWvim+TOgAgplcRAhsoiO3W1reYvyxg0p8T9K2WwF7OfYQ8NjE FnK3Ttxphi5RoPUOE1R7EKLBJYEyeCAko4PyX8ZN7fR+QWdYjzqfPmidq9X1XnXr6u7qeF SFoBF5jcMQiuXpGcVJb8fJAw0/nRvnI= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-R-Z7S5ccP_i38xwMHmkZLA-1; Tue, 13 Jun 2023 05:51:01 -0400 X-MC-Unique: R-Z7S5ccP_i38xwMHmkZLA-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-25c13937316so278945a91.2 for ; Tue, 13 Jun 2023 02:51:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686649860; x=1689241860; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Sm5tZB5dDVKREYoQ6d48eJfN3gtdtGl1UoIZdPQO7s=; b=UBhgYP4HMX8//2ynv6avtzyyNYY51xKmYnvARC1pwaXCft8Y5tSr3eUMMZbD0RZG2z cdcYe0NpV9wap7cgarFkIXRHXmQ15PdyDu1ik6kWlPjv87FQhabuc1bVTnux7MM0JVDs 0AF+NlCDC/UsCGEExRe7IX7L3HsK/dDIWfsJBrg0vEYJkRUSftLXA766FQE7JAMXhz+/ oV2G5Bwr0/lI7RfQ+OcZXnYo6Vkuq2AsIJPz1ooVJFg/CkMMaqiltIqE6S6sv0HChq4g jhSp4ddPvoGohSD1Rek1VR6arlJFTCzs7c1yHf7rJ7BqMM+qV5QhniGgF69nt/+fwdDk cleA== X-Gm-Message-State: AC+VfDzH0TgWz3WJ6FmPKU90/4vTaDfhAMXNg7PcrLPVUECWP6qaqnDJ GCsB1sQ6mf/4aZM6jRgPldeJn6MU3nYiFl8vCEJh8QR1FrVWwYwXnQmm7TeWEFH5fEXflt/peJy 5PEkKnE1uDuJCOOd4XTE= X-Received: by 2002:a17:90a:1c:b0:253:572f:79b2 with SMTP id 28-20020a17090a001c00b00253572f79b2mr9045734pja.36.1686649860189; Tue, 13 Jun 2023 02:51:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ78m4VdysbiPL+otXeSQ52Cx1Hbwd/gxWEccPfNK+Jvigj77QfSxSSy16rrRrRV2h6mJUZ1zLhprOlhmb/zA6c= X-Received: by 2002:a17:90a:1c:b0:253:572f:79b2 with SMTP id 28-20020a17090a001c00b00253572f79b2mr9045727pja.36.1686649859912; Tue, 13 Jun 2023 02:50:59 -0700 (PDT) MIME-Version: 1.0 References: <20230612163242.GB18991@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20230612163242.GB18991@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Tue, 13 Jun 2023 11:50:48 +0200 Message-ID: Subject: Re: [Bug 1249] [dpdk-23.07] ixgbe port stop failed after launch testpmd To: Tyler Retzlaff , Qiming Yang , Wenjun Wu Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Mon, Jun 12, 2023 at 6:32=E2=80=AFPM Tyler Retzlaff wrote: > If there has been a broad regression here could I ask for your help in > either reverting it until I can look at it properly or if you see the > obvious problem fixing it. > > There were multiple instances of flags being converted to bool in the > series it may be that they all need to be backed out. I relooked at Tyler series, and I think the net/ixgbe patch is the only one that has an issue. It converted: - rte_atomic32_t link_thread_running; + bool link_thread_running; IIUC, link_thread_running was used as a kind of refcount before Tyler chang= e. So rather than revert, I suppose the fix is to move to a uint32_t (and rename the variable maybe). ixgbe maintainers, please confirm. --=20 David Marchand