From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23E81A0C43; Fri, 22 Oct 2021 07:56:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A26014068C; Fri, 22 Oct 2021 07:55:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1D30040040 for ; Fri, 22 Oct 2021 07:55:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634882157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=59K655cmx1AMFOvYso+ZtEnOQblXRJ9RBmt8V20YtnE=; b=Z31OH/Q3EhRyrMS2R3VQYMVXoPcw3VPUV5c4cUaRsDjJu76tuY+aXPJ31tuOV246GJhLHT pGaRI6rczDgeKWHfS5l5IWNlvnNo5LZ1rqsj40xPLlfEvCyLd4KMyifuIP8wvdKLF2drZ2 iF4YtB20MX6ZWzRYrzx9C1dHmxnY1Tk= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-46-pkXq9cEePSue8OfO7ecghw-1; Fri, 22 Oct 2021 01:55:54 -0400 X-MC-Unique: pkXq9cEePSue8OfO7ecghw-1 Received: by mail-lf1-f69.google.com with SMTP id p19-20020a056512139300b003ff6dfea137so1246454lfa.9 for ; Thu, 21 Oct 2021 22:55:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=59K655cmx1AMFOvYso+ZtEnOQblXRJ9RBmt8V20YtnE=; b=v5gJr3eF9amhoF/cANCJNODim/kfc0YjZq5zUChuSdbuxWTmWaohudOBq0/OPzAIF3 Wp7TB3gauYxNp0QTXpun3iHr/oFRGc1UIV60DMO1tipHcTD3aQRs8ODS4IKJU45fylpK pbi6+fOsQDHI7AsffKHuEiDQGxQdz+ByCh3fKWtLi9hv6WkJLo0IelxB0vVQ6+Gk8oOS pF68D8V+bF7xbLyIud9ZD8DaUHwbmy1bLFXYIbyjZCdzcjtNoG0537dSHCN6yD0PnMhh k3oA0xFmEysV5mZ3A6aellFvwjlpMJU3Ux3YEkejTUsGFNL9M/hD08Kl5Bn/Z2zXebdC Kegw== X-Gm-Message-State: AOAM532+s2ApMP8Zbze24+OFNi5Wk3sucYYbWKxJERANiZSV/W//cRg0 L5BSTnaqiGTLZtTi40A6Cx7RXOcyYQIq4CGVsdZoLJEaMzjqw9G4druqVB2gGYhNfPB+idVoQp7 limHItke25lispWIMS00= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr9414643lfu.575.1634882152496; Thu, 21 Oct 2021 22:55:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGO2/sJ5n/smKgvZA996TBDVRmJ8UZlZ2Nzu2J/YeIZWACkc6TCh/S+fatx9jFBO+pXp9bdxsdNewBHuTLvSg= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr9414626lfu.575.1634882152299; Thu, 21 Oct 2021 22:55:52 -0700 (PDT) MIME-Version: 1.0 References: <6dabad2f3b015ea429397e4585f5c47f8ad121ad.1634873109.git.gmuthukrishn@marvell.com> In-Reply-To: <6dabad2f3b015ea429397e4585f5c47f8ad121ad.1634873109.git.gmuthukrishn@marvell.com> From: David Marchand Date: Fri, 22 Oct 2021 07:55:40 +0200 Message-ID: To: Gowrishankar Muthukrishnan , Bruce Richardson Cc: dev , Olivier Matz , Andrew Rybchenko , Jerin Jacob Kollanukkaran Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [v2] mempool: add telemetry endpoint for mempool info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 22, 2021 at 5:28 AM Gowrishankar Muthukrishnan wrote: > > Add telemetry endpoint for mempool info. > > Signed-off-by: Gowrishankar Muthukrishnan > Reviewed-by: Bruce Richardson Windows compilation is broken. FAILED: lib/librte_mempool.a.p/mempool_rte_mempool.c.obj "clang" "-Ilib\librte_mempool.a.p" "-Ilib" "-I..\lib" "-Ilib\mempool" "-I..\lib\mempool" "-I." "-I.." "-Iconfig" "-I..\config" "-Ilib\eal\include" "-I..\lib\eal\include" "-Ilib\eal\windows\include" "-I..\lib\eal\windows\include" "-Ilib\eal\x86\include" "-I..\lib\eal\x86\include" "-Ilib\eal\common" "-I..\lib\eal\common" "-Ilib\eal" "-I..\lib\eal" "-Ilib\kvargs" "-I..\lib\kvargs" "-Ilib\ring" "-I..\lib\ring" "-Xclang" "-fcolor-diagnostics" "-pipe" "-D_FILE_OFFSET_BITS=64" "-Wall" "-Winvalid-pch" "-Werror" "-O3" "-include" "rte_config.h" "-Wextra" "-Wcast-qual" "-Wdeprecated" "-Wformat" "-Wformat-nonliteral" "-Wformat-security" "-Wmissing-declarations" "-Wmissing-prototypes" "-Wnested-externs" "-Wold-style-definition" "-Wpointer-arith" "-Wsign-compare" "-Wstrict-prototypes" "-Wundef" "-Wwrite-strings" "-Wno-address-of-packed-member" "-Wno-missing-field-initializers" "-D_GNU_SOURCE" "-D_WIN32_WINNT=0x0A00" "-D_CRT_SECURE_NO_WARNINGS" "-march=native" "-DALLOW_EXPERIMENTAL_API" "-DALLOW_INTERNAL_API" "-DRTE_LOG_DEFAULT_LOGTYPE=lib.mempool" -MD -MQ lib/librte_mempool.a.p/mempool_rte_mempool.c.obj -MF "lib\librte_mempool.a.p\mempool_rte_mempool.c.obj.d" -o lib/librte_mempool.a.p/mempool_rte_mempool.c.obj "-c" ../lib/mempool/rte_mempool.c ../lib/mempool/rte_mempool.c:34:10: fatal error: 'rte_telemetry.h' file not found #include ^~~~~~~~~~~~~~~~~ 1 error generated. Linux builds are fine, I checked locally: [1/212] ccache cc -Ilib/librte_mempool.a.p -Ilib -I../lib -Ilib/mempool -I../lib/mempool -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/ring -I../lib/ring -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -DRTE_LOG_DEFAULT_LOGTYPE=lib.mempool -MD -MQ lib/librte_mempool.a.p/mempool_rte_mempool.c.o -MF lib/librte_mempool.a.p/mempool_rte_mempool.c.o.d -o lib/librte_mempool.a.p/mempool_rte_mempool.c.o -c ../lib/mempool/rte_mempool.c I guess there is an implicit dependency pulling telemetry for Linux. mempool had no dependency to telemetry so far, you need to add en explicit dependency in meson.build deps array. -- David Marchand