From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73ACB45F1E; Mon, 23 Dec 2024 09:43:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BFEB40263; Mon, 23 Dec 2024 09:43:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1FA0540156 for ; Mon, 23 Dec 2024 09:43:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734943432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SwH/BLjThZLwUNUKzFrOEYts3YjdebHJk65Ps6Jcats=; b=ZO0l7dwXsJ2ldiAyhiMlFdaIrStt6DtxpgUVzVle6BD+9hVVD6tqywOZ9fQcrEzHDevMab G5Q3LZoK9YtZMqGj93XwoPUUz60eQjqndi0jc6mLTqtEa2Q3m8VZxmvf91121mFKqFL9J9 br/wwXTVH95DK8WOfkeLONT5PkjN6gY= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-8Zw0EZ6rN--1OcfEhDl2dQ-1; Mon, 23 Dec 2024 03:43:51 -0500 X-MC-Unique: 8Zw0EZ6rN--1OcfEhDl2dQ-1 X-Mimecast-MFC-AGG-ID: 8Zw0EZ6rN--1OcfEhDl2dQ Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5401b7d34ceso2288638e87.0 for ; Mon, 23 Dec 2024 00:43:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734943429; x=1735548229; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SwH/BLjThZLwUNUKzFrOEYts3YjdebHJk65Ps6Jcats=; b=dAmPx1c0Mxs56y2LOQgVscwZHh2g5ekGh13S9zHxr35Ug1nWbnfRUM5adfjm8717bG iW4XCRlkoav0wQM/xqVb3eAwHmVZhIWUgd+XgJBfn2LEqLYyzQQ2X/iIrRjvJU3OmHXR vX/kCIP855sQDnx+CWLSbZLWGjOD0e/nei4QNrrAbqZPq1cTN9qNdM403pGhucB3DVhU i7MP27uxXjffEj+L+lmUsU/hqtuYaoIWU/vsTeQeL3dw1TanOgjdioNBbqAVwFCSQObB clIvPhHGvEwiDgPKtD4Bula9mje/in8JyiGn4/9ieBmkE4T/wDGxbAmfW1325gvoTq+3 PweQ== X-Gm-Message-State: AOJu0Yy7QWLlsc1o3sjxC23JTnB+//oNvJtPB2LCBRAib1nRR5wKvHKf bxQklGyTTUStz/gSPrNS2iz8dg+MeddAF0ZcnZbbgCgfl9m0OdpwmZ53KSpNS48k23t174630gK LUS/oymKaVwqgVUv11gwzpSRmR75iciZKMEZ9PjamRSRjwxm1RXjDrlxJj0aJjkvqvFcXybHL/D 1Kh+WNKtrnSQyKDNrwVTlaPpN8BQ== X-Gm-Gg: ASbGncttB4rdW6XbZo0XwSygI5DgbDBIPUD4TnRthzxLXeJqOq/O2iNXO3xPtpdQmL+ BkuFIkLMHJ9uu5q3NGVbU1vGxZMQUxQKKv4HaWwEg X-Received: by 2002:a05:6512:3f0c:b0:53e:3a7d:a1df with SMTP id 2adb3069b0e04-542295619ecmr3366525e87.45.1734943429592; Mon, 23 Dec 2024 00:43:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHG9QmBL5gFFECv6AjTtmtoi4NeNnyYtMn6aKKcV9j774wtxMt2x4XPl1p3dRiy0i+KsIHgjmW51dTnvaivuBM= X-Received: by 2002:a05:6512:3f0c:b0:53e:3a7d:a1df with SMTP id 2adb3069b0e04-542295619ecmr3366520e87.45.1734943429219; Mon, 23 Dec 2024 00:43:49 -0800 (PST) MIME-Version: 1.0 References: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com> <1733954844-24397-1-git-send-email-andremue@linux.microsoft.com> <1733954844-24397-6-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1733954844-24397-6-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Mon, 23 Dec 2024 09:43:38 +0100 Message-ID: Subject: Re: [PATCH v2 05/14] drivers/bus: use portable variadic macros To: Andre Muezerie Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jlt7uF0bD0Ba2T-VbsPEyzFJJ14f0JbPjjYlY156dAE_1734943430 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 11, 2024 at 11:09=E2=80=AFPM Andre Muezerie wrote: > > Many places are using a GCC extension related to variadic macros, > where a name prepends the ellipsis. This results in a warning like > the one below when compiling the code with MSVC: > > app\test-pmd\testpmd.h(1314): error C2608: > invalid token '...' in macro parameter list > > Variadic macros became a standard part of the C language with C99. > GCC, Clang and MSVC handle them properly. > > The fix is to remove the prefix name (args... becomes ...) and use > __VA_ARGS__. > > Signed-off-by: Andre Muezerie There is one missed occurence: $ git grep 'define.*[^([:space:]]\.\.\..*)' -- drivers/bus/ drivers/bus/fslmc/qbman/include/compat.h:#define pr_debug(fmt, args...) {} This does not require a new revision, I'll fix it myself when applying. --=20 David Marchand