From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com
[209.85.222.42]) by dpdk.org (Postfix) with ESMTP id EF7B41B805
for <dev@dpdk.org>; Thu, 18 Apr 2019 09:11:33 +0200 (CEST)
Received: by mail-ua1-f42.google.com with SMTP id c13so432964uao.12
for <dev@dpdk.org>; Thu, 18 Apr 2019 00:11:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=yZfM97AEth0kehxo8ZvfZlD2pX8DXx0EMlhklvp764A=;
b=FAxE38y882E7dYMpR+69cMg6QbR0wsDul/XZ362Vfaswp6Ed1oYOpI+0SYE8HFjGs9
U7deP9GE+aZIGEEow9pNfUNbGQfhvni3GRzxuirEV8aflOuzKdekaftJ/vEo+PawIEbQ
HLwEODe4Cr6JnO9ftj3URo82KhXUM/hfoARz5lLE2wKtBDfAQ0I201qCdAqWFH/bW+5K
On/AH9oZ00UPv/wbptiU66Gx4oWc5ih3t27+NsYszNuMD6+QugX4AWF00Y0zUjAm4BHQ
fijsfmWtn94G8bw+qMsLPiSRj/xPPe5Q2eLhX/AS+GDos1FPMcNiTsK524VlmurhXS94
GsDw==
X-Gm-Message-State: APjAAAXY+bgaUmVf5FADIgofdtJkywVWvUNmVtYNZzqxpKWIVdAodKaQ
a9xej+6SPeRjOAqzx+IGRRvRrr0oDkgoPTvbjHQaSA==
X-Google-Smtp-Source: APXvYqyb1sBYnkARnDh7AF5neTeQsBfYE7ocOiJVvRF9+bMm3OIwdR/iIKbH4p1w5qAulO3MdJgT2TESenyiBlbFqz0=
X-Received: by 2002:ab0:1591:: with SMTP id i17mr48004020uae.41.1555571493128;
Thu, 18 Apr 2019 00:11:33 -0700 (PDT)
MIME-Version: 1.0
References: <1554900829-16180-1-git-send-email-david.marchand@redhat.com>
<1554900829-16180-3-git-send-email-david.marchand@redhat.com>
<9a4fa115-0f92-9686-ae89-0f1427ab6d29@gmail.com>
In-Reply-To: <9a4fa115-0f92-9686-ae89-0f1427ab6d29@gmail.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 18 Apr 2019 09:11:22 +0200
Message-ID: <CAJFAV8wj1=OKwU9RzFdrF0yDCcvjKR6HMdMfCFxJw85zQt5O5w@mail.gmail.com>
To: Chas Williams <3chas3@gmail.com>
Cc: dev <dev@dpdk.org>,
=?UTF-8?B?UHJ6ZW15c8WCYXcgT8WCdGFyemV3c2tp?= <p.oltarzewski@gmail.com>,
dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx
handler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Apr 2019 07:11:34 -0000
Hello Chas,
On Fri, Apr 12, 2019 at 4:02 PM Chas Williams <3chas3@gmail.com> wrote:
> I should have some time this weekend to run these patches through our
> regression system.
>
Did you manage to run this series through your tests system ?
> On 4/10/19 8:53 AM, David Marchand wrote:
> > @@ -357,10 +318,16 @@
> > hdr = rte_pktmbuf_mtod(bufs[j], struct ether_hdr
> *);
> > subtype = ((struct slow_protocol_frame
> *)hdr)->slow_protocol.subtype;
> >
> > - /* Remove packet from array if it is slow packet
> or slave is not
> > - * in collecting state or bonding interface is not
> in promiscuous
> > - * mode and packet address does not match. */
> > - if (unlikely(is_lacp_packets(hdr->ether_type,
> subtype, bufs[j]) ||
> > + /* Remove packet from array if:
> > + * - it is slow packet but no dedicated rxq is
> present,
> > + * - slave is not in collecting state,
> > + * - bonding interface is not in promiscuous mode
> and
> > + * packet is not multicast and address does not
> match,
> > + */
> > + if (unlikely(
>
> The coding style checker doesn't like this:
>
> CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
>
Yes, I had seen this warning, just found it easier to read this way.
> > + (!dedicated_rxq &&
> > + is_lacp_packets(hdr->ether_type, subtype,
> > + bufs[j])) ||
> > !collecting ||
> > (!promisc &&
> > !is_multicast_ether_addr(&hdr->d_addr) &&
>
>
--
David Marchand
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id E0E38A00E6
for <public@inbox.dpdk.org>; Thu, 18 Apr 2019 09:11:36 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 5FA081B924;
Thu, 18 Apr 2019 09:11:35 +0200 (CEST)
Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com
[209.85.222.42]) by dpdk.org (Postfix) with ESMTP id EF7B41B805
for <dev@dpdk.org>; Thu, 18 Apr 2019 09:11:33 +0200 (CEST)
Received: by mail-ua1-f42.google.com with SMTP id c13so432964uao.12
for <dev@dpdk.org>; Thu, 18 Apr 2019 00:11:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=yZfM97AEth0kehxo8ZvfZlD2pX8DXx0EMlhklvp764A=;
b=FAxE38y882E7dYMpR+69cMg6QbR0wsDul/XZ362Vfaswp6Ed1oYOpI+0SYE8HFjGs9
U7deP9GE+aZIGEEow9pNfUNbGQfhvni3GRzxuirEV8aflOuzKdekaftJ/vEo+PawIEbQ
HLwEODe4Cr6JnO9ftj3URo82KhXUM/hfoARz5lLE2wKtBDfAQ0I201qCdAqWFH/bW+5K
On/AH9oZ00UPv/wbptiU66Gx4oWc5ih3t27+NsYszNuMD6+QugX4AWF00Y0zUjAm4BHQ
fijsfmWtn94G8bw+qMsLPiSRj/xPPe5Q2eLhX/AS+GDos1FPMcNiTsK524VlmurhXS94
GsDw==
X-Gm-Message-State: APjAAAXY+bgaUmVf5FADIgofdtJkywVWvUNmVtYNZzqxpKWIVdAodKaQ
a9xej+6SPeRjOAqzx+IGRRvRrr0oDkgoPTvbjHQaSA==
X-Google-Smtp-Source: APXvYqyb1sBYnkARnDh7AF5neTeQsBfYE7ocOiJVvRF9+bMm3OIwdR/iIKbH4p1w5qAulO3MdJgT2TESenyiBlbFqz0=
X-Received: by 2002:ab0:1591:: with SMTP id i17mr48004020uae.41.1555571493128;
Thu, 18 Apr 2019 00:11:33 -0700 (PDT)
MIME-Version: 1.0
References: <1554900829-16180-1-git-send-email-david.marchand@redhat.com>
<1554900829-16180-3-git-send-email-david.marchand@redhat.com>
<9a4fa115-0f92-9686-ae89-0f1427ab6d29@gmail.com>
In-Reply-To: <9a4fa115-0f92-9686-ae89-0f1427ab6d29@gmail.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 18 Apr 2019 09:11:22 +0200
Message-ID:
<CAJFAV8wj1=OKwU9RzFdrF0yDCcvjKR6HMdMfCFxJw85zQt5O5w@mail.gmail.com>
To: Chas Williams <3chas3@gmail.com>
Cc: dev <dev@dpdk.org>,
=?UTF-8?B?UHJ6ZW15c8WCYXcgT8WCdGFyemV3c2tp?= <p.oltarzewski@gmail.com>,
dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx
handler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190418071122.UrohTDLMKy97eA2J_tpvsWK9MpelExygQ0VYGKWYqlk@z>
Hello Chas,
On Fri, Apr 12, 2019 at 4:02 PM Chas Williams <3chas3@gmail.com> wrote:
> I should have some time this weekend to run these patches through our
> regression system.
>
Did you manage to run this series through your tests system ?
> On 4/10/19 8:53 AM, David Marchand wrote:
> > @@ -357,10 +318,16 @@
> > hdr = rte_pktmbuf_mtod(bufs[j], struct ether_hdr
> *);
> > subtype = ((struct slow_protocol_frame
> *)hdr)->slow_protocol.subtype;
> >
> > - /* Remove packet from array if it is slow packet
> or slave is not
> > - * in collecting state or bonding interface is not
> in promiscuous
> > - * mode and packet address does not match. */
> > - if (unlikely(is_lacp_packets(hdr->ether_type,
> subtype, bufs[j]) ||
> > + /* Remove packet from array if:
> > + * - it is slow packet but no dedicated rxq is
> present,
> > + * - slave is not in collecting state,
> > + * - bonding interface is not in promiscuous mode
> and
> > + * packet is not multicast and address does not
> match,
> > + */
> > + if (unlikely(
>
> The coding style checker doesn't like this:
>
> CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
>
Yes, I had seen this warning, just found it easier to read this way.
> > + (!dedicated_rxq &&
> > + is_lacp_packets(hdr->ether_type, subtype,
> > + bufs[j])) ||
> > !collecting ||
> > (!promisc &&
> > !is_multicast_ether_addr(&hdr->d_addr) &&
>
>
--
David Marchand