From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CFD3A056C; Wed, 4 Mar 2020 11:18:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56FBE1BFA9; Wed, 4 Mar 2020 11:18:05 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 22FCF1BFA5 for ; Wed, 4 Mar 2020 11:18:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583317083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOK7mFYmKskghJo3nyuXHlDaYCRv5s/M+Icr7nJKcLI=; b=ao+6bJyCfLfBG1WEr2HZpmm/bVp1CKc1gsnAPROnwtbZUBUgKSOcM6CqadUTJZ6WnWntTV +wgdCLppXd/kwJD+vvOOAMxzW/PuBfT3wP6kNPT/Ev9UsEy6yr1Sn9/N+rtgXUFi3CideC t+oh3+pidP3aWPIGL6R0X/PPg52HL6Y= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-5Ti8i1zmOSWHp5p_kO-olw-1; Wed, 04 Mar 2020 05:18:00 -0500 X-MC-Unique: 5Ti8i1zmOSWHp5p_kO-olw-1 Received: by mail-vk1-f199.google.com with SMTP id z24so542924vkn.0 for ; Wed, 04 Mar 2020 02:18:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MNFsmG0RQbstkjVTPgy1YFuQaESnDeLCCXnLwu1H3iQ=; b=Wo9hk4bPayw6KIdBGYWWfu8+lk2wASL51X0vQtQTtV2yuF9lssJ10kImqK2JlbMhaT 5wma7kzMzDdMzhLlsOGOk5G2ZfrCJlbzMXEHEn7FoAVzROP5Mxzg1t9Hf/ha1MblBi9b EvMjg/k+jICLtyUAegF8I/hjqgNTl3wTx/g7FbsWxk8b8vYWyIyx1i+W+ma8ZL0WOzv3 gpwOsEEeliKEpCkCSXh3D+nc1T89GtEA9gi3wADaeRRH8DJ2cgs4XeuyVZP1zmQN2nFc myFbMd+7ZluwDY/1+1uZj/WrR4ARC8LMn1K+lPw0Fe0bv1102qLNe3Rcur4h0NfQXBJJ nKnw== X-Gm-Message-State: ANhLgQ3bhV9tQzOXn1/vxy9lW42+/Majcdel7a+8pHbmFzp6ismmxROL fgm2FTKzXAqpcYfHOCre3PKrJFNyKD3BYQx1OhaiuY7pOrGa0RpVWIT9nXBHQKjbA8tLre80rvq dK3o2wEBTGZT7y1SGOpg= X-Received: by 2002:a67:905:: with SMTP id 5mr1312054vsj.105.1583317079831; Wed, 04 Mar 2020 02:17:59 -0800 (PST) X-Google-Smtp-Source: ADFU+vuQw8FAVR7JsPt2R429aH2QroohaMQBueOBP7sR0aM8iAaCuRY2cvC5iwjZzETu4sjNupRsKAUbeVFLFyghoMQ= X-Received: by 2002:a67:905:: with SMTP id 5mr1312047vsj.105.1583317079561; Wed, 04 Mar 2020 02:17:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 4 Mar 2020 11:17:48 +0100 Message-ID: To: Timothy Redaelli Cc: dev , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 0/3] examples: fix building with GCC 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 4, 2020 at 10:37 AM David Marchand wrote: > > On Wed, Feb 5, 2020 at 2:47 PM Timothy Redaelli wr= ote: > > > > GCC 10 defaults to -fno-common, this means a linker error will now be > > reported if the same global variable is defined in more than one > > compilation unit. > > > > See https://gcc.gnu.org/gcc-10/porting_to.html for more informations. > > > > I didn't put -fcommon to CFLAGS since: > > Compiling with -fno-common is useful on targets for which it provides > > better performance, or if you wish to verify that the program will wo= rk > > on other systems that always treat uninitialized variable definitions > > this way. > > from gcc man page > > For the series, > Acked-by: David Marchand Series applied, thanks. --=20 David Marchand