From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBD6EA00C2; Wed, 30 Nov 2022 16:24:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2710F410D1; Wed, 30 Nov 2022 16:24:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2542340395 for ; Wed, 30 Nov 2022 16:24:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669821872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cWCVaQrIbRQKBxsWUn+K3YFRp7LwvLe1FbUxdfeOt5w=; b=AWGy7As3tr0atMhJNUoYH9rO5UNFBYGWHeOR7L9OliGfFLfuqIxmaLq3PZxMsstw98QWF3 hWcy1zG1AgXhGtiKONKr0/jCFTLZM1/wiDXZ3ZWCwLuE3Tz67ASBLjQO4ZslQLUON9JrPB EmrE3sm/2j2QyFyQysMd1Bu1+PD7+Ho= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-316-Sjbb_jBONo2tdOu54rNfsQ-1; Wed, 30 Nov 2022 10:24:31 -0500 X-MC-Unique: Sjbb_jBONo2tdOu54rNfsQ-1 Received: by mail-pf1-f199.google.com with SMTP id 145-20020a621497000000b00574fab7294dso10354809pfu.13 for ; Wed, 30 Nov 2022 07:24:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cWCVaQrIbRQKBxsWUn+K3YFRp7LwvLe1FbUxdfeOt5w=; b=PQsGfW2bYyJ3Fm1YKZVhrEGrsEHecSFT7i1l3tyu3qwKhhVlK7BPga2eAJtCEF7w+S Wc3bftB1pAH6aIyTTfrn9jSJx+4N0+1dngtc3CsJLIQibY3s4ObRu6P2hcNl65jbWT8k ycH1FMwFxpbifvFldQ+Jj1qIpQK5rXpJZLHH0NsJu9S20PQBMrEDUH1pVW/CKnEVXQXI XHG01ZtLUQBnQSQfr2XKwJH4Y/PxGkdpuLj1wEEBxszhypt1bTrDFWNpFKGNjxeQatyU +9yqNJx0cW7taN3eLiukxwT8zkNgfVYSEbHeSqENHtozAe6dBYkKVE0z0Khl9XNwDufk 4oMw== X-Gm-Message-State: ANoB5pkU4jRAGPalA8talE7/bZXp81OKDK/tRfNTu9aD7s57p/7ajCIF CJTzA/vbVEKd/qUMhhzVfNTg8lDUw6xDGZHHbydILHyQvdIkJySYikiaXGelzjkgzL4zT6H6z8z pXtHOB1CaDdlkn1IJqjY= X-Received: by 2002:a05:6a00:24c1:b0:56e:a001:8cb0 with SMTP id d1-20020a056a0024c100b0056ea0018cb0mr43732957pfv.60.1669821869992; Wed, 30 Nov 2022 07:24:29 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ynoX2Q+5xAgdKEQY2/3i1VgbJDbd/JaMzIGjTN+bKD7oxeeJDzvV1zaskPfj1xaNAijgXuB4loZeOYCLUByE= X-Received: by 2002:a05:6a00:24c1:b0:56e:a001:8cb0 with SMTP id d1-20020a056a0024c100b0056ea0018cb0mr43732937pfv.60.1669821869626; Wed, 30 Nov 2022 07:24:29 -0800 (PST) MIME-Version: 1.0 References: <20221129140032.35940-1-david.marchand@redhat.com> <20221130100204.214181-1-david.marchand@redhat.com> <191d5966-dd66-3a26-2789-6c6e5ce78aa2@amd.com> In-Reply-To: From: David Marchand Date: Wed, 30 Nov 2022 16:24:17 +0100 Message-ID: Subject: Re: [PATCH v2] drivers: fix symbol exports when map is omitted To: Luca Boccassi Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= , Ferruh Yigit , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 30, 2022 at 4:02 PM David Marchand wrote: > On Wed, Nov 30, 2022 at 11:44 AM Ferruh Yigit wrote: > > > > On 11/30/2022 10:02 AM, David Marchand wrote: > > > ld exports any global symbol by default if no version script is passed. > > > As a consequence, the incriminated change let any public symbol leak > > > out of the driver shared libraries. > > > > > > Hide again those symbols by providing a default map file which > > > unexports any global symbol using a local: * catch-all statement. > > > > > > The checks are skipped for this default map file as it is intentionnally > > > an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol > > > maps")) and there is nothing else to check in this map. > > > > > > While at it, move Windows specific objects where needed for better > > > readability. > > > > > > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") > > > Cc: stable@dpdk.org > > > > > > Reported-by: Luca Boccassi > > > Signed-off-by: David Marchand > > > Tested-by: Ferruh Yigit > > > > Tested v2, looks good. > > 'check-symbol-maps.sh' warning fixed too. > > Thanks Ferruh. > > Bruce / Luca, could you review / confirm it is ok for you? Additionnally, Luca, could you describe how you caught the issue? Could we enhance the CI to catch this earlier? -- David Marchand