From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, chenbox@nvidia.com
Subject: Re: [PATCH v2 4/6] vhost: refactor VDUSE reconnection log mapping
Date: Thu, 24 Oct 2024 10:34:16 +0200 [thread overview]
Message-ID: <CAJFAV8wk85B6+=dfG_Gp48qjuo7s8t1ODZ6j_nP1JDjci-uTpg@mail.gmail.com> (raw)
In-Reply-To: <20241024075441.3723352-5-maxime.coquelin@redhat.com>
On Thu, Oct 24, 2024 at 9:54 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
> - goto out_ctrl_close;
> - }
> -
> - reconnect_log = mmap(NULL, sizeof(*reconnect_log), PROT_READ | PROT_WRITE,
> - MAP_SHARED, reco_fd, 0);
> - close(reco_fd);
> - if (reconnect_log == MAP_FAILED) {
> - VHOST_CONFIG_LOG(name, ERR, "Failed to mmap reconnect file %s (%s)",
> - reconnect_file, strerror(errno));
> - ret = -1;
> + VHOST_CONFIG_LOG(name, ERR, "Failed to create reconnect log file");
You missed removing this one.
That's just a rebase issue, since patch 6 will remove it.
> goto out_ctrl_close;
> }
--
David Marchand
next prev parent reply other threads:[~2024-10-24 8:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 7:54 [PATCH v2 0/6] VDUSE reconnection fixes and cleanup Maxime Coquelin
2024-10-24 7:54 ` [PATCH v2 1/6] vhost: fix VDUSE device creation error handling Maxime Coquelin
2024-10-24 7:54 ` [PATCH v2 2/6] vhost: fix possible TOCTOU in VDUSE dev creation Maxime Coquelin
2024-10-24 7:54 ` [PATCH v2 3/6] vhost: fix VDUSE reconnect device start failure Maxime Coquelin
2024-10-24 7:54 ` [PATCH v2 4/6] vhost: refactor VDUSE reconnection log mapping Maxime Coquelin
2024-10-24 8:34 ` David Marchand [this message]
2024-10-24 7:54 ` [PATCH v2 5/6] vhost: fix and refactor VDUSE reconnect log check Maxime Coquelin
2024-10-24 8:36 ` David Marchand
2024-10-24 9:44 ` Maxime Coquelin
2024-10-24 7:54 ` [PATCH v2 6/6] vhost: move VDUSE reconnection after device is created Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wk85B6+=dfG_Gp48qjuo7s8t1ODZ6j_nP1JDjci-uTpg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).