Re: [PATCH v2 4/6] vhost: refactor VDUSE reconnection log mapping

[David Marchand <david.marchand@redhat.com>]

On Thu, Oct 24, 2024 at 9:54 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
> -                       goto out_ctrl_close;
> -               }
> -
> -               reconnect_log = mmap(NULL, sizeof(*reconnect_log), PROT_READ | PROT_WRITE,
> -                                       MAP_SHARED, reco_fd, 0);
> -               close(reco_fd);
> -               if (reconnect_log == MAP_FAILED) {
> -                       VHOST_CONFIG_LOG(name, ERR, "Failed to mmap reconnect file %s (%s)",
> -                                       reconnect_file, strerror(errno));
> -                       ret = -1;
> +                       VHOST_CONFIG_LOG(name, ERR, "Failed to create reconnect log file");

You missed removing this one.
That's just a rebase issue, since patch 6 will remove it.


>                         goto out_ctrl_close;
>                 }


-- 
David Marchand