From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 395B745BC0; Thu, 24 Oct 2024 10:34:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D600F4339A; Thu, 24 Oct 2024 10:34:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 11E7D43352 for ; Thu, 24 Oct 2024 10:34:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729758871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GHSF+UVqmpW2ICAzf7T3SgbJk0JCATlgKwbc5AW6cjs=; b=boG10zFDmJX5sNwwA8X1oVJXhLESHAnSWUEkzQTWb9Ya8qizwXt/BtSVxPXWgzg3PTwtXZ fefHNfrwNQ3bZ/ZfRTbM97lP+1tARldCiEx/5F4cVt+YtZd754p0rxv9n1wVl7XsJYelu+ 0BfMiRZd5VAozxiIKweyym26rWESBzw= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-DljT74RtMaa37lGiMgCluw-1; Thu, 24 Oct 2024 04:34:29 -0400 X-MC-Unique: DljT74RtMaa37lGiMgCluw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-539fbf73a2fso381812e87.2 for ; Thu, 24 Oct 2024 01:34:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729758868; x=1730363668; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GHSF+UVqmpW2ICAzf7T3SgbJk0JCATlgKwbc5AW6cjs=; b=EiYhFz9mFXkdTz4trOOIIwDd3mbP2a5akq4pk249c9TzHFqv8Q3SDmd0AQwnTthGOy kqX06CSgpDwcfXsYOmdGKL1fEyL3u7DErL5ARK4iKfpvy7WtIE3k/ktKb+KSpSAHQYVf WHiPig+GcPLS4qr4SW5Q7Z9pRmcvZWjIsoJ7m/aG0p8ArIJreCRcD+43PsB0Ubg0D6MF RQW0psF2GQF2hcKNstz/QoJvUQjMwxvtSmJyjJZMfGQbEN+oEtgJ3lpBgYG8YO6jlI4n tEnPMJ1oE2Sc3fHTWumgAH2/R7C30+JxwZsuGaqeveXoc4P8OCr5gsdnrond9H/ldoD3 3aIg== X-Gm-Message-State: AOJu0YyNVHS2Ak/QTXQ5mW//Rx8r2W1kOSI9UUYimGaOTQYkmm8sLAEE VnIENzgMtC5UXtiuYdvPHAiFdn5NyCHgA0Wvqfi6K5jE/eie9oWLwd/6wPVKni134wtg6rSR38I yFuSvBswRENBg5VMbf/2rHLNUF9w3duUmECM121wO2WhL03YUpECrNIlwiRdFaQthHovaEfd7Wx ZYhRCUm50xajlbOL8= X-Received: by 2002:a05:6512:1586:b0:539:89a8:5fe8 with SMTP id 2adb3069b0e04-53b1a30f7c5mr3222910e87.29.1729758868148; Thu, 24 Oct 2024 01:34:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IER5yzgxsPwcQUDoN5Uy4+hAlYmapSO8YS4j7G2Sxw8B4C/SyrYuvjlZ5kth3E8JQowyNz/MBvW/d3xLw4EYbk= X-Received: by 2002:a05:6512:1586:b0:539:89a8:5fe8 with SMTP id 2adb3069b0e04-53b1a30f7c5mr3222892e87.29.1729758867777; Thu, 24 Oct 2024 01:34:27 -0700 (PDT) MIME-Version: 1.0 References: <20241024075441.3723352-1-maxime.coquelin@redhat.com> <20241024075441.3723352-5-maxime.coquelin@redhat.com> In-Reply-To: <20241024075441.3723352-5-maxime.coquelin@redhat.com> From: David Marchand Date: Thu, 24 Oct 2024 10:34:16 +0200 Message-ID: Subject: Re: [PATCH v2 4/6] vhost: refactor VDUSE reconnection log mapping To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 24, 2024 at 9:54=E2=80=AFAM Maxime Coquelin wrote: > - goto out_ctrl_close; > - } > - > - reconnect_log =3D mmap(NULL, sizeof(*reconnect_log), PROT= _READ | PROT_WRITE, > - MAP_SHARED, reco_fd, 0); > - close(reco_fd); > - if (reconnect_log =3D=3D MAP_FAILED) { > - VHOST_CONFIG_LOG(name, ERR, "Failed to mmap recon= nect file %s (%s)", > - reconnect_file, strerror(errno)); > - ret =3D -1; > + VHOST_CONFIG_LOG(name, ERR, "Failed to create rec= onnect log file"); You missed removing this one. That's just a rebase issue, since patch 6 will remove it. > goto out_ctrl_close; > } --=20 David Marchand