From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com
 [209.85.222.53]) by dpdk.org (Postfix) with ESMTP id AAA2F1B11A
 for <dev@dpdk.org>; Thu,  3 Jan 2019 14:03:14 +0100 (CET)
Received: by mail-ua1-f53.google.com with SMTP id z11so10888171uaa.10
 for <dev@dpdk.org>; Thu, 03 Jan 2019 05:03:14 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=2LFrv/450Ec+bINuhcmdXvqqHlTgv3hby8HBfYV85SQ=;
 b=t7zBIlYMHUYM9AR5HgEA001rB56ES2FddLpnNS+NDf28xev84WEk26S6ttlAEiYhbr
 LF8B6Fi+sW3V7mFNt4Yovhhl/O+jeQmNB8pXvTgbxzEG29BpG/T9xH22SU++wP9/wq4n
 V4bE7hVmoZS6PBw9SswbEW88s1bAydrNFssZcXMq1ySExXfA6dXYqSfoe39yp9HrEnrm
 Ah1iuZwI/ERKApeTOG/PHNI77O9/NMNkINuTzCwTlCrQ++2Fh02jBW/7yEMD2l3rJp8T
 w6lUcbvAyaec4bh10tWbQHfdH6jVU3fD3avn+LcOUwQ14KGDQTtXGR73o0ZKmpA5c+MY
 clXQ==
X-Gm-Message-State: AJcUukckceiop1IQi5g6xSCUNzFivQiP2vm4g4F3YH5EAZCNMRCFkjK5
 oZjJUerxSice4jhE9oFX79INPh4SisgDDjWy/vNL9Q==
X-Google-Smtp-Source: ALg8bN4G5cWe86CzQi5gs/fBrJ5+i8oTzDsgLWBzerHz0XVIWwTwRfSYK46h100x956PCEoi86Qm87cdbegg7EIdloU=
X-Received: by 2002:ab0:4121:: with SMTP id j30mr16882449uad.65.1546520593784; 
 Thu, 03 Jan 2019 05:03:13 -0800 (PST)
MIME-Version: 1.0
References: <1546518487-9942-1-git-send-email-hari.kumarx.vemula@intel.com>
In-Reply-To: <1546518487-9942-1-git-send-email-hari.kumarx.vemula@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 3 Jan 2019 14:03:02 +0100
Message-ID: <CAJFAV8wmDuNnx2Yms_0gSkUpg7s3g-2C0S_uuH6ZBcrekCQ-Sg@mail.gmail.com>
To: Hari kumar Vemula <hari.kumarx.vemula@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, reshma.pattan@intel.com, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, jananeex.m.parthasarathy@intel.com
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2] eal: fix core number validation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jan 2019 13:03:14 -0000

On Thu, Jan 3, 2019 at 1:28 PM Hari kumar Vemula <
hari.kumarx.vemula@intel.com> wrote:

> When incorrect core value or range provided,
> as part of -l command line option, a crash occurs.
>
> Added valid range checks to fix the crash.
>
> Fixes: d888cb8b9613 ("eal: add core list input format")
> Cc: stable@dpdk.org
>
> --
> v2: Replace strtoul with strtol
>     Modified log message
>

You did not take my other comments into account and the ut updates are
missing.


-- 
David Marchand