From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D815F45B50; Wed, 16 Oct 2024 11:25:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2A5240144; Wed, 16 Oct 2024 11:25:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 34E35400D6 for ; Wed, 16 Oct 2024 11:25:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729070706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7F3pMQ2eZ1K4WO/7HO7s5oVWRBLR16PXHXU4Rg/VTCw=; b=Zhn+UDmm+Kjpo7m2d/cMRDzoteARqzv40JuLAblE+ScX3bsH+SCtdC8dg1r5MLkiOoF/iL NMg94gTtq0XHK3viIXkUn7Ii/Gf3xf55W6aqkYDhstEC8ZwKxkzQdh/nJsJdLLQ/cToG5C Idq2gRDvyKDlrZS+BWFQgz8JlkQ+DLQ= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-p2I13nCkOwK0rXGsdXPGUg-1; Wed, 16 Oct 2024 05:25:05 -0400 X-MC-Unique: p2I13nCkOwK0rXGsdXPGUg-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2fb5a195d63so15137471fa.3 for ; Wed, 16 Oct 2024 02:25:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729070704; x=1729675504; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7F3pMQ2eZ1K4WO/7HO7s5oVWRBLR16PXHXU4Rg/VTCw=; b=Y7szI5W7NrUp68S0rl1H7+MG6BL+qj9xUBJZhP0hOcXb/ggx9iWD/9S9OU+D0+JAU7 katgeOIn++tCGeNgQogWzBp49BEWrCxrvUlZY3lrMI8z7sKLog47iP017ntBR11E3lpe /8i9Zz+/oWBfYiBoFmgzhv01sSWOm0/vQkniWF0sZW5UKwYkCPRcI2ufJ4IOmBGfHQV8 uPvwA30xFdNVysrLFtvgcsuUuNOBfAK08TWAeP2d4qxtpHyzfgE7Hyke8LOO0/KTCybn YugVuyrdwE/vSHe9OAeiiNBhou8bF11fwNdnHMVU65dQV5o3NaYZly5TWZuAZKJSJJM3 L3ww== X-Forwarded-Encrypted: i=1; AJvYcCVVmbMW2emLFFF/3UP8ToeL6ROt5ZaRz5FsIJWcmDETW+aJ82bm+V/4VxRzexUiQokl1Vw=@dpdk.org X-Gm-Message-State: AOJu0YwOhrfM8bGYeJoYtvjHeDIuA5w583L/b0+xBH2o9rlXpxzOfTFC UulmSa7B3X8skOvSaE6tgBt/wSA0saFIxNWt2OvBOeM0FAbRwzcZfTDyg9vAB/ooznINt4tTW3/ g5rkUpdVzd5O1tC61Pb/lH1rssVHCJgJSmMSC7rsCWjrmfqiR35D0CdAVhNSD5xFCd5lgMp0sCB mrMsoCnGMHHmtgJ+g= X-Received: by 2002:a05:651c:1546:b0:2fb:5a19:5b92 with SMTP id 38308e7fff4ca-2fb61bbdf38mr17707101fa.40.1729070704121; Wed, 16 Oct 2024 02:25:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCrFUQrRTdxywXyb+zRHPeaJZS7wMGj2mJd48asCa9K5FH87dxuJypdRselPpgLo4PXjiNA/Rwm3wS3Ox0K44= X-Received: by 2002:a05:651c:1546:b0:2fb:5a19:5b92 with SMTP id 38308e7fff4ca-2fb61bbdf38mr17706831fa.40.1729070703640; Wed, 16 Oct 2024 02:25:03 -0700 (PDT) MIME-Version: 1.0 References: <20240907073115.1531070-1-nsaxena@marvell.com> In-Reply-To: From: David Marchand Date: Wed, 16 Oct 2024 11:24:51 +0200 Message-ID: Subject: Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph To: Nitin Saxena Cc: Jerin Jacob , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , Zhirun Yan , "dev@dpdk.org" , Nitin Saxena , Robin Jarry , Christophe Fontaine X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 14, 2024 at 1:12=E2=80=AFPM Nitin Saxena = wrote: > I had pushed non RFC patch series before -rc1 date (11th oct). > We have an ABI change in this patch series https://patches.dpdk.org/proje= ct/dpdk/patch/20241010133111.2764712-3-nsaxena@marvell.com/ > Could you help merge this patch series in rc2 otherwise it has to wait fo= r next LTS Just read through the series, I am not confident with this addition. It requires a lot of changes in the node code for supporting it, where it should be something handled in/facilitated by the graph library itself. I did not read much from Robin or Christophe who have been writing more node code than me. I would prefer their opinion before going forward. On the ABI topic. As far as I can see, the only issue would be in extending struct rte_node_register, but this can be solved with function versioning. That change would have to be announced. Am I missing something else? --=20 David Marchand