From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 126E0A0563; Wed, 15 Apr 2020 18:37:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F5061D6E5; Wed, 15 Apr 2020 18:37:29 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 906271D6D9 for ; Wed, 15 Apr 2020 18:37:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586968646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=42CA77zuwE+EcaSqKM22E88QFsXuyg0cRNljzVGSCeU=; b=jIMrm3jCgO+2Te/GOwTD9gw1+vHgrwoSg4qVYIRRrU8b2B7jKfixzktJCDXkB4BzmUnOuP 8VZsC65iwDI6N1jQLegHLIrKKhZEnUG5ZssneKgf2y7hEx1HJoGjWpJtnQD55ZkE5w0gOi HrUdB5XAJEOCByJcCT71gCr++pIzU5E= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-277-6Vpims3KMCCpHpDWf9A6oA-1; Wed, 15 Apr 2020 12:37:23 -0400 X-MC-Unique: 6Vpims3KMCCpHpDWf9A6oA-1 Received: by mail-vk1-f198.google.com with SMTP id i26so1902296vkk.21 for ; Wed, 15 Apr 2020 09:37:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=42CA77zuwE+EcaSqKM22E88QFsXuyg0cRNljzVGSCeU=; b=iqKt1y4b1jrMXy+TB0AefXVHEgNVngLD7MIBYXetWQcTal9niWSzFHTStonq1d+Qw+ yq9r0QK+n4nc7kLAkNVBeBbZEkJGSUq8ZWjk2Ddl8CNSeB7NCp+byNKgoxypoVsM7LiN rYDWtMK3yN8uh4iSCDUWCWcmYrcHE1LNeJoNgDB68SjnDare5iGT40PWCF5CUkw0YE7m AlVgC9pI1whkYZe9Z5zJu+awNv1iqnsVtnKoRmdkSkX/10kOlPs9yw4r1GaOQ240k2Cp vXCJrc5SVf9719g/pAj1Irw7iLCz8CbqhrJWQP1genwwPYScQG1nIIDLxA3eM6bnbkyS DDNQ== X-Gm-Message-State: AGi0PuZCnPZW44HcKpsSK3ovsqjJeJSZsiJsqAi/vyn4w63z+N+x7Da4 ZHxyhMM7hywmpBV79YwdvK8/jXSdN0WUlqPrf34SLXOo36Dn7QUIXElixuIGH2uovadcKeV3QW1 wASpqBzUz6zvBSFNKR9Y= X-Received: by 2002:a05:6102:1043:: with SMTP id h3mr5415427vsq.39.1586968642470; Wed, 15 Apr 2020 09:37:22 -0700 (PDT) X-Google-Smtp-Source: APiQypJbiFaeHSeqZ5nMpQoA319p5N/gOIK9ruZaobHzx2zNeW3otN3Mjs1FU8ZBFlm3ia0ylHHEi8GF2OF8LPpwiSg= X-Received: by 2002:a05:6102:1043:: with SMTP id h3mr5415394vsq.39.1586968642017; Wed, 15 Apr 2020 09:37:22 -0700 (PDT) MIME-Version: 1.0 References: <20200309065106.23800-1-mattias.ronnblom@ericsson.com> In-Reply-To: From: David Marchand Date: Wed, 15 Apr 2020 18:37:10 +0200 Message-ID: To: Jerin Jacob Kollanukkaran , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: "dev@dpdk.org" , "stefan.sundkvist@ericsson.com" , "Ola.Liljedahl@arm.com" , ci@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] [PATCH 0/8] DSW performance and statistics improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran wrote: > > > -----Original Message----- > > From: Mattias R=C3=B6nnblom > > Sent: Monday, March 9, 2020 12:21 PM > > To: Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; stefan.sundkvist@ericsson.com; Ola.Liljedahl@arm.com; > > Mattias R=C3=B6nnblom > > Subject: [EXT] [PATCH 0/8] DSW performance and statistics improvements > > > > External Email > > > > ---------------------------------------------------------------------- > > Performance and statistics improvements for the distributed software > > (DSW) event device. > > > > Mattias R=C3=B6nnblom (8): > > event/dsw: reduce latency in low-load situations > > event/dsw: reduce max flows to speed up load balancing > > event/dsw: extend statistics > > event/dsw: improve migration mechanism > > event/dsw: avoid migration waves in large systems > > event/dsw: remove redundant control ring poll > > event/dsw: remove unnecessary read barrier > > event/dsw: add port busy cycles xstats > > Series applied to dpdk-next-eventdev/master. Thanks. I get a compilation issue on rhel7. Too bad the CI did not help. http://patchwork.dpdk.org/project/dpdk/list/?series=3D8828&state=3D* [1583/1808] Compiling C object 'drivers/drivers@@tmp_rte_pmd_dsw_event@sta/event_dsw_dsw_event.c.o'. ../drivers/event/dsw/dsw_event.c: In function =E2=80=98dsw_port_consider_em= igration=E2=80=99: ../drivers/event/dsw/dsw_event.c:502:27: warning: =E2=80=98candidate_qf=E2= =80=99 may be used uninitialized in this function [-Wmaybe-uninitialized] target_qfs[*targets_len] =3D *candidate_qf; ^ ../drivers/event/dsw/dsw_event.c:445:25: note: =E2=80=98candidate_qf=E2=80= =99 was declared here struct dsw_queue_flow *candidate_qf; ^ In file included from ../lib/librte_eal/x86/include/rte_atomic.h:16:0, from ../lib/librte_eal/include/generic/rte_rwlock.h:25, from ../lib/librte_eal/x86/include/rte_rwlock.h:12, from ../lib/librte_eal/include/rte_fbarray.h:40, from ../lib/librte_eal/include/rte_memory.h:25, from ../lib/librte_eventdev/rte_event_ring.h:20, from ../drivers/event/dsw/dsw_evdev.h:8, from ../drivers/event/dsw/dsw_event.c:5: ../lib/librte_eal/include/generic/rte_atomic.h:566:22: warning: =E2=80=98candidate_flow_load=E2=80=99 may be used uninitialized in this fun= ction [-Wmaybe-uninitialized] __sync_fetch_and_add(&v->cnt, inc); ^ ../drivers/event/dsw/dsw_event.c:448:10: note: =E2=80=98candidate_flow_load= =E2=80=99 was declared here int16_t candidate_flow_load; ^ ../drivers/event/dsw/dsw_event.c:505:49: warning: =E2=80=98candidate_port_i= d=E2=80=99 may be used uninitialized in this function [-Wmaybe-uninitialized] rte_atomic32_add(&dsw->ports[candidate_port_id].immigration_load, ^ ../drivers/event/dsw/dsw_event.c:446:10: note: =E2=80=98candidate_port_id= =E2=80=99 was declared here uint8_t candidate_port_id; ^ --=20 David Marchand