From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 470C742FD3; Fri, 4 Aug 2023 15:02:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7D5E40EE1; Fri, 4 Aug 2023 15:02:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0B10C40E2D for ; Fri, 4 Aug 2023 15:02:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691154158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lEejUPDsFcWWSRWARg0RryttwF/ywLrAssXXp+9JZJ8=; b=LLytiH0ZgYtiA4X6v5QcTOI77JvOcjSTCQJp60kNMO9o9x5AxitsDcVanJGqa6QPoczp/U mzmuk4AjPu+QUBhsWa02L4xWORk846e3dHuCX/sWijdi8lnXjdkeISTU/6dsns+o5+HIYd 7EJzK0Ws6bKbHMryYbVWtqwFKNHeZdE= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-0GkoNvxQPta2n06wCZZhyQ-1; Fri, 04 Aug 2023 09:02:36 -0400 X-MC-Unique: 0GkoNvxQPta2n06wCZZhyQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2b9f0b7af1cso23342791fa.3 for ; Fri, 04 Aug 2023 06:02:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691154155; x=1691758955; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lEejUPDsFcWWSRWARg0RryttwF/ywLrAssXXp+9JZJ8=; b=OrsDrntnDVsqCrcLlhrNaPBVF0y/akUTsQAMhg+X5P1YiHXyan786CmWWq/dJoAk1w bdNM6NuS316jop7B9onZ5BpekNbBrsJBGMWe/Dfikb6JgG9BgC8Y1e7xAdzTPcsoNYAq et5IfmYqZzVLpo9Fgt2ElD/QENXrwxgnYBf/ts5z/fPILRVdJuIU9+KJbrLRN26qQ5UV UIdPz9kECPtCFFOcfsBh4dmPijzw1poq4rKgOMkDXJPjeFWzs/PGNwnq+iryNv8gTImx sobOrgt3zPPq6jvol3nMUgbN4ss30rOi2Sa3IBroprKUdQz+AQxfR8sl4VOmuUgp0lWB q+WA== X-Gm-Message-State: AOJu0YyvSfb1uc1HOD22BZ+oeKRG211k0ZJqiJBh689iguPux9VglWH5 ayixAtJQEj9kiVDJTNSVMvItmIAKEpIiFRhGdHuezQ+ESi5qXnwoP0rRuF/QohXgeeFRHwA0qzP QStkIGq8JDbnEBic62rg= X-Received: by 2002:a2e:9003:0:b0:2b9:eb9d:cc53 with SMTP id h3-20020a2e9003000000b002b9eb9dcc53mr1528535ljg.42.1691154155210; Fri, 04 Aug 2023 06:02:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElJmc9jtKfMh0LSLJqpytOz6oROEEFx8Iu9v81E5VbVxSuLUJzmbYxChe3bgQCM7pT/8eghjeVHVF3/kyOUTQ= X-Received: by 2002:a2e:9003:0:b0:2b9:eb9d:cc53 with SMTP id h3-20020a2e9003000000b002b9eb9dcc53mr1528519ljg.42.1691154154909; Fri, 04 Aug 2023 06:02:34 -0700 (PDT) MIME-Version: 1.0 References: <20230801160500.67480-1-stephen@networkplumber.org> In-Reply-To: <20230801160500.67480-1-stephen@networkplumber.org> From: David Marchand Date: Fri, 4 Aug 2023 15:02:23 +0200 Message-ID: Subject: Re: [PATCH v2 0/2] Remove disabled functionality To: Stephen Hemminger Cc: dev@dpdk.org, Thomas Monjalon , Ferruh Yigit , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 1, 2023 at 6:05=E2=80=AFPM Stephen Hemminger wrote: > > The KNI and flow_classify library were already marked disabled > in 23.11 release. > > Stephen Hemminger (2): > flow_classify: remove library > kni: remove deprecated kernel network interface > > MAINTAINERS | 17 - > app/test/meson.build | 6 - > app/test/test_flow_classify.c | 895 ------------------ > app/test/test_flow_classify.h | 26 - > app/test/test_kni.c | 740 --------------- > doc/api/doxy-api-index.md | 3 - > doc/api/doxy-api.conf.in | 2 - > doc/guides/contributing/documentation.rst | 4 +- > doc/guides/freebsd_gsg/build_sample_apps.rst | 2 +- > doc/guides/freebsd_gsg/install_from_ports.rst | 2 +- > doc/guides/howto/flow_bifurcation.rst | 3 +- > doc/guides/nics/index.rst | 1 - > doc/guides/nics/kni.rst | 170 ---- > doc/guides/nics/virtio.rst | 92 +- > .../prog_guide/env_abstraction_layer.rst | 2 - > doc/guides/prog_guide/flow_classify_lib.rst | 424 --------- > doc/guides/prog_guide/glossary.rst | 3 - > doc/guides/prog_guide/index.rst | 2 - > .../prog_guide/kernel_nic_interface.rst | 423 --------- > doc/guides/prog_guide/packet_framework.rst | 9 +- > doc/guides/rel_notes/deprecation.rst | 15 +- > doc/guides/rel_notes/release_23_11.rst | 4 + > doc/guides/sample_app_ug/flow_classify.rst | 242 ----- > doc/guides/sample_app_ug/index.rst | 1 - > doc/guides/sample_app_ug/ip_pipeline.rst | 22 - > drivers/net/cnxk/cnxk_ethdev.c | 2 +- > drivers/net/kni/meson.build | 11 - > drivers/net/kni/rte_eth_kni.c | 524 ---------- > drivers/net/meson.build | 1 - > examples/flow_classify/Makefile | 51 - > examples/flow_classify/flow_classify.c | 878 ----------------- > examples/flow_classify/ipv4_rules_file.txt | 14 - > examples/flow_classify/meson.build | 13 - > examples/ip_pipeline/Makefile | 1 - > examples/ip_pipeline/cli.c | 95 -- > examples/ip_pipeline/examples/kni.cli | 69 -- > examples/ip_pipeline/kni.c | 168 ---- > examples/ip_pipeline/kni.h | 46 - > examples/ip_pipeline/main.c | 10 - > examples/ip_pipeline/meson.build | 1 - > examples/ip_pipeline/pipeline.c | 57 -- > examples/ip_pipeline/pipeline.h | 2 - > examples/meson.build | 1 - > kernel/linux/kni/Kbuild | 6 - > kernel/linux/kni/compat.h | 157 --- > kernel/linux/kni/kni_dev.h | 137 --- > kernel/linux/kni/kni_fifo.h | 87 -- > kernel/linux/kni/kni_misc.c | 719 -------------- > kernel/linux/kni/kni_net.c | 878 ----------------- > kernel/linux/kni/meson.build | 41 - > kernel/linux/meson.build | 2 +- > lib/eal/common/eal_common_log.c | 1 - > lib/eal/include/rte_log.h | 2 +- > lib/eal/linux/eal.c | 19 - > lib/flow_classify/meson.build | 12 - > lib/flow_classify/rte_flow_classify.c | 670 ------------- > lib/flow_classify/rte_flow_classify.h | 284 ------ > lib/flow_classify/rte_flow_classify_parse.c | 532 ----------- > lib/flow_classify/rte_flow_classify_parse.h | 58 -- > lib/flow_classify/version.map | 13 - > lib/kni/meson.build | 21 - > lib/kni/rte_kni.c | 843 ----------------- > lib/kni/rte_kni.h | 269 ------ > lib/kni/rte_kni_common.h | 147 --- > lib/kni/rte_kni_fifo.h | 117 --- > lib/kni/version.map | 24 - > lib/meson.build | 9 - > lib/port/meson.build | 6 - > lib/port/rte_port_kni.c | 515 ---------- > lib/port/rte_port_kni.h | 63 -- > lib/port/version.map | 3 - > meson_options.txt | 2 +- > 72 files changed, 18 insertions(+), 10673 deletions(-) > delete mode 100644 app/test/test_flow_classify.c > delete mode 100644 app/test/test_flow_classify.h > delete mode 100644 app/test/test_kni.c > delete mode 100644 doc/guides/nics/kni.rst > delete mode 100644 doc/guides/prog_guide/flow_classify_lib.rst > delete mode 100644 doc/guides/prog_guide/kernel_nic_interface.rst > delete mode 100644 doc/guides/sample_app_ug/flow_classify.rst > delete mode 100644 drivers/net/kni/meson.build > delete mode 100644 drivers/net/kni/rte_eth_kni.c > delete mode 100644 examples/flow_classify/Makefile > delete mode 100644 examples/flow_classify/flow_classify.c > delete mode 100644 examples/flow_classify/ipv4_rules_file.txt > delete mode 100644 examples/flow_classify/meson.build > delete mode 100644 examples/ip_pipeline/examples/kni.cli > delete mode 100644 examples/ip_pipeline/kni.c > delete mode 100644 examples/ip_pipeline/kni.h > delete mode 100644 kernel/linux/kni/Kbuild > delete mode 100644 kernel/linux/kni/compat.h > delete mode 100644 kernel/linux/kni/kni_dev.h > delete mode 100644 kernel/linux/kni/kni_fifo.h > delete mode 100644 kernel/linux/kni/kni_misc.c > delete mode 100644 kernel/linux/kni/kni_net.c > delete mode 100644 kernel/linux/kni/meson.build > delete mode 100644 lib/flow_classify/meson.build > delete mode 100644 lib/flow_classify/rte_flow_classify.c > delete mode 100644 lib/flow_classify/rte_flow_classify.h > delete mode 100644 lib/flow_classify/rte_flow_classify_parse.c > delete mode 100644 lib/flow_classify/rte_flow_classify_parse.h > delete mode 100644 lib/flow_classify/version.map > delete mode 100644 lib/kni/meson.build > delete mode 100644 lib/kni/rte_kni.c > delete mode 100644 lib/kni/rte_kni.h > delete mode 100644 lib/kni/rte_kni_common.h > delete mode 100644 lib/kni/rte_kni_fifo.h > delete mode 100644 lib/kni/version.map > delete mode 100644 lib/port/rte_port_kni.c > delete mode 100644 lib/port/rte_port_kni.h It took some time to remove this code (especially the KNI bits). Thanks to all who contributed to the effort. Series applied, thanks. --=20 David Marchand