* Re: [dpdk-dev] [dts] [PATCH V1] tests/generic_filter: use flow api replace legancy [not found] <20210506151015.418101-1-BoX.C.Chen@intel.com> @ 2021-05-26 11:17 ` David Marchand 2021-05-27 2:14 ` Honnappa Nagarahalli 0 siblings, 1 reply; 2+ messages in thread From: David Marchand @ 2021-05-26 11:17 UTC (permalink / raw) To: Bo Chen Cc: dts, techboard, dev, Qi Zhang, Juraj Linkeš, Honnappa Nagarahalli, Aaron Conole On Thu, May 6, 2021 at 9:08 AM Bo Chen <BoX.C.Chen@intel.com> wrote: > > use flow api replace legancy filter command > > Signed-off-by: Bo Chen <BoX.C.Chen@intel.com> > --- > tests/TestSuite_generic_filter.py | 41 ++++++++++++++++++------------- > 1 file changed, 24 insertions(+), 17 deletions(-) > > diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py > index d4ea8926..f3ea9774 100644 > --- a/tests/TestSuite_generic_filter.py > +++ b/tests/TestSuite_generic_filter.py > @@ -119,6 +119,12 @@ class TestGeneric_filter(TestCase): > """ > Run before each test case. > """ > + if self._suite_result.test_case == "test_128_queues": > + print('will rebuild dpdk') > + self.dut.send_expect( > + "sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", Patching dpdk to pass a test means there is something wrong either in dpdk or in the test. -- David Marchand ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dts] [PATCH V1] tests/generic_filter: use flow api replace legancy 2021-05-26 11:17 ` [dpdk-dev] [dts] [PATCH V1] tests/generic_filter: use flow api replace legancy David Marchand @ 2021-05-27 2:14 ` Honnappa Nagarahalli 0 siblings, 0 replies; 2+ messages in thread From: Honnappa Nagarahalli @ 2021-05-27 2:14 UTC (permalink / raw) To: David Marchand, Bo Chen Cc: dts, techboard, dev, Qi Zhang, Juraj Linkeš, Aaron Conole, Tu, Lijuan, Honnappa Nagarahalli, nd, Richardson, Bruce, nd <snip> > > On Thu, May 6, 2021 at 9:08 AM Bo Chen <BoX.C.Chen@intel.com> wrote: > > > > use flow api replace legancy filter command > > > > Signed-off-by: Bo Chen <BoX.C.Chen@intel.com> > > --- > > tests/TestSuite_generic_filter.py | 41 > > ++++++++++++++++++------------- > > 1 file changed, 24 insertions(+), 17 deletions(-) > > > > diff --git a/tests/TestSuite_generic_filter.py > > b/tests/TestSuite_generic_filter.py > > index d4ea8926..f3ea9774 100644 > > --- a/tests/TestSuite_generic_filter.py > > +++ b/tests/TestSuite_generic_filter.py > > @@ -119,6 +119,12 @@ class TestGeneric_filter(TestCase): > > """ > > Run before each test case. > > """ > > + if self._suite_result.test_case == "test_128_queues": > > + print('will rebuild dpdk') > > + self.dut.send_expect( > > + "sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES > > + 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' > > + drivers/net/ixgbe/ixgbe_ethdev.h", > > Patching dpdk to pass a test means there is something wrong either in dpdk or > in the test. Thanks David for adding me. We are starting to discuss these issues in the DTS working group. This looks like a build configuration issue. i.e. meson build system should allow to configure driver specific constants. This is one of the topics that has come up in the meson build system improvements. > > > -- > David Marchand ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-27 2:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210506151015.418101-1-BoX.C.Chen@intel.com>
2021-05-26 11:17 ` [dpdk-dev] [dts] [PATCH V1] tests/generic_filter: use flow api replace legancy David Marchand
2021-05-27 2:14 ` Honnappa Nagarahalli
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).