From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40256A04B1; Wed, 4 Nov 2020 17:48:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE6BF2C16; Wed, 4 Nov 2020 17:48:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id E992B2BFF for ; Wed, 4 Nov 2020 17:48:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604508521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eDtNT07bbgqf79H+meJLibgA5E2n13tn40Y/vpEZSk8=; b=VT5S6YCiZP0jp04E2z+dr+c+epYlitF4Q5ysvHAFp7aU6sf8ljlQ6wFU9LL2tkyYCfcocI HRipPbRvnu3mqnqPxN3d+DUw1x/3bWOIzk6QrBTlGnFP7BvXgK9PA7cTq6yirCW4bW0sDq Jf2Whc+b6iB5CwtjH5btJEZ/6y6ErvY= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-NPwRGWH3NYa0A9IS2SqiDg-1; Wed, 04 Nov 2020 11:48:39 -0500 X-MC-Unique: NPwRGWH3NYa0A9IS2SqiDg-1 Received: by mail-ua1-f71.google.com with SMTP id y12so1729216uan.14 for ; Wed, 04 Nov 2020 08:48:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eDtNT07bbgqf79H+meJLibgA5E2n13tn40Y/vpEZSk8=; b=Ux+dOAn9kLJ351cigfl9jL5mezXU7oAGtyfczPhwqtvLvALfeYnHM/f6RsEsaV/v61 Q6Kn6kArCGruxTFVa3sC3rVM+q+XlC6K4h1VauYCQd6GKJoXKKQgfzXFk975gvDDoGCT 1QsVPGtp4l72MQEa55+lVJIEBwmRDGdFV2YKahyZQRIBGjyiEkM8kCmOUZgV37mDvnNx +7O5v9pXb1f41DhGi7FtEB0xJ0/3CaZorMNDrbO7YYSA3fInNFOgKDM9GGNJF9I7FrUa 5L6LmSfKvRqQsCv10CfvyFvuCVWHID1cvEoNY6JOp/gLoyDWAfl06QAgp7zJA6Sqmwz9 OwUg== X-Gm-Message-State: AOAM530yOnf4NfHEhj1JXZftR43eST1erCg6j1aOMaSb6Mh7HFePpXEE nVaLLygJEBTAxQXZLYCnEDSJT8xBQqz68T0JJYLQ/dQIvw2NyyH24GwjLNzqPNrO10hIs+CV8rU Bm6YZT+AbQA6VbtgoFbs= X-Received: by 2002:a67:fd46:: with SMTP id g6mr9281117vsr.27.1604508519205; Wed, 04 Nov 2020 08:48:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSW4NbrTXtfHHeuWizrO91x8R3bbD5Kx/8pDhf+TWifoOaVxJCCkiz25Y1xRkqkHT45ZatWaYTaC9ApAPMbYA= X-Received: by 2002:a67:fd46:: with SMTP id g6mr9281102vsr.27.1604508518950; Wed, 04 Nov 2020 08:48:38 -0800 (PST) MIME-Version: 1.0 References: <20201103183906.8088-1-david.marchand@redhat.com> <20201104155721.21627-1-david.marchand@redhat.com> <20201104163546.GA65@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201104163546.GA65@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Wed, 4 Nov 2020 17:48:27 +0100 Message-ID: To: Bruce Richardson Cc: dev , Robin Jarry , Stephen Hemminger , Olivier Matz , Neil Horman , Rosen Xu , Andrew Rybchenko , Luca Boccassi Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] usertools: fix pmdinfo parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 4, 2020 at 5:36 PM Bruce Richardson wrote: > > On Wed, Nov 04, 2020 at 04:57:21PM +0100, David Marchand wrote: > > This script inspects an ELF file (binary or shared library) and its > > linked dependencies by following DT_NEEDED tags. > > So far a simple librte_pmd prefix was used as a filter to only parse > > DPDK drivers dependencies. > > While the reason is not clear from the commitlog of the patch that > > introduced this filter, it was probably added for performance reasons, > > since going through all dependencies can be quite long. > > Testing with a DPDK built before the driver name changes: > > - running the script takes ~0.3s with the filter, > > - running the script takes ~9s without the filter, > > > > Now that we changed the driver library names, it becomes more difficult > > to identify only DPDK drivers, but we can just filter on the librte_ > > prefix to identify DPDK libraries: the script later checks for the > > PMD_INFO_STRING string in .rodata and it is enough to differentiate the > > DPDK drivers from the other DPDK libraries. > > A debug message was logged for each inspected file, it gives no useful > > information and is removed. > > > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > > > Signed-off-by: David Marchand > > Acked-by: Robin Jarry > > --- > > Changelog since v2: > > - revisited the issue and simplified to only filter on librte_ prefix, > > > > Given you provided some original perf numbers of 0.3 vs 9 seconds above, > rather than leave us all in suspense :-), can you perhaps provide the > numbers for this version too. Ah ah, yes, thought I had put it. I have values in the 0.40/0.50s range. -- David Marchand