From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 805D6A046B; Thu, 9 Jan 2020 17:49:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55E7D1DE48; Thu, 9 Jan 2020 17:49:44 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 197F91DE14 for ; Thu, 9 Jan 2020 17:49:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578588582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DVB1AIBE6zmPdvA6TqEFWU3aWvrLjEsBD+W0FS5Rl+A=; b=hw9jpklc36npsRFUuVR//xhFvDZfWPo1j44t7BV5UKMEh+0oFfWzyL+t3oD7LvMIH6Ygk+ vAWS1/Je97jPDsyWlqf1gDj7AQkQc6YBQLUSGM/2bXT9Crd/2TYcllc4VYVIt1oPHnhEgc WNNQ7+TuwJe6N0wwJCWOYzOJxxwJjPs= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-n4okdEIqNBqPUSK2h7MYdg-1; Thu, 09 Jan 2020 11:49:41 -0500 Received: by mail-vk1-f199.google.com with SMTP id t126so2452766vkg.6 for ; Thu, 09 Jan 2020 08:49:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CuC+qjRs5i2BFt+vDwQf8DxWtB579xzCZ5FlIAdgxWE=; b=QBJG7eecmp8l+U4PQcydSmGu/eIi/0z32DxOn96fZ5QBkZ86wsiGRbG+ZY7r3v+Dvl 6uwHXG4OPJMbKPAPPpeSgfvYtP1VhJOg64ZDLHl+XTQ3radPA1mqk5A/GYdwNO1s5EgW E28Tk/1vIwza9e8Ec9Pi8tgNYqY4o78YF6ksxMC39Jgx+xj/E/2NIgqZbrzH4rRq5WJw 0Cul2zSY73em7tIqpllElwgDAr9Y7WUsGy96IGl19Tr+gSpFeSSEaDF6NuaAQm27bjVT gp7i+f73ABMYo29thVkacPEZxv6wdEoXaWYWze60qez5fNm+3REs4zQBwk97nINDnGRx rTRw== X-Gm-Message-State: APjAAAWh9sRB3Qy0pZYn2W9i7ELeq6YiIpep56AUSKhbrUiWt6Cd26o6 zcnu9hkKE6U60BYpwO2TKxJTA4TSz6hv1+ki42KSr95OI1+xWWnT05DgHIvQCxrVJM7W+gzFv/D PhCAy7oQamhzGUyBom/k= X-Received: by 2002:a1f:72c3:: with SMTP id n186mr7018613vkc.12.1578588580733; Thu, 09 Jan 2020 08:49:40 -0800 (PST) X-Google-Smtp-Source: APXvYqw6zMhv6GVVVRXKhmcFQnwdjZyMEzdXSUbCBBdIaRjBYPKoFmJUHl9LAbI4NvYI3WQkWiaDLL9pXMZ5QOH0a0Q= X-Received: by 2002:a1f:72c3:: with SMTP id n186mr7018532vkc.12.1578588578995; Thu, 09 Jan 2020 08:49:38 -0800 (PST) MIME-Version: 1.0 References: <20191125161314.18804-1-david.marchand@redhat.com> <20191202152030.7800-1-david.marchand@redhat.com> <4177191.8F6SAcFxjW@xps> In-Reply-To: <4177191.8F6SAcFxjW@xps> From: David Marchand Date: Thu, 9 Jan 2020 17:49:28 +0100 Message-ID: To: Thomas Monjalon , Neil Horman Cc: dev , dpdk stable , Andrew Rybchenko , Ray Kinsella , John McNamara , Marko Kovacevic , Qiming Yang , Wenzhuo Lu , Nicolas Chautru , Declan Doherty , Adrien Mazarguil , Ferruh Yigit , Cristian Dumitrescu , Honnappa Nagarahalli X-MC-Unique: n4okdEIqNBqPUSK2h7MYdg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] mark experimental variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 9, 2020 at 3:13 PM Thomas Monjalon wrote: > > 02/12/2019 16:20, David Marchand: > > So far, we did not pay attention to direct access to variables but they > > are part of the API/ABI too and should be clearly identified. > > > > Introduce a __rte_experimental_var tag and mark existing exported > > variables. > > > > Fixes: a4bcd61de82d ("buildtools: add script to check experimental API = exports") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > --- > > + elif grep -qe "\(\.data\|\*COM\*\).*[[:space:]]$SYM$" $DUMPFILE &= & > > + ! grep -q "\.data\.experimental.*[[:space:]]$SYM$" $DUMPF= ILE > > I like such regex ;) Err.. thanks? > I don't know COM section but I am not an ELF expert. I am no ELF expert either. IIUC, this section is a special one used when generating object files for common symbols but the compiler is not sure where the actual symbol should go. It is then resolved as .data or .bss when linking. > Maybe you can just add a comment in the commit log about searching > the symbol in .data and COM sections, even if we don't know exactly why. Actually, this is a good thing you asked about it. I did a new check before/after the series. Example for rte_net_ice_dynflag_proto_xtr_vlan_mask. Before: /home/dmarchan/builds/build-gcc-shared/drivers/a715181@@tmp_rte_pmd_ice@sta= /net_ice_ice_rxtx.c.o 0000000000000008 O *COM* 0000000000000008 rte_net_ice_dynflag_proto_xtr_vlan_mask /home/dmarchan/builds/build-gcc-shared/drivers/a715181@@tmp_rte_pmd_ice@sta= /net_ice_ice_ethdev.c.o 0000000000000000 *UND* 0000000000000000 rte_net_ice_dynflag_proto_xtr_vlan_mask /home/dmarchan/builds/build-gcc-shared/drivers/libtmp_rte_pmd_ice.a 0000000000000000 *UND* 0000000000000000 rte_net_ice_dynflag_proto_xtr_vlan_mask 0000000000000008 O *COM* 0000000000000008 rte_net_ice_dynflag_proto_xtr_vlan_mask /home/dmarchan/builds/build-gcc-shared/drivers/librte_pmd_ice.a 0000000000000000 *UND* 0000000000000000 rte_net_ice_dynflag_proto_xtr_vlan_mask 0000000000000008 O *COM* 0000000000000008 rte_net_ice_dynflag_proto_xtr_vlan_mask /home/dmarchan/builds/build-gcc-shared/drivers/librte_pmd_ice.so.20.0.1 0000000000063890 g O .bss 0000000000000008 rte_net_ice_dynflag_proto_xtr_vlan_mask After: /home/dmarchan/builds/build-gcc-shared/drivers/a715181@@tmp_rte_pmd_ice@sta= /net_ice_ice_rxtx.c.o 0000000000000020 g O .data.experimental 0000000000000008 rte_net_ice_dynflag_proto_xtr_vlan_mask /home/dmarchan/builds/build-gcc-shared/drivers/a715181@@tmp_rte_pmd_ice@sta= /net_ice_ice_ethdev.c.o 0000000000000000 *UND* 0000000000000000 rte_net_ice_dynflag_proto_xtr_vlan_mask /home/dmarchan/builds/build-gcc-shared/drivers/libtmp_rte_pmd_ice.a 0000000000000000 *UND* 0000000000000000 rte_net_ice_dynflag_proto_xtr_vlan_mask 0000000000000020 g O .data.experimental 0000000000000008 rte_net_ice_dynflag_proto_xtr_vlan_mask /home/dmarchan/builds/build-gcc-shared/drivers/librte_pmd_ice.a 0000000000000000 *UND* 0000000000000000 rte_net_ice_dynflag_proto_xtr_vlan_mask 0000000000000020 g O .data.experimental 0000000000000008 rte_net_ice_dynflag_proto_xtr_vlan_mask /home/dmarchan/builds/build-gcc-shared/drivers/librte_pmd_ice.so.20.0.1 00000000000604f0 g O .data 0000000000000008 rte_net_ice_dynflag_proto_xtr_vlan_mask The thing that scares me is that the final symbol gets moved from .bss to .data in the .so. Neil? -- David Marchand