From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 713FE42490; Thu, 26 Jan 2023 10:30:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2606240A79; Thu, 26 Jan 2023 10:30:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7B33040697 for ; Thu, 26 Jan 2023 10:30:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674725406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WvKG0+EHqX2qc0Od8ySBWV71U5CprDHTKgFEt6O+5XM=; b=ICMt2Dwr2PTuZ3e1y2kok4GjX722FQdAsqD6yG99j6pB5yHJ5rAPchVcPS4B3jYNLFwudu YugbOV/8aAe7o8HqDCVXgKx1twqf37kM2mrDjHxk7619MVlDREXZ9CaNh1xGp5ZOtchWeC K1peWLUS3iF1iqO6csZUljIfZQ4ctys= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-389-zxvFCO4cNjKf1Da6waFfHw-1; Thu, 26 Jan 2023 04:30:05 -0500 X-MC-Unique: zxvFCO4cNjKf1Da6waFfHw-1 Received: by mail-pf1-f199.google.com with SMTP id p51-20020a056a0026f300b0058df209da03so690149pfw.15 for ; Thu, 26 Jan 2023 01:30:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WvKG0+EHqX2qc0Od8ySBWV71U5CprDHTKgFEt6O+5XM=; b=obqX6qsRAlsLkxtQH1pqr2fCUPbULmcowOJMLN8fB/cqXfZMKPqs3ybyyCEYnYyH5j yD1GzlmMopyUUlzgChlzAwGcdhNZQQ0ewrqignCw6mBRe1B62hR2YUHC5Nm3nQFebOX7 8kqioh5LjlmgKM0J7s+uwrBpsO+Y3LYf5+RSvtuvQ1Djlbl9ihZP5o7TNBpJbOWhEPdn 7qUzM2c+TXnohUKcobgy2FM3J94bDAGBpMIEzbxJg/cjDudE83XEGPgPwlriqmjEyEVc NeEfwkakxmFOW324Bt4pzqQ8mDKRsPo44FqTI9QuXT+tKl/8/4eTKgr62U3YhIBZANZw FBwQ== X-Gm-Message-State: AFqh2kphekQ6TgIjGWQiy4wjPwUzpA+bgIOfj3CSFcE4kFxruTvSrcjt bnYuu8Ojgm+dcwKodCeuqw3jz6XO2bwK4ZWSqVVsUkOaiv9WH8KjNh0pRUMavNZYSn9hFIbpEI5 f30TLVd5XUZeWofxC1MQ= X-Received: by 2002:aa7:8a0b:0:b0:58d:bffa:db35 with SMTP id m11-20020aa78a0b000000b0058dbffadb35mr4439269pfa.34.1674725404558; Thu, 26 Jan 2023 01:30:04 -0800 (PST) X-Google-Smtp-Source: AMrXdXv8hBkBg6gl6RUCmf9on4V7pYmh66S8oelrwcxb3gs+lhfO61ar6wMzozceA2x9CpgOSB3jL5mvLFEhmjJCLGk= X-Received: by 2002:aa7:8a0b:0:b0:58d:bffa:db35 with SMTP id m11-20020aa78a0b000000b0058dbffadb35mr4439256pfa.34.1674725404195; Thu, 26 Jan 2023 01:30:04 -0800 (PST) MIME-Version: 1.0 References: <20221006081729.578475-1-harry.van.haaren@intel.com> <20221006125247.1018265-1-harry.van.haaren@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D873A1@smartserver.smartshare.dk> In-Reply-To: From: David Marchand Date: Thu, 26 Jan 2023 10:29:52 +0100 Message-ID: Subject: Re: [PATCH v3] test/service: fix spurious failures by extending timeout To: Harry van Haaren Cc: dev@dpdk.org, dpdklab@iol.unh.edu, ci@dpdk.org, Honnappa.Nagarahalli@arm.com, mattias.ronnblom@ericsson.com, thomas@monjalon.net, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Tyler Retzlaff , Aaron Conole X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Harry, On Thu, Oct 6, 2022 at 9:33 PM David Marchand w= rote: > > On Thu, Oct 6, 2022 at 3:27 PM Morten Br=C3=B8rup wrote: > > > This commit extends the timeout for service_may_be_active() > > > from 100ms to 1000ms. Local testing on a idle and loaded system > > > (compiling DPDK with all cores) always completes after 1 ms. > > > > > > The wait time for a service-lcore to finish is also extended > > > from 100ms to 1000ms. > > > > > > The same timeout waiting code was duplicated in two tests, and > > > is now refactored to a standalone function avoiding duplication. > > > > > > Reported-by: David Marchand > > > Suggested-by: Mattias Ronnblom > > > Signed-off-by: Harry van Haaren > > Acked-by: Morten Br=C3=B8rup > Reviewed-by: Mattias R=C3=B6nnblom > > Ok, let's see if the situation gets better with this. > Applied, thanks. I took a look at the january month failures at UNH. Downloads/dpdk_31608e4db568_2023-01-03_06-58-00_NA/out/testlog.txt:EAL: Test assert service_lcore_attr_get line 422 failed: Service lcore not stopped after waiting. Extending the timeout just made it less likely. On a similar note, other parts are failing every once in a while: Downloads/dpdk_2a211079a92e_25064_2023-01-24_15-08-50_NA/out/testlog.txt:EA= L: Test assert service_attr_get line 319 failed: attr_get() failed to get cycles (expected > zero) Downloads/dpdk_2a211079a92e_25074_2023-01-25_05-40-46_NA/out/testlog.txt:EA= L: Test assert service_lcore_start_stop line 900 failed: Service core expected to poll service but it didn't Downloads/dpdk_2a211079a92e_25075_2023-01-25_09-15-58_NA/out/testlog.txt:EA= L: Test assert service_lcore_start_stop line 900 failed: Service core expected to poll service but it didn't Downloads/dpdk_373f4c7de8ff_24866_2023-01-03_22-56-01_NA/out/testlog.txt:EA= L: Test assert service_lcore_start_stop line 900 failed: Service core expected to poll service but it didn't Downloads/dpdk_83397b9f0739_25030_2023-01-18_18-30-19_NA/out/testlog.txt:EA= L: Test assert service_lcore_start_stop line 901 failed: Service core expected to poll service but it didn't The timeout approach just does not have its place in a functional test. Either this test is rewritten, or it must go to the performance tests list so that we stop getting false positives. Can you work on this? Thanks. --=20 David Marchand