From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED3BF43A3C; Thu, 1 Feb 2024 16:19:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B940342DE1; Thu, 1 Feb 2024 16:19:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5A7A8402E4 for ; Thu, 1 Feb 2024 16:19:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706800763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AsjqgAiIACCv/VayngN5clE5M1xuJYbAT53QL78a0Xo=; b=XlhhwzWTqflcRudhdoRRe3Wr5dR6qFF+g1kPNruTKjxdYfxqkLOiU919J84u3LrAQ48cUp iqYMTY6TGQWfjdUk5d0UWx8zZnBgNSIliAClbGMLjPu+ntIqdFzBFU7toJsLT4JL0bFCYR cN88wW2BkiBg3DTsi1palYBfn01N8Pc= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-VkXUi1ycOtqv4Qc4B-d_uA-1; Thu, 01 Feb 2024 10:19:22 -0500 X-MC-Unique: VkXUi1ycOtqv4Qc4B-d_uA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5101e12059aso925992e87.0 for ; Thu, 01 Feb 2024 07:19:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706800761; x=1707405561; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AsjqgAiIACCv/VayngN5clE5M1xuJYbAT53QL78a0Xo=; b=ihhPDQCKY8fGYEplX7CCnVqNnK7TjHfH+VxZSWAbxIXAgGjbOChCZLR9xw1zQ+xI4J FLMDW+DUfUnBK+SywoDvSGT4RDvBJGqB/D6/o7WkZyMX9Qtz5Pk1eSvokXNwB3XbJ1Pp sygk6lmmvtjlGPgbAqTizIxhituYPmjyhutNRQW0a4DutWawVu6jJ0XGiYxep3UOk6o/ oZHkDEt8hFjlQwlN/+uDH6lCVgf9wytKbpRKfLUIQNRvdgM6ZJuhy3e0e3Z5KKMxfyTi Yf+m5lUng12SxdnKNfUxhbz4ImM1XyTfNh5K2UPr3AZiqNmLerdfGxXcHnRMlgmhac/P BYaw== X-Gm-Message-State: AOJu0YxYeV/VT0nqOjU4BDEMqLngzPD1ahxICd83BiLZwO0IT7ByS8Xu ZJMCHwwJWtpD5QrSi3QlmkdoW3ej0NZLywvvD9aOAScjRk/NJ9/Hgc8gqCdl9RZ3MA3ovd6g5vG r8c5DpEYfmj3Og3i8uUr/Ytro6Hu4ABEv5HqFbVXy6GljK9MiDhKEPBKi/dmr+Kz4Mbc+w3aHou Sbvu7Td0+33kfuu8U= X-Received: by 2002:a05:6512:3b82:b0:511:2fbe:86ed with SMTP id g2-20020a0565123b8200b005112fbe86edmr1620774lfv.28.1706800760865; Thu, 01 Feb 2024 07:19:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFFsgvziQBZUIeMILy5Hby9MbFkVh/+gVLvr1bGNb3OYU5w5GAGlQtnm3xk3JfYUG20pQsPUxFEbp9cRswzK6o= X-Received: by 2002:a05:6512:3b82:b0:511:2fbe:86ed with SMTP id g2-20020a0565123b8200b005112fbe86edmr1620757lfv.28.1706800760561; Thu, 01 Feb 2024 07:19:20 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Thu, 1 Feb 2024 16:19:08 +0100 Message-ID: Subject: Re: [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail To: Shaowei Sun <1819846787@qq.com> Cc: dev@dpdk.org, ciara.power@intel.com, Bruce Richardson , Chengwen Feng X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 30, 2024 at 2:57=E2=80=AFAM Shaowei Sun <1819846787@qq.com> wro= te: > > Telemetry can only create 10 conns by default, each of which is processed > by a thread. > > When a thread fails to write using socket, the thread will end directly > without reducing the total number of conns. > > This will result in the machine running for a long time, and if there are > 10 failures, the telemetry will be unavailable > Fixes: 2a7d0b872f79 ("telemetry: add upper limit on connections") Cc: stable@dpdk.org > > Signed-off-by: Shaowei Sun <1819846787@qq.com> > Acked-by: Bruce Richardson > Acked-by: Ciara Power > Acked-by: Chengwen Feng Applied, thanks for the fix! --=20 David Marchand