From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25664A057B; Wed, 1 Apr 2020 16:12:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A237F2C15; Wed, 1 Apr 2020 16:12:24 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 54F12FFA for <dev@dpdk.org>; Wed, 1 Apr 2020 16:12:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585750342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jw3aBCDYCIoPpoVkvu/ky2BfxOl6YGfW8YmNkfnDq7U=; b=K6Lv5Hkiv0fHuRU4b6NVZhNkSfsI/sWkyqK0D9F3ZPAnewsD73s2lfy/HHM9dlNmqtVl3p WGq57rRXwr/xGeDlT1yY02NI4XMJAfxEgqWcXjo4jcWEh45qed9mJLNlVpiGQ4gGCwfS6G rsJL/qChEb0pGLkvFoj4ptFsEs0eifQ= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-E5gfKnrJNYq6_hkgzTE75w-1; Wed, 01 Apr 2020 10:12:20 -0400 X-MC-Unique: E5gfKnrJNYq6_hkgzTE75w-1 Received: by mail-vs1-f70.google.com with SMTP id u203so6159692vsu.1 for <dev@dpdk.org>; Wed, 01 Apr 2020 07:12:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=80f3BSYU2jMKImOOoLRCTWdt813s+WlykJoz+CWET60=; b=SV8HFKQO/GhMActIZSRqc3z/CRlmdCjgwBkSCdU8/DPirlKq5F1wasUB9+T7PDwHsg SeEhUdzFrAlapBpPseU0PSBFHWDN4VIr1hUvJ2XR/GK1pmdYVvLZrf25hX/T/9XSchNO 3gcN+uABdSulYD8UMlHbrmYEn6Ma+XO8y2e2b1XZqyrfC/j4jhcAjuNe4S0CdBE32i38 8sil0/aXkGf6cw6cyQdZJo3FD4bnq9hfLjtCExfmpvQ3wZXVuQNmvJCIIAm/nj7YvU7d zzaWyYg5cWdOI1oSK5qQMFzipBMUDBzaXsaodQcQCzD9cxjjBzc55igoQ3OI6WXtVUvZ Ddyw== X-Gm-Message-State: AGi0PuaVJEPA9Tbw8WopeySosYeup3jA0XGeTo+UzjZELgAikv1U4/1/ Cnm300a+qjAik1L5oHk78UdUJOc+k8TV09gKudFlaX5FgZFaBE68fplz7SUhVRBDd6YRzLu3od2 S1cUh2MukN8kZv+4awt8= X-Received: by 2002:a67:26c2:: with SMTP id m185mr16952872vsm.180.1585750340272; Wed, 01 Apr 2020 07:12:20 -0700 (PDT) X-Google-Smtp-Source: APiQypKTATt6A5LKlY6d00WGbx82YbuD9OBdRE79680nKPgVo/l8+kgjkiajhiW3JHo2tD9dLJj+IcBDCL21nvCi4yw= X-Received: by 2002:a67:26c2:: with SMTP id m185mr16952841vsm.180.1585750339892; Wed, 01 Apr 2020 07:12:19 -0700 (PDT) MIME-Version: 1.0 References: <20200325211603.240288-1-jerinj@marvell.com> <20200329144342.1543749-1-jerinj@marvell.com> <CAJFAV8zJrXvrR0epT-rbHRT0Cd319fLQcxT9AmEiUKGm4tX0Pw@mail.gmail.com> <CALBAE1PiDhXeQE0xbwm_fkZp-t1n=G8T5ZkRXu9hF8qoS5N-oA@mail.gmail.com> In-Reply-To: <CALBAE1PiDhXeQE0xbwm_fkZp-t1n=G8T5ZkRXu9hF8qoS5N-oA@mail.gmail.com> From: David Marchand <david.marchand@redhat.com> Date: Wed, 1 Apr 2020 16:12:08 +0200 Message-ID: <CAJFAV8woQYDOUJ7XPb+Px-17d+gjJrYSeiHMhYn4qoum7y5KJA@mail.gmail.com> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Thomas Monjalon <thomas@monjalon.net> Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>, =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>, Sunil Kumar Kori <skori@marvell.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Declan Doherty <declan.doherty@intel.com>, Olivier Matz <olivier.matz@6wind.com>, Neil Horman <nhorman@tuxdriver.com>, Ray Kinsella <mdr@ashroe.eu> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > On Wed, Apr 1, 2020 at 1:49 PM David Marchand <david.marchand@redhat.com>= wrote: > > - Regardless of the trace framework, the ALLOW_EXPERIMENTAL_API flag > > gates access to APIs so that external users are aware of their status. > > I have been considering setting this flag unconditionally for internal > > users in the top Makefile/meson for app/ lib/ and drivers/. > > I could look at this and prepare a patch about this, but this is not > > enough here. > > It makes sense to me. Let me know when you are planning to send that patc= h, > I will rebase this series on top of that. Feel free to take over, thanks. > > If you don't have time then I can send the patch too. > I assume the patch content will be: > 1) Removing experimental API from app, lib, drivers, examples with > make and meson > 2) Have it enabled at the global level. examples are a special case as they can be compiled out of the dpdk sources= . This is why I excluded them of the list in my mail before. > > How about: > > * we introduce a global config switch that enables/disables the trace > > framework (off by default): the people who want to test it and help > > stabilize it will have to deal with the experimental flag for now, > > * in 20.11, the trace points are put into the stable ABI, and the > > option is removed, > > IMO, the better alternative would be: > > Since the trace changes in the "inline" functions of the specific > library already > disabled under _compile time_ RTE_ENABLE_TRACE_DP flag and > it is using RTE_TRACE_POINT_DP() to define the trace unlike slow path > trace like RTE_TRACE_POINT(). Ah indeed. Note: RTE_ENABLE_TRACE_DP is not plugged with meson. > So I can improve RTE_TRACE_POINT_DP() to make absolute NOP if > ALLOW_EXPERIMENTAL_API not defined. > > On the upside, > The tracing code will be enabled by default(runtime it is disabled by > default anyway). > If some need to fastpath API tracing then ALLOW_EXPERIMENTAL_API need > to enable. > So this won't break applications. So either keep the RTE_ENABLE_TRACE_DP flag or use ALLOW_EXPERIMENTAL_API... no opinion. Thomas? > > - With the patchset rebased on the current master (could be my fault, > > so take it with a grain of salt), the ALLOW_EXPERIMENTAL_API flag is > > not passed when compiling the l3fwd example against an installed dpdk. > > I will check. We have added ALLOW_EXPERIMENTAL_API flag where we got > compilation issues. No compilation issue, just big fat warnings reporting that l3fwd did not enable ALLOW_EXPERIMENTAL_API and it is not built with -Werror. I caught it with ./devtools/test-*build*.sh scripts. --=20 David Marchand