From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B18B9A04AF; Mon, 4 May 2020 16:09:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 57B291D160; Mon, 4 May 2020 16:09:21 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 23D571D15E for ; Mon, 4 May 2020 16:09:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588601359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kzrh2i0/273PB77pPrfApr2fpt3SmfISBmk6SYzb2xY=; b=Txo+Q22E3QKtZcqH+MNc5Ng+iuLxu8wUDHnre+++/CbDej1mMG99UWCFxDF8sA7ReVa69v gxTIHXI7ReA6CKvxn3UlIfKxGiQg7KQ5tYa/zhBHHoXfckBqosAaJrrVAmBqKr8/nUoZCK F24/XQzdMKP2KY3ajixA2klh62gB+lo= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-54vRCcubMQuOCjAwTc2tRQ-1; Mon, 04 May 2020 10:09:18 -0400 X-MC-Unique: 54vRCcubMQuOCjAwTc2tRQ-1 Received: by mail-vk1-f199.google.com with SMTP id l188so8990278vke.23 for ; Mon, 04 May 2020 07:09:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nIv0v+l4sn4CaVrusCx8da0Aul3vyg02hJBJKajRTVg=; b=fHXEi1bvKw+e6j4CLSnIX/dYRCaf2lN9sYy4vvf3ShGCv2hwetOfhSiNk4MCmGhnr7 AAyID5DhjABzxY76u6f1TRabm8QyrI05XezQJrnjIe4S1mG32ti//rhBtTiinxSNcipo G6syQp1MLZb7KYlNGZUrEKdTQ8JeCcLeKWw3AfqzgEQnPZbZe24Ehz5Asm4UZLKroyUB E3RpYwVTaNYwFwlKmcC03toZVb832kH7HkIqqAm7e9Zn+tzbnOBlFjz5mMh9HMQB7fIg 01s2sNJY0gtCx9TPC1vWKl5GCfT/jcAbnsKuSbBZmV1a0t/cvbWknjqQbx/SaiPoN05G b4Uw== X-Gm-Message-State: AGi0Pua52+iZo83U3nUuk6RHQcpigSvTrMvAFwMzR0JVot/ucvX3GT6Z djxX1DZ+QJyXqT8h84Sj7tGgT85SAs6zKNcvYAcc9yvZYYt/7INS+702YnHYBh41tJOqW19ImpP fgNT3ynQLzLAsOiufaTs= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr12233655uaj.41.1588601356348; Mon, 04 May 2020 07:09:16 -0700 (PDT) X-Google-Smtp-Source: APiQypJ71RQlJY9ncPCzMWGDen4xCgTxz0jRkiUJlGWDPGm2iXSpwtrheR1Hek7HiqNNAFagcpuazv7AhXs6RGxRKe8= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr12233603uaj.41.1588601355825; Mon, 04 May 2020 07:09:15 -0700 (PDT) MIME-Version: 1.0 References: <20200503203135.6493-1-david.marchand@redhat.com> <20200503203135.6493-5-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 4 May 2020 16:09:04 +0200 Message-ID: To: Sunil Kumar Kori Cc: "dev@dpdk.org" , "thomas@monjalon.net" , Jerin Jacob Kollanukkaran X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] [PATCH 4/8] trace: avoid confusion on optarg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 4, 2020 at 9:55 AM Sunil Kumar Kori wrote: > > Overall, it looks okay but I think "args" will be more relevant as each A= PI says XXX_args_save(). > What do you say ? No opinion, the function name itself indicates we are dealing with argument= s. I can go with args if you like. --=20 David Marchand