From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A94E7431A8; Thu, 19 Oct 2023 11:49:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9093D40279; Thu, 19 Oct 2023 11:49:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B41F74021F for ; Thu, 19 Oct 2023 11:49:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697708957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qI2pNcO75XZBRQnp2EKCru9Rp7Yy5h+ZuEhWbcCiins=; b=LS4nQzQiBVh2CQ/rtw0KwU3wJTSR+VJzL0wUZFPpR1r0SJZuDW53+Op7zASanIwIQmXnen mrSe5C2zsJPTWNJ8qdHu6YOBuAN93hf6VNJs4lUwVHTRNpFNBHn1gDIUUoAv5P17WRkN2D RPFJkJzP5rUB3+IxfNEIewN04C6ARew= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-365-msdeE58mNkq48YenTp3JYw-1; Thu, 19 Oct 2023 05:49:13 -0400 X-MC-Unique: msdeE58mNkq48YenTp3JYw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c50ef18b04so53990971fa.1 for ; Thu, 19 Oct 2023 02:49:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697708952; x=1698313752; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qI2pNcO75XZBRQnp2EKCru9Rp7Yy5h+ZuEhWbcCiins=; b=mvES/EZZwhOOqSPa2yx71cYmiy5r6inMrj6+xDsr/N+9MNk3TloFyEBeyTTJAJucUs y9r5P3dYmOmXC5Bh/SawnLCIJHxdM+jY5ShF2hjFmhjtD+sTL6qts++Mcj3bPtqJqCLR cqCQZyVqnCac/25kgi7/fBYDwtWkJb1QgbXcJ/XOfGlECrO1fUlo/2DBO/qIRXEofeQ8 6awd1yY+NRTx0q5Y4TLTVqesIyn+XFk+vGuCy73RlIZmVxWKpblLL8gRV1AhwcZpOL6+ YMT5qrkiVtvzmDl1FgI67KjW1FZirZpj4BWtSMGLLJq8/UnpLQUNESUVxkLV4Ky2DVz4 WtiQ== X-Gm-Message-State: AOJu0YyloNJbsmK8C8zS3SkVEmGXeX+7K8PkTZa6HbR+QtLqNplsl1HH a8tJ62dB9HN3yjl8/HwtemwhrmWqeheACbFkH4yjC/a40pKM43qwVyX1DKBuZ45AdKY0uXKbKMg a1ypeOknPzNu4ZGLRv9Y= X-Received: by 2002:a05:651c:14d:b0:2bc:db70:b563 with SMTP id c13-20020a05651c014d00b002bcdb70b563mr990694ljd.32.1697708952164; Thu, 19 Oct 2023 02:49:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3TjiSR+Smyt5n9iYbR0G29NXNBxXQ+QGSFkWO/Ip+d2OlM5+8ojI7qfQlUrkYT9v49c3ooDt+VUHDACtvhzQ= X-Received: by 2002:a05:651c:14d:b0:2bc:db70:b563 with SMTP id c13-20020a05651c014d00b002bcdb70b563mr990680ljd.32.1697708951795; Thu, 19 Oct 2023 02:49:11 -0700 (PDT) MIME-Version: 1.0 References: <20230925163610.3307750-1-maxime.coquelin@redhat.com> In-Reply-To: <20230925163610.3307750-1-maxime.coquelin@redhat.com> From: David Marchand Date: Thu, 19 Oct 2023 11:49:00 +0200 Message-ID: Subject: Re: [PATCH 0/7] vhost: ensure vitqueue access status is checked To: Maxime Coquelin Cc: dev@dpdk.org, mb@smartsharesystems.com, chenbo.xia@outlook.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Maxime, On Mon, Sep 25, 2023 at 6:36=E2=80=AFPM Maxime Coquelin wrote: > > Li Feng initially reported segmentation fault in rte_vhost_vring_call() > because of not checking the virtqueue metadata can be accessed. > > This should be achieved by checking the access_ok status field of > the virtqueue. > > This series also takes the opportunity to fix the other APIs. > This is split in multiple patches to ease LTS maintainers backports, > but could be squashed if preferred. > > Maxime Coquelin (7): > vhost: fix missing vring call check on virtqueue access > vhost: fix missing check on virtqueue access > vhost: fix checking virtqueue access when notifying guest > vhost: fix check on virtqueue access in async registration > vhost: Fix check on virtqueue access in in-flight getter Nit: fix* > vhost: fix missing lock protection in power monitor API > vhost: fix checking virtqueue access ins stats API This series needs some rebasing, and I had a small comment on a first patch Fixes: tag, but otherwise it lgtm. --=20 David Marchand