From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com [209.85.221.169]) by dpdk.org (Postfix) with ESMTP id 3B4145F1B for ; Thu, 11 Apr 2019 09:45:54 +0200 (CEST) Received: by mail-vk1-f169.google.com with SMTP id x194so1174370vke.0 for ; Thu, 11 Apr 2019 00:45:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lNGJuAc5z62/RmkG8g7VaMJbGSZzrv0eOYdMDCwJdSk=; b=r6ZoC5E2uBbE/T9wN59SJqiiniNdwoz8SKZ2wFt3XwZRoJD9CHorqZtNUStguPR2ky axOOeyHqGygEZH7tc2dA2iU3dkYZwMuOaN7hOSR0UpTHQVcEH3tfQ163rHjVN4GpBgS7 ask0iRVo3q8IPR2F2YO2gDpApmn32Q94EweyT7i4jBpQpLBfOfbMoPFTUDY/72+XN1+U tVl2W+TKfr+HtNN2aZOtLKY6W1mHBhqRagojutbJQj70aan/KorSkRm/IKtYmltnkhFU 8/AJ5Di3WIAkWLbnR3oyYKUG2h+7Taf5drcWgiCQHJXHQEm6Wu5rjj651nahIaRup8PM 1GZw== X-Gm-Message-State: APjAAAXZ9s3ol8Lp9bmklUW28rH78vkcUTlQUKs20xGtfLC9TkBiAVjx 56bJar8jd7rXZD6eF6wNLCpqOejiTAOUZ5tRGzTMog88mOw= X-Google-Smtp-Source: APXvYqztETQtoVLtKNYAexapez2Gxb0FFMaYcKAnLPcINO24mGxd0f8mJMBLSKYjlIGPLuFjuPJOEekm9A3j9cQFGb8= X-Received: by 2002:a1f:bf4b:: with SMTP id p72mr26628662vkf.77.1554968753467; Thu, 11 Apr 2019 00:45:53 -0700 (PDT) MIME-Version: 1.0 References: <20190409190630.31975-1-vivkong@ca.ibm.com> In-Reply-To: <20190409190630.31975-1-vivkong@ca.ibm.com> From: David Marchand Date: Thu, 11 Apr 2019 09:45:42 +0200 Message-ID: To: vivkong@ca.ibm.com Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2019 07:45:54 -0000 Hello, On Tue, Apr 9, 2019 at 9:06 PM Vivian Kong wrote: > To build and run DPDK on Linux on IBM Z (s390x), big endian support > is added and s390x vector intrinics are used in the implementation > intrinsics* of DPDK libraries. > > I appreciate your feedback. > Quick check since this is not 19.05 material. - New files should be Copyright 2019. - Avoid copy/paste from Power, noticed a reference to Power in the config file. - Configuration files are stacked, only enable/disable the needed parts in the specific s390 file - Meson must be added. - No need to add dead code, remove the commented code like: //#define dsb(opt) asm volatile("" : : : "memory") - Comments using // are banned. - No need to introduce a RTE_ACL_CLASSIFY_S390X to map to the scalar code. Just avoid the SSE code to be selected in the build framework (iiuc). - Avoid introducing empty lines Run check scripts from devtools before submitting: [dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh ### mk: introduce s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 61 lines checked ### eal: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 601 lines checked ### acl: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 208 lines checked ### lpm: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 203 lines checked ### examples/l3fwd: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 410 lines checked ### net/i40e: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 0 checks, 647 lines checked ### test: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 192 lines checked ### hash: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 16 lines checked ### doc: introduce s390x architecture WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 2 warnings, 24 lines checked ### ethdev: add cast for bus_device WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 2 warnings, 8 lines checked ### mbuf: trivial fix WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 2 warnings, 8 lines checked ### test: miscellaneous test fixes WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 32 lines checked 0/12 valid patch -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D5486A0096 for ; Thu, 11 Apr 2019 09:45:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F231F5F1F; Thu, 11 Apr 2019 09:45:55 +0200 (CEST) Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com [209.85.221.169]) by dpdk.org (Postfix) with ESMTP id 3B4145F1B for ; Thu, 11 Apr 2019 09:45:54 +0200 (CEST) Received: by mail-vk1-f169.google.com with SMTP id x194so1174370vke.0 for ; Thu, 11 Apr 2019 00:45:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lNGJuAc5z62/RmkG8g7VaMJbGSZzrv0eOYdMDCwJdSk=; b=r6ZoC5E2uBbE/T9wN59SJqiiniNdwoz8SKZ2wFt3XwZRoJD9CHorqZtNUStguPR2ky axOOeyHqGygEZH7tc2dA2iU3dkYZwMuOaN7hOSR0UpTHQVcEH3tfQ163rHjVN4GpBgS7 ask0iRVo3q8IPR2F2YO2gDpApmn32Q94EweyT7i4jBpQpLBfOfbMoPFTUDY/72+XN1+U tVl2W+TKfr+HtNN2aZOtLKY6W1mHBhqRagojutbJQj70aan/KorSkRm/IKtYmltnkhFU 8/AJ5Di3WIAkWLbnR3oyYKUG2h+7Taf5drcWgiCQHJXHQEm6Wu5rjj651nahIaRup8PM 1GZw== X-Gm-Message-State: APjAAAXZ9s3ol8Lp9bmklUW28rH78vkcUTlQUKs20xGtfLC9TkBiAVjx 56bJar8jd7rXZD6eF6wNLCpqOejiTAOUZ5tRGzTMog88mOw= X-Google-Smtp-Source: APXvYqztETQtoVLtKNYAexapez2Gxb0FFMaYcKAnLPcINO24mGxd0f8mJMBLSKYjlIGPLuFjuPJOEekm9A3j9cQFGb8= X-Received: by 2002:a1f:bf4b:: with SMTP id p72mr26628662vkf.77.1554968753467; Thu, 11 Apr 2019 00:45:53 -0700 (PDT) MIME-Version: 1.0 References: <20190409190630.31975-1-vivkong@ca.ibm.com> In-Reply-To: <20190409190630.31975-1-vivkong@ca.ibm.com> From: David Marchand Date: Thu, 11 Apr 2019 09:45:42 +0200 Message-ID: To: vivkong@ca.ibm.com Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190411074542.5pP056lblnK-6KbNjgY2j94fKzvkmY5VTzGa9hwyVVk@z> Hello, On Tue, Apr 9, 2019 at 9:06 PM Vivian Kong wrote: > To build and run DPDK on Linux on IBM Z (s390x), big endian support > is added and s390x vector intrinics are used in the implementation > intrinsics* of DPDK libraries. > > I appreciate your feedback. > Quick check since this is not 19.05 material. - New files should be Copyright 2019. - Avoid copy/paste from Power, noticed a reference to Power in the config file. - Configuration files are stacked, only enable/disable the needed parts in the specific s390 file - Meson must be added. - No need to add dead code, remove the commented code like: //#define dsb(opt) asm volatile("" : : : "memory") - Comments using // are banned. - No need to introduce a RTE_ACL_CLASSIFY_S390X to map to the scalar code. Just avoid the SSE code to be selected in the build framework (iiuc). - Avoid introducing empty lines Run check scripts from devtools before submitting: [dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh ### mk: introduce s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 61 lines checked ### eal: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 601 lines checked ### acl: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 208 lines checked ### lpm: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 203 lines checked ### examples/l3fwd: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 410 lines checked ### net/i40e: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 0 checks, 647 lines checked ### test: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 192 lines checked ### hash: add support for s390x architecture WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 16 lines checked ### doc: introduce s390x architecture WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 2 warnings, 24 lines checked ### ethdev: add cast for bus_device WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 2 warnings, 8 lines checked ### mbuf: trivial fix WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 2 warnings, 8 lines checked ### test: miscellaneous test fixes WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Vivian Kong ' total: 0 errors, 1 warnings, 32 lines checked 0/12 valid patch -- David Marchand