From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1B194269E; Mon, 2 Oct 2023 10:15:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95FF140284; Mon, 2 Oct 2023 10:15:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A08784003C for ; Mon, 2 Oct 2023 10:15:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696234540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e8Ab8DYTpiI8BaSgYQQUJSzKgy4RUjnRNoQO23BRLZQ=; b=cVj3rMKRQV61qRZwrH5+oHAbUOyDdntUceMp8tZnE4wwhmLeDAC839uoG74C7LsijpO1ET hiujM/SgkfCJ28r7IGgVt+QPmiRGwiDrs0BFoQm+nXxeY1zT9EyOHwuJ5v+1FS22ezYDgS jvM0YPVECYrEdYiTvo3u28+l4VZBr6Y= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-wyotOecQPhKBOwe7XM1bcw-1; Mon, 02 Oct 2023 04:15:38 -0400 X-MC-Unique: wyotOecQPhKBOwe7XM1bcw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c135cf124cso203479761fa.2 for ; Mon, 02 Oct 2023 01:15:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696234537; x=1696839337; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e8Ab8DYTpiI8BaSgYQQUJSzKgy4RUjnRNoQO23BRLZQ=; b=cj88tQx0ai0m3LJNnrSV024t2J1cOUay4fNCXwHFJ0tE3gTK4dxwLKQEwExznzilbX QzQeG2Rh3zB0Rd6oG4cz8LRtyyGoxPGgTzcpfoa1Y6CNB0blFy+PEzyHTPc13xorDEpn KEaicVeAWJa6xvNAaFmVqFdBXA1aoPDqeNCWaz/bHniHyk4iQnvLgDHwZkM6JmKQx7Ee usX/t741nNTUg3f2xSlK8pXJ8Vt744gdRwinM0C0qDPDHS8G3EWTlaFzsZRTDeigJhv4 JM2xQ9sapIeZcAzx8s2VtAVTO2lnOw9iGafwxUK8Hq3gN5WYzIZQeS3UdKHRuhCjuA5j cH+w== X-Gm-Message-State: AOJu0Yx7Bcvipe/IlKJTCBcPLZVacIbLyWVk5W18A+AAqtVBPNK9xGhM VbJIYwFFz2PRToPGJa5CeX+krUDv3fjlukWduVyqce2LQEflVXvws/nEK11hW12B0KEIJMySUzR O6I2uxCNp0YSKA21xma4= X-Received: by 2002:a2e:9584:0:b0:2c0:3284:64d5 with SMTP id w4-20020a2e9584000000b002c0328464d5mr9352673ljh.47.1696234537411; Mon, 02 Oct 2023 01:15:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjhtuM2MVUQ/X8x2tG//wPEwlR6bn/4yYmIRboBFLFZ3oihelgskLcKPAd5gvtRiIbV3Ly1Ocy58qmCk1zFFA= X-Received: by 2002:a2e:9584:0:b0:2c0:3284:64d5 with SMTP id w4-20020a2e9584000000b002c0328464d5mr9352659ljh.47.1696234537064; Mon, 02 Oct 2023 01:15:37 -0700 (PDT) MIME-Version: 1.0 References: <20230921042349.104150-1-stephen@networkplumber.org> <20230921042349.104150-5-stephen@networkplumber.org> In-Reply-To: <20230921042349.104150-5-stephen@networkplumber.org> From: David Marchand Date: Mon, 2 Oct 2023 10:15:25 +0200 Message-ID: Subject: Re: [PATCH 4/4] pcapng: move timestamp calculation into pdump To: Stephen Hemminger Cc: dev@dpdk.org, Reshma Pattan , Quentin Armitage X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Stephen, On Thu, Sep 21, 2023 at 6:24=E2=80=AFAM Stephen Hemminger wrote: > > The computation of timestamp is more easily done in pdump > than pcapng. The initialization is easier and makes the pcapng > library have no global state. > > It also makes it easier to add HW timestamp support later. > > Simplify the computation of nanoseconds from TSC to a two > step process which avoids numeric overflow issues. The previous > code was not thread safe as well. > Bugzilla ID: 1291 ? This patch (and patch 3) updates some pcapng API, is it worth a RN update? > Fixes: c882eb544842 ("pcapng: fix timestamp wrapping in output files") Is it worth backporting? I would say no, as some API update was needed to fix the issue. But on the other hand, this is an experimental API, so I prefer to ask. > Signed-off-by: Stephen Hemminger --=20 David Marchand