DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: Volodymyr Fialko <vfialko@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	 Stephen Hemminger <stephen@networkplumber.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	 Anoob Joseph <anoobj@marvell.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	 "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH v2] reorder: fix registration of dynamic field in mbuf
Date: Thu, 16 Mar 2023 16:36:00 +0100	[thread overview]
Message-ID: <CAJFAV8wpT-PL_7CFWNvvdfud4XKn7vsk55xzEwZJ+9D5CzHj5Q@mail.gmail.com> (raw)
In-Reply-To: <BYAPR11MB336667FB4C84E792F95CAF06FFBF9@BYAPR11MB3366.namprd11.prod.outlook.com>

On Wed, Mar 15, 2023 at 4:47 PM Pattan, Reshma <reshma.pattan@intel.com> wrote:
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > > A gentle reminder, please review and ack/comment.
> > > Can we have this merged before RC3?
> >
> > I did not go into depth this time, the fix seems ok.
> > Reshma, please review.
> Unfortunately do not have a bandwidth to review this. I am ok if someone who already reviewed ACKs this.

That's a pity.

I don't think there is a huge amount of work on this library.
I would have expected one review every other month or so is acceptable.

The fix looks correct to me, nobody objects, I'll take it as is.


-- 
David Marchand


  reply	other threads:[~2023-03-16 15:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13  9:34 [PATCH] " Volodymyr Fialko
2023-03-13 10:19 ` David Marchand
2023-03-13 13:08   ` [EXT] " Volodymyr Fialko
2023-03-13 13:04 ` [PATCH v2] " Volodymyr Fialko
2023-03-15 15:29   ` Volodymyr Fialko
2023-03-15 15:43     ` David Marchand
2023-03-15 15:46       ` Pattan, Reshma
2023-03-16 15:36         ` David Marchand [this message]
2023-03-16 15:55   ` David Marchand
2023-03-13 15:51 ` [PATCH] " Stephen Hemminger
2023-03-13 17:29   ` [EXT] " Volodymyr Fialko
2023-03-13 12:59 [PATCH v2] " Volodymyr Fialko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wpT-PL_7CFWNvvdfud4XKn7vsk55xzEwZJ+9D5CzHj5Q@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=vfialko@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).