From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, "Gagandeep Singh" <g.singh@nxp.com>,
"Hemant Agrawal" <hemant.agrawal@nxp.com>,
"Abdullah Sevincer" <abdullah.sevincer@intel.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Sachin Saxena" <sachin.saxena@nxp.com>,
"Apeksha Gupta" <apeksha.gupta@nxp.com>
Subject: Re: [PATCH 2/2] drivers: RTE_LOG_DP newline consistency
Date: Thu, 1 Feb 2024 09:51:10 +0100 [thread overview]
Message-ID: <CAJFAV8wpYQ7X9YH_YKcrB+T0yE7EdwuAT0D2JmpX+DFL6dqvcg@mail.gmail.com> (raw)
In-Reply-To: <20240124162917.59851-3-stephen@networkplumber.org>
On Wed, Jan 24, 2024 at 5:29 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Make sure use of RTE_LOG_DP has newline just like uses of RTE_LOG.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
I have one concern with this patch.
Changing those internal macros means that future backports calling
them will introduce issues in the LTS branches.
This was the reason I went though the trouble of renaming macros in
libraries in my previous series.
--
David Marchand
next prev parent reply other threads:[~2024-02-01 8:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 16:28 [PATCH 0/2] RTE_LOG_DP cleanups Stephen Hemminger
2024-01-24 16:28 ` [PATCH 1/2] drivers: remove unnecessary RTE_LOG_DP macros Stephen Hemminger
2024-01-24 18:07 ` Tyler Retzlaff
2024-02-01 9:33 ` David Marchand
2024-01-24 16:28 ` [PATCH 2/2] drivers: RTE_LOG_DP newline consistency Stephen Hemminger
2024-01-24 18:11 ` Tyler Retzlaff
2024-02-01 8:51 ` David Marchand [this message]
2024-02-02 17:40 ` [PATCH] drivers: Convert uses of RTE_LOG_DP to use RTE_LOG_DP_LINE Stephen Hemminger
2024-02-05 18:43 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wpYQ7X9YH_YKcrB+T0yE7EdwuAT0D2JmpX+DFL6dqvcg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=abdullah.sevincer@intel.com \
--cc=apeksha.gupta@nxp.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=sachin.saxena@nxp.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).