From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49D7C43A34; Thu, 1 Feb 2024 09:51:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B54640299; Thu, 1 Feb 2024 09:51:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 08DE440275 for ; Thu, 1 Feb 2024 09:51:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706777486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kSIDVE9+kP0fNST2RLA5xFM/k0zMgW+0VKz+/Qq8FQ8=; b=AZ3r+xFT7hXa/2HbKBPg3WGcOKhDFRNp4qZKfToSYJJZGcg4T80qJml+JCBhD0/VOK7uT3 k9AV9RuvmyEDauVMHcY8+DLPTR/ifHDm7CHvnv3Fu+Pl4G58CDmK3i3KRgp+NTw4E1Xgbg VzwLAZYh6x0zZ3A+dKIHHZATlz5yM18= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-rN_QmBgAOCm4_sN9NMndiA-1; Thu, 01 Feb 2024 03:51:25 -0500 X-MC-Unique: rN_QmBgAOCm4_sN9NMndiA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5101af0a385so482608e87.2 for ; Thu, 01 Feb 2024 00:51:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706777484; x=1707382284; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kSIDVE9+kP0fNST2RLA5xFM/k0zMgW+0VKz+/Qq8FQ8=; b=DAHt9rBQvPCqc+mvE8LN55TPHWwtk162elFa5UelqbGDp/ENiwLj4ZxzRecwPZg3Ay AWuzkKRLudaM2FBt4/y2aC1ACjrZs6nT2GjRQ7dnJTkKA/wye1LNvD2Z3ILPEF9XNK5W AB2sQWHryMhiuwIPni5BYal7PX9JEGleVCUA1DTi3n/g6mIcWYV9N62wcSUhZa/DePiW Ne6M+JwW/E6Nq8EqIuaPzMnHAzbB7ScOt0vRM6fEIqb/I1ljFhRXw2J+aE/1KyyxQin0 4cck7Zka5eP+X7U89eskhf6b+XDG7F1sNzrrozXcmbNB6T+tha1snEIKuk1fdOa6l/O0 lUAQ== X-Gm-Message-State: AOJu0YxPpUa1DTfI8tnXzvjxbRyyFOAKKQjU3VWr0ivcK9R/AJt/OBYW V252xMrSmVNz2Om0I/6kkX7sx59YYWpGdY7+t+nwOwzUVUezaUKFDgFve7ZoxDb/QvmOHi5U8qu kVb8l2lBEjeI+ss0eaC1VyN745S/cjvRtWCo1UZn51qFQ/LwNn9JpqEJ65yHWMI2GaQNMH+St2M 4+Rv2AFmoFJS+YEDE= X-Received: by 2002:ac2:5f08:0:b0:50e:6c1d:5dec with SMTP id 8-20020ac25f08000000b0050e6c1d5decmr952963lfq.23.1706777484181; Thu, 01 Feb 2024 00:51:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHqiXSo3dLma4ZnUxUKubE1rqtG6uYY12VH92BAJzVbGOeq7paeajXZioC1uiWQH09xcpQFCid5hctxD/LCtLc= X-Received: by 2002:ac2:5f08:0:b0:50e:6c1d:5dec with SMTP id 8-20020ac25f08000000b0050e6c1d5decmr952949lfq.23.1706777483878; Thu, 01 Feb 2024 00:51:23 -0800 (PST) MIME-Version: 1.0 References: <20240124162917.59851-1-stephen@networkplumber.org> <20240124162917.59851-3-stephen@networkplumber.org> In-Reply-To: <20240124162917.59851-3-stephen@networkplumber.org> From: David Marchand Date: Thu, 1 Feb 2024 09:51:10 +0100 Message-ID: Subject: Re: [PATCH 2/2] drivers: RTE_LOG_DP newline consistency To: Stephen Hemminger Cc: dev@dpdk.org, Gagandeep Singh , Hemant Agrawal , Abdullah Sevincer , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Sachin Saxena , Apeksha Gupta X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 24, 2024 at 5:29=E2=80=AFPM Stephen Hemminger wrote: > > Make sure use of RTE_LOG_DP has newline just like uses of RTE_LOG. > > Signed-off-by: Stephen Hemminger I have one concern with this patch. Changing those internal macros means that future backports calling them will introduce issues in the LTS branches. This was the reason I went though the trouble of renaming macros in libraries in my previous series. --=20 David Marchand