From: David Marchand <david.marchand@redhat.com>
To: Kaiwen Deng <kaiwenx.deng@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, qiming.yang@intel.com,
yidingx.zhou@intel.com, Qi Zhang <qi.z.zhang@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/ice: fix tso tunnel setting to not take effect
Date: Fri, 24 Nov 2023 09:02:08 +0100 [thread overview]
Message-ID: <CAJFAV8wq4Q2hkbesb-CwGQNZRubUm2Un7D7KeLv5f9zBm5FOxw@mail.gmail.com> (raw)
In-Reply-To: <20231124064441.1774807-1-kaiwenx.deng@intel.com>
On Fri, Nov 24, 2023 at 8:27 AM Kaiwen Deng <kaiwenx.deng@intel.com> wrote:
>
> The Tx offload capabilities of ICE ethdev doesn't include
> tso tunnel, which will result in tso tunnel setting to
> not take effect.
>
> This commit will add tso tunnel capabilities in ice_dev_info_get().
>
> Fixes: 295968d17407 ("ethdev: add namespace")
This Fixes: tag is wrong.
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 3ccba4db80..fbc957fcd8 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
> RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> - RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
> + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
> + RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
> + RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
> + RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
> + RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
> dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
> }
Is this tunnel + tso feature supported with vector drivers?
Is there some documentation to update to reflect this addition?
--
David Marchand
next prev parent reply other threads:[~2023-11-24 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 6:44 Kaiwen Deng
2023-11-24 7:50 ` lihuisong (C)
2023-11-24 8:02 ` David Marchand [this message]
2023-12-07 2:30 ` [PATCH v2] " Kaiwen Deng
2023-12-27 11:20 ` Zhang, Qi Z
2024-01-22 11:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wq4Q2hkbesb-CwGQNZRubUm2Un7D7KeLv5f9zBm5FOxw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kaiwenx.deng@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).