From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44EDA433B5; Fri, 24 Nov 2023 09:02:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1778E402E1; Fri, 24 Nov 2023 09:02:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A9D35402B3 for ; Fri, 24 Nov 2023 09:02:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700812943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AUPJYtMKohFwekvPrtmO+faTvZfSgWSXNvnms9b+0Nk=; b=Am5qbj/n633r/XLu2MufbH7Rwgc1GdTti95iLYYzOagiX4DF9M20QvhgpBNS9ZYlt5WU6+ CQDnhTLgmfQLyQ1FHZ/IownHBEK0bpM8EjB6TnGGjsZQyezlS/CPq1iE051SPnCBgHDoog bm/b5jGdLm6JJj+XKGwkQ080L6uCUaQ= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-CkkwelBRM8aXePhc_SwdQw-1; Fri, 24 Nov 2023 03:02:21 -0500 X-MC-Unique: CkkwelBRM8aXePhc_SwdQw-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-507cafb69e8so1376130e87.1 for ; Fri, 24 Nov 2023 00:02:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700812940; x=1701417740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AUPJYtMKohFwekvPrtmO+faTvZfSgWSXNvnms9b+0Nk=; b=jAZdoQKm85JHzbwo9483GlBfQDJJ/2OEUlIDMlNETMsicUgF+RBzvVYUSQ/8AhKd91 ZF3JFkXE/uWunUzZxunMcKekAEYRTOkOPNXKJh7j/T41oht3dZNmAYf2kGfv+SscfjRW pAun+0YN6IhtQQzSlqYh4HtEntnUptYzCxNg6WpMTEbeJaAXqPsIHO4t+3y6PFMciRRl T6GxCGqe6HBEDaXkP6ZQHHWzypB60iEAkvOqXzL82kIYBh5huy8WDwRiPmSP5EHOm8KA Mz4RVIMmmdgUd5Isz1icVHs5FSxYUtgEBZqvDFIo4ewKy/NgSMsn3mTsDLkDX0jM1nod aCpw== X-Gm-Message-State: AOJu0Yxajv008PyS9nIpr3GwaxHhVsppW5NPNay6Ni6ET+jYpFRoldcT vAFGET/a0WDishZxoHEXWPz9E4IP1MeQTDePHnrm4MqKVH6Up9Rzj+D8rOrSKBuFIT2MoXys3cN 4Ezmhsv7VyCY7kSegBiM= X-Received: by 2002:a2e:8387:0:b0:2c8:8745:8f0b with SMTP id x7-20020a2e8387000000b002c887458f0bmr1147445ljg.47.1700812940232; Fri, 24 Nov 2023 00:02:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGF/dI41zrO/eF03BaeYAiAo0sM+cT5tIYLu/TPj7uxvbGam456Y0IAbQgXwkJP6R9Dk5kTcuVcAonEuTjw1L8= X-Received: by 2002:a2e:8387:0:b0:2c8:8745:8f0b with SMTP id x7-20020a2e8387000000b002c887458f0bmr1147431ljg.47.1700812939785; Fri, 24 Nov 2023 00:02:19 -0800 (PST) MIME-Version: 1.0 References: <20231124064441.1774807-1-kaiwenx.deng@intel.com> In-Reply-To: <20231124064441.1774807-1-kaiwenx.deng@intel.com> From: David Marchand Date: Fri, 24 Nov 2023 09:02:08 +0100 Message-ID: Subject: Re: [PATCH] net/ice: fix tso tunnel setting to not take effect To: Kaiwen Deng Cc: dev@dpdk.org, stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Qi Zhang , Jerin Jacob , Tyler Retzlaff , Somnath Kotur , Ajit Khaparde , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 24, 2023 at 8:27=E2=80=AFAM Kaiwen Deng wrote: > > The Tx offload capabilities of ICE ethdev doesn't include > tso tunnel, which will result in tso tunnel setting to > not take effect. > > This commit will add tso tunnel capabilities in ice_dev_info_get(). > > Fixes: 295968d17407 ("ethdev: add namespace") This Fixes: tag is wrong. > Cc: stable@dpdk.org > > Signed-off-by: Kaiwen Deng > --- > drivers/net/ice/ice_ethdev.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 3ccba4db80..fbc957fcd8 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct r= te_eth_dev_info *dev_info) > RTE_ETH_TX_OFFLOAD_TCP_CKSUM | > RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | > RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | > - RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; > + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM | > + RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | > + RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | > + RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | > + RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; > dev_info->flow_type_rss_offloads |=3D ICE_RSS_OFFLOAD_ALL= ; > } Is this tunnel + tso feature supported with vector drivers? Is there some documentation to update to reflect this addition? --=20 David Marchand