From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C38643C58; Wed, 6 Mar 2024 10:45:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14A4340276; Wed, 6 Mar 2024 10:45:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2276040275 for ; Wed, 6 Mar 2024 10:45:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709718344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J2QukY0Wsixl9XsxT+4FKmJ7peCMehRxuCaTrdMvJlw=; b=UQEvwqs18qCJccj0bQTbQSUhXRNlrddSWOV4dThAQ9uwCcyRVNYS118TZ/e2V+JBHcOKyt uU7rqUWzeFWtxbLthE5llCoToX8BosMJuYrKKGck+Ujv78StiopKelgLbSFvvRPsrxT9O3 14acPyy2Uf7AtgPEMR8zXkw54Pbye8c= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-384-tmIAcVfxMnK4ruLb4Tqn4A-1; Wed, 06 Mar 2024 04:45:40 -0500 X-MC-Unique: tmIAcVfxMnK4ruLb4Tqn4A-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5131796a4b7so6500346e87.1 for ; Wed, 06 Mar 2024 01:45:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709718339; x=1710323139; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J2QukY0Wsixl9XsxT+4FKmJ7peCMehRxuCaTrdMvJlw=; b=NPSF1qdnWH9DJP5tKluD1NI0gL8a1puVOMo5tu7yWUz3UgmcTrhM5upevOkZvSy5er pYLRF5CXjVGW7zRZvXWdOyeOWBQuABTQhKXKBfnZYeZp7B/xmSHl043foUzstNbCrYLQ ytXfKab3YT8sNt8BBf+HseV84MgNVXBYbFPAwXy6BmcPjqK9hjBg03pmIghQROeDm7cN QOIX2oX49qUMvycAtSQHzVzYQkhNJpQNOJ+rUjYpV0vP26eLExUio8yFD3h5SKNw72qy +Ag9hmpjRMfTdUzkwiPFNd93QpdFqiuB74ELkrtOvQ8leITc5RUlgN6Et3MQ46pGgBqt FCuA== X-Forwarded-Encrypted: i=1; AJvYcCWWNUpws1CBdxbVSs0MPVnNY8vp5b4eteRwRhAFKcfD8yZddyiPVTvn5AZsXEfJ2uU5M19XavrTiaLCucU= X-Gm-Message-State: AOJu0YzPCTHE0utijhUegCQfH77T/L+9V82UbWjqHwQvh9AHoRXw8MRM BiUoiUfrahlvWrY6H18zUE9foDAI1HAOqjw1apISAro1HqcJagHgp04LhTt+V99t2gMBVOH047C bFWzDjBOsFHIV9Fxbp/vObyt3OPzENZo+rBROO3YIr2fyZMhJaQApNRDDI1jib3LpPZT59ZJnCp sz7CX1G/HDXiq8AU0= X-Received: by 2002:ac2:4c45:0:b0:512:ed82:fd6f with SMTP id o5-20020ac24c45000000b00512ed82fd6fmr3536134lfk.60.1709718338802; Wed, 06 Mar 2024 01:45:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFG6YfeLbIBGavKMlOH61PnHJPFhPwva+hz0rVEhMxH4frGxz4XLH33exsBB0R4+V6OO0inKw+wqwI7wj/O0k= X-Received: by 2002:ac2:4c45:0:b0:512:ed82:fd6f with SMTP id o5-20020ac24c45000000b00512ed82fd6fmr3536113lfk.60.1709718338461; Wed, 06 Mar 2024 01:45:38 -0800 (PST) MIME-Version: 1.0 References: <1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com> <1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com> <1709574764-9041-11-git-send-email-roretzla@linux.microsoft.com> <20240305174116.GB18937@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20240305174116.GB18937@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Wed, 6 Mar 2024 10:45:26 +0100 Message-ID: Subject: Re: [PATCH v7 10/39] eventdev: use C11 alignas To: Tyler Retzlaff Cc: Jerin Jacob , dev@dpdk.org, Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Cristian Dumitrescu , David Christensen , David Hunt , Ferruh Yigit , Honnappa Nagarahalli , Jasvinder Singh , Kevin Laatz , Konstantin Ananyev , Min Zhou , Ruifeng Wang , Sameh Gobriel , Stanislaw Kardach , Thomas Monjalon , Vladimir Medvedkin , Yipeng Wang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 5, 2024 at 6:41=E2=80=AFPM Tyler Retzlaff wrote: > > On Tue, Mar 05, 2024 at 04:47:05PM +0100, David Marchand wrote: > > On Mon, Mar 4, 2024 at 6:54=E2=80=AFPM Tyler Retzlaff > > wrote: > > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.= h > > > index 3af4686..08e5f93 100644 > > > --- a/lib/eventdev/rte_eventdev.h > > > +++ b/lib/eventdev/rte_eventdev.h > > > @@ -1338,7 +1338,7 @@ int rte_event_dev_stop_flush_callback_register(= uint8_t dev_id, > > > /** > > > * Event vector structure. > > > */ > > > -struct rte_event_vector { > > > +struct __rte_aligned(16) rte_event_vector { > > > uint16_t nb_elem; > > > /**< Number of elements valid in this event vector. */ > > > uint16_t elem_offset : 12; > > > @@ -1376,23 +1376,19 @@ struct rte_event_vector { > > > * value to share between dequeue and enqueue operation. > > > * The application should not modify this field. > > > */ > > > - union { > > > + union __rte_aligned(16) { > > > #endif > > > struct rte_mbuf *mbufs[0]; > > > void *ptrs[0]; > > > uint64_t u64s[0]; > > > #ifndef __cplusplus > > > - } __rte_aligned(16); > > > + }; > > > #endif > > > /**< Start of the vector array union. Depending upon the even= t type the > > > * vector array can be an array of mbufs or pointers or opaqu= e u64 > > > * values. > > > */ > > > -#ifndef __DOXYGEN__ > > > -} __rte_aligned(16); > > > -#else > > > }; > > > -#endif > > > > This part was a strange construct. > > I see nothing wrong with the change (doxygen passes fine), but just a > > heads up to Jerin. > > So there was another series merged recently that added this __DOXYGEN__ > conditional I'm just removing it again. > > Bruce pointed out that one of the benefits of moving __rte_aligned(16) > between struct doxygen no longer gets confused. > > https://mails.dpdk.org/archives/dev/2024-March/289231.html Thanks, I had indeed missed this point. So nothing wrong with the change, except maybe a mention in the commitlog (that I'll handle myself). --=20 David Marchand