From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFFE243006; Tue, 8 Aug 2023 09:31:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5806D43247; Tue, 8 Aug 2023 09:31:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EAB9440A87 for ; Tue, 8 Aug 2023 09:31:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691479895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qKy6J66uk8H+2Zj2dHUvpK6NA3fe/q99uFHXyWzEs/w=; b=QeW/cEhj4SEUIC0VdGp7guHZQsgN5hih7yxhtSieNHGyQoQnsqQDHUphxZ0YEf1brpb6bd hL3ET2lQgbJ0qEByhkokIjJCKdGYiCGJueww5/IMMu1fWSCZxJSiZSDAW8rnGT5ENBNQ5J TCH264yGCmJXmozMSkaoWqTVuSxqH7Y= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-uX3xYk2MNNKxJKId9q0WLA-1; Tue, 08 Aug 2023 03:31:33 -0400 X-MC-Unique: uX3xYk2MNNKxJKId9q0WLA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4fe3e3472bcso5057748e87.1 for ; Tue, 08 Aug 2023 00:31:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691479892; x=1692084692; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qKy6J66uk8H+2Zj2dHUvpK6NA3fe/q99uFHXyWzEs/w=; b=Q1sUsLbV++CPAqsAzqffXUNZSl+n0sDsNwEaM8C96cB+4gEv1vsxm9nnlaJSR0I2xF jqiy+jkBktjC4ejNoq/XP+ERMubxMhsStEDaSP8q81p6c8iaZTawBLrMLKC/bUNNIQ2A mmbkgOqHqrumcjJrz67I3Z6U+NNJQQnnLMDCHTELWsFyw/5ayw2YZ7ikpT9UR9mRhU2D /O96adKoMWRSheuywIF2dDed11hga/FyKKydXXF1gIZSn/HCThrA3lcRY+uXKzvNqZMO AlG8rzHsuEcsf2OFotZz4MurKlYcgzJZhuz2XBDIwDo1jWvt75lB89Z8RbiLd6co6VIU 2yqQ== X-Gm-Message-State: AOJu0YyzIC6EMlD4Hld5D1EU8seCKzFVIGYs1WuGFl7m1u4HAGITTOZf ynfJaSEVU+orQwxKzFGSufvjusru8dfs+R92orisa+jx/BYeAofJAM7bnz2Y2CcClpqgH4aTTQ7 Xh8lnMeCvuqnVC6QZs08= X-Received: by 2002:a05:6512:368b:b0:4fb:9e1a:e592 with SMTP id d11-20020a056512368b00b004fb9e1ae592mr6702856lfs.4.1691479892360; Tue, 08 Aug 2023 00:31:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4+oxxixChhS3iYqWqCOr9478WjrmjlD+apk/jA+NghRkSLsZxIgg1+P1RYnEZrz8uggAZ5PkDWMme6M/GA4c= X-Received: by 2002:a05:6512:368b:b0:4fb:9e1a:e592 with SMTP id d11-20020a056512368b00b004fb9e1ae592mr6702844lfs.4.1691479892039; Tue, 08 Aug 2023 00:31:32 -0700 (PDT) MIME-Version: 1.0 References: <20220912160157.3642968-2-mpiszczek@ddn.com> <20221017154507.934995-1-mpiszczek@ddn.com> <20221017154507.934995-2-mpiszczek@ddn.com> In-Reply-To: From: David Marchand Date: Tue, 8 Aug 2023 09:31:20 +0200 Message-ID: Subject: Re: [PATCH v6] pci: read amd iommu virtual address width To: Michael Piszczek Cc: dev@dpdk.org, Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 25, 2022 at 1:54=E2=80=AFPM David Marchand wrote: > > On Mon, Oct 24, 2022 at 5:35 PM Michael Piszczek wrot= e: > > > > Add code to read the virtual address width for AMD processors. > > Updated pci_device_iommu_support_va() to use glob to find iommu > > capability files. > > > > Signed-off-by: Michael Piszczek > > Please have a look at the ci. > > Unit tests are failing with this patch because the default is changed > from VA to PA. > A quick way to reproduce is to run vdev unit tests as a normal user in > no huge mode. > > Before change: > $ DPDK_TEST=3Dvdev_autotest ./build-gcc/app/test/dpdk-test --no-huge -m > 2048 --log-level=3D*:debug > ... > EAL: Bus vdev wants IOVA as 'DC' > EAL: Bus pci wants IOVA as 'DC' > EAL: Buses did not request a specific IOVA mode. > EAL: Physical addresses are unavailable, selecting IOVA as VA mode. > EAL: Selected IOVA mode 'VA' > > After change: > $ DPDK_TEST=3Dvdev_autotest ./build-gcc/app/test/dpdk-test --no-huge -m > 2048 --log-level=3D*:debug > ... > EAL: Bus vdev wants IOVA as 'DC' > EAL: Bus pci wants IOVA as 'PA' > EAL: FATAL: Cannot use IOVA as 'PA' since physical addresses are not avai= lable > EAL: Cannot use IOVA as 'PA' since physical addresses are not available I got no reply since a few months, marking as "Changes requested" in patchw= ork. If you think this is still worth pursuing, please provide a new revision that does not break IOVA default mode (and the CI). Cc: Ferruh, for info --=20 David Marchand