From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C301A0C41; Tue, 19 Oct 2021 15:42:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4547411AA; Tue, 19 Oct 2021 15:42:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id D09DD4119C for ; Tue, 19 Oct 2021 15:42:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634650963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K9jbY+ZTzUKrbkOicr/E4DHdCtzdL6q/Ly4V9YoCo/8=; b=fBOWOnQNwSr3CsLPD8yTy32+cfx9y7BCSpXVlW4uX0vIYwuzK2B3D6Rf5tuBTL5jMTdgS8 S5g6x4gwFAq2h8R+67uFNj0jRhx66ARLiBCSh6h/LszXw/7JKItf2Leo1CAsJMOVELa9Yh O/Fye57BxlevfY8lSmsZ2dFhWglI75A= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-491-Nk9adLhuMkGSQNXdC_W5QQ-1; Tue, 19 Oct 2021 09:42:41 -0400 X-MC-Unique: Nk9adLhuMkGSQNXdC_W5QQ-1 Received: by mail-lj1-f200.google.com with SMTP id o4-20020a2ebd84000000b00210ae894d18so895418ljq.13 for ; Tue, 19 Oct 2021 06:42:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K9jbY+ZTzUKrbkOicr/E4DHdCtzdL6q/Ly4V9YoCo/8=; b=LLdN9r0yd7T47yuQqPYymSaAVqaOojPu8tnsNN8LcK17ziGbSmldHuaRShIlQziX/w q5ET/pKnZZrIqUb51ZK7UedpjsedrLlrNcpvqzwBTDAoa3lTOmN81dmMnfzLahG2lub2 XuimbYX7C1U+xQCPR37/Hm4SwXGOV6dnnQSIsOPMg1WjwQRmtibHZLfdjGFRVk+ZsDFo 6y/OQCvnBd36gY8Ai0+UPJMdyz/sqgrANUIAUA5+EONqTF56gIu0X5NP9fINan41lHw5 l3qEOnOhmgvNw+IEHFPZK5qKh90B9YTtnmUXxiZt0dIWAVHYXWZaqS9az9ArnMlkiu5N rUTQ== X-Gm-Message-State: AOAM530PABUAbHpmjfOpHNdpFuRvhJ6z1x3VMFkASSvz765MtX33a6cS kWYy6rHHZ+k63/p2qgleszWBfZRRqfhCl/i2mYhSAQQ71jMKpiSopdNgQzxRqNhMuWmiAAZIqcu LBpxO2ksJZkTPO9I6KW0= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr5927905lfq.553.1634650959674; Tue, 19 Oct 2021 06:42:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSQgsX+0gWI0wuEU1TtVSNcHJVOIwKwvkBz4FEVbtAJMZ8pzUSJoJVN0+SQOj2Sik9BrVQZ8quThxqZc71Dqg= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr5927877lfq.553.1634650959376; Tue, 19 Oct 2021 06:42:39 -0700 (PDT) MIME-Version: 1.0 References: <20211018082635.2054-1-david.marchand@redhat.com> <79f4f029-ca13-6048-396c-232fe5ef5fb7@oktetlabs.ru> In-Reply-To: <79f4f029-ca13-6048-396c-232fe5ef5fb7@oktetlabs.ru> From: David Marchand Date: Tue, 19 Oct 2021 15:42:28 +0200 Message-ID: To: Andrew Rybchenko Cc: Olivier Matz , Dmitry Kozlyuk , Ray Kinsella , Stephen Hemminger , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] mempool: accept user flags only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 18, 2021 at 10:37 AM Andrew Rybchenko wrote: > > diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h > > index 88bcbc51ef..d2bf2843f7 100644 > > --- a/lib/mempool/rte_mempool.h > > +++ b/lib/mempool/rte_mempool.h > > @@ -258,6 +258,15 @@ struct rte_mempool { > > #define MEMPOOL_F_POOL_CREATED 0x0010 /**< Internal: pool is created. */ > > #define MEMPOOL_F_NO_IOVA_CONTIG 0x0020 /**< Don't need IOVA contiguous objs. */ > > > > +/** > > + * This macro lists all the mempool flags an application may request. > > + */ > > +#define MEMPOOL_VALID_USER_FLAGS (MEMPOOL_F_NO_SPREAD \ > > I think RTE_ prefix is missing here since it is in a public > header now. > > > + | MEMPOOL_F_NO_CACHE_ALIGN \ > > + | MEMPOOL_F_SP_PUT \ > > + | MEMPOOL_F_SC_GET \ > > + | MEMPOOL_F_NO_IOVA_CONTIG \ > > + ) > > /** > > * @internal When debug is enabled, store some statistics. > > * > > > > Should we make a patch to add defines with RTE_ prefix and > add a deprecation for old flags without RTE_ prefix? > > Olivier, what do you think? If you have time to care about it, > it would be great. (I'm unfamiliar with coccinelle yet). Andrew, RTE_ prefixing subject put aside, are you ok with this patch? -- David Marchand