From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86B99A0598; Tue, 21 Apr 2020 18:18:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6AF091D417; Tue, 21 Apr 2020 18:18:04 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id F40C11C1F7 for ; Tue, 21 Apr 2020 18:18:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587485882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NWq+o80IJcK3MRH6LpOWKx+IlayHhgK0lDWON1u4fK4=; b=Im/jWEAKt7Sfg5jygE3mzEO3Q3UptI6QF5dAcEMLZWo41ayRI307N/p73mwQV7jsDFPhRE tqtG1iiB4ykK2tEt/YzGnbU0mo6tYnJQFf97CrrCzSDAr3PGf2iLdNHcBagxgIBtP0xGun 2Mf7whu2RyaVgW2D+tkITwdNviCt/BU= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-WgmiNXi_PZKmBYRnoXMqow-1; Tue, 21 Apr 2020 12:18:00 -0400 X-MC-Unique: WgmiNXi_PZKmBYRnoXMqow-1 Received: by mail-vk1-f197.google.com with SMTP id k3so5531676vkb.13 for ; Tue, 21 Apr 2020 09:18:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NWq+o80IJcK3MRH6LpOWKx+IlayHhgK0lDWON1u4fK4=; b=LbGCOphQKD4nvtYvim7L5QUCIP+6h0GOvvIpL6rF/+gb4B8dWvO9jEKfmEWBldzQSN xgrc9qRheiFFQkPLRTyhrMWh8lKrVawep6Vb++tnYHQYbpqERPFCv+uH+gBp+qiT4Xua p3RIZ8joac20OGvEu3gVnDf1dd/JHoADIhGrIwf4TeeOBotLERxbnqZRcQhn1XYroIGO uZLaoilAz0BeO2LYwjJy2upP+EBKb+n2g/DncDkdaRabtT4rg5OvtLeCYMaY6U79ZL+p IBW63SyxogOcX2dzGGf5/6OPw4n6dp6BChG6utGyT9QeomumoMnX1kH8H2Sl45KGdIFp K12A== X-Gm-Message-State: AGi0PuZH9M85NV9/2QTmQBXQkOTcWj5JmdZNAg6wZ7IB+Yc7D/Mx/xjU kG377+x2bJBL32vP0XbRvfmG1ZDOuha68I47VKVaD2fu2BaeV1sNVZPv3NaDnJiIbLLy45Btny2 +YKPHNhw4MSe91ca0l00= X-Received: by 2002:a9f:2204:: with SMTP id 4mr12164658uad.87.1587485880335; Tue, 21 Apr 2020 09:18:00 -0700 (PDT) X-Google-Smtp-Source: APiQypJGJvNw/iJ7wrE+eDl7rLM64TvVfJJW6Z0djIFMuco7GcM8paBi3I4muK2tjSExnMlV5rAgK8ZzxsJQy1nmZ1U= X-Received: by 2002:a9f:2204:: with SMTP id 4mr12164636uad.87.1587485880068; Tue, 21 Apr 2020 09:18:00 -0700 (PDT) MIME-Version: 1.0 References: <586680073-11075-1-git-send-email-xiangxia.m.yue@gmail.com> <1586972466-40703-1-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: <1586972466-40703-1-git-send-email-xiangxia.m.yue@gmail.com> From: David Marchand Date: Tue, 21 Apr 2020 18:17:48 +0200 Message-ID: To: Tonghao Zhang Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dev , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3] eal: fix crash when the random init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 17, 2020 at 1:37 PM wrote: > > From: Tonghao Zhang > > When rte_rand_init is invoked, and the kernel running dpdk does't > support *getentropy, at the same time, the cpu does't support rdseed, > then rte_rand_init invoked rte_get_timer_cycles. > > If HPET was enabled in the DPDK build (CONFIG_RTE_LIBEAL_USE_HPET=3Dy). > rte_get_timer_cycles will invoke rte_get_hpet_cycles while *eal_hpet > is not available. > > To fix that, use rte_get_tsc_cycles instead of rte_get_timer_cycles. > > Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR= ") > Cc: stable@dpdk.org > > Signed-off-by: Tonghao Zhang > Acked-by: Mattias R=C3=B6nnblom Applied, thanks. --=20 David Marchand