From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68906A09EF; Tue, 12 Jan 2021 09:58:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2781140DA2; Tue, 12 Jan 2021 09:58:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 1F65A140D95 for ; Tue, 12 Jan 2021 09:58:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610441900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XX2NjvOhHA46xIKIJM7lRROQm7N3fucmVdguzJDUZhE=; b=i7/va1ksLrIa66qxTuSlzoJCvrsxRPBfGd/rtUQHZyQ2DnX259Ev7xLcJtal5G0T0fpSY8 BLkjjWSBzmAgn7ngHh7g5OJVfMTlG5T6Fsce/l0ukLpkmZdZqf5L7P+l72wV+gjn13g6vQ NrL8NGxFxaApQCsGNGlTcHaX6LOgu+I= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-CvIAiUWBOmKopiia46nCZg-1; Tue, 12 Jan 2021 03:58:18 -0500 X-MC-Unique: CvIAiUWBOmKopiia46nCZg-1 Received: by mail-ua1-f71.google.com with SMTP id 6so283159uay.21 for ; Tue, 12 Jan 2021 00:58:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XX2NjvOhHA46xIKIJM7lRROQm7N3fucmVdguzJDUZhE=; b=Xegvjjma5ri4suPXc9BlA8YCA9lgd/C0cNq61/pe1FM41NacIyofVsGpHfq1e/mPpl oX7pCo9OnMswx4OoVclbFK5e8siAD3lpNCIB6LxHDXO9nnXKaYShD4+8pjf0H/BnVHK1 8x0mfFZqCHYO1N1oGZkTe5d+hjbJ2JHChd3DPwfDtOtXvH9+1AHpnkruawKrYXzLPh3r azGr/4tYzuM0GfF5+9Ky3ZZo3DRxKhEBUaIiQ20Pl1lKVtUYjlQ3eyxLEy8fF4xpNI39 MqUkrUizVH1TiRLbGDuAKgFW9xY6XG0xWy7LopUUNes1xs93f3bFpXFAXEtAy69hHM7O Bs1Q== X-Gm-Message-State: AOAM531Dgcp+GaNW77ueB5k/ZFV1iXmKmhVbrfI8Q47fnm/nKmNkWx7S X966whegF5v+qUgcjglW6pP0yUlUJB1mhsHnFTI5Q4jaAd0x9vn8iNy9jgzmdUqyKwzyY/hr30q 4yuaapDBEHSZCIvUc0Mw= X-Received: by 2002:ab0:44c6:: with SMTP id n64mr2599080uan.53.1610441898106; Tue, 12 Jan 2021 00:58:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJytjjpQXYnC0pLBoygrR2qwdbwemBkP1hIzxDT4h//8g6sXS9S0j/jniU2lNONEn/UPgZwoBo1CEGQaQL9rKKA= X-Received: by 2002:ab0:44c6:: with SMTP id n64mr2599039uan.53.1610441897501; Tue, 12 Jan 2021 00:58:17 -0800 (PST) MIME-Version: 1.0 References: <20201214190255.16429-1-hkalra@marvell.com> In-Reply-To: <20201214190255.16429-1-hkalra@marvell.com> From: David Marchand Date: Tue, 12 Jan 2021 09:58:06 +0100 Message-ID: To: Harman Kalra Cc: Stephen Hemminger , Ravi Kerur , Thomas Monjalon , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix max Tx queue count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Dec 14, 2020 at 8:03 PM Harman Kalra wrote: > > In l3fwd no of transmit queues is calculated based on no of > lcores with which it is launched. Hence maximum no of tx > queues possible per port should depend on RTE_MAX_LCORE value. For the title, we are not "fixing" the Tx queue count. WDYT of: examples/l3fwd: remove limitation on Tx queue count > > Fixes: 268888b5b020 ("examples/l3fwd: modularize") This commit simply moves code around, so it is unlikely to be the origin. Afaiu, this behavior has been present since the start. I'd rather flag Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Harman Kalra > --- > examples/l3fwd/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index d62dec434..bb49e5faf 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -48,7 +48,7 @@ > #include "l3fwd.h" > #include "l3fwd_event.h" > > -#define MAX_TX_QUEUE_PER_PORT RTE_MAX_ETHPORTS > +#define MAX_TX_QUEUE_PER_PORT RTE_MAX_LCORE > #define MAX_RX_QUEUE_PER_PORT 128 > > #define MAX_LCORE_PARAMS 1024 Later in the code, the associated check on nb_lcores > RTE_MAX_LCORE does not make much sense. But keeping this MAX_TX_QUEUE_PER_PORT macro is a way to document how the txq are allocated. So this change lgtm. Reviewed-by: David Marchand -- David Marchand