From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A225A054D; Thu, 18 Feb 2021 10:33:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A163C160727; Thu, 18 Feb 2021 10:33:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 9F82A40698 for ; Thu, 18 Feb 2021 10:33:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613640798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AktOfN5ORon17oVQ7B0KrjBOn9pUuiOfUogRlzpcCdg=; b=M9QrLeZ52fdbcxribtdnc06AAn6l3l9/hHnONsvNADFXU+S8RGhGWQqxic8/wKxRwr2je1 Q7OegVcZzhUXIpd6LPxHfIs5ZSaGrZkeZDyNDIFz264Uk1f06cLM2K5orO7ewJ50AtLhy1 DKuR4h8berSgd1iSuPE+f6x+EAeyfR8= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-67laH9VcNuuwxqgKYdyfsA-1; Thu, 18 Feb 2021 04:33:16 -0500 X-MC-Unique: 67laH9VcNuuwxqgKYdyfsA-1 Received: by mail-ua1-f70.google.com with SMTP id c46so670887uad.1 for ; Thu, 18 Feb 2021 01:33:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AktOfN5ORon17oVQ7B0KrjBOn9pUuiOfUogRlzpcCdg=; b=Gqb3ZtCebdmSIQKA7tihG7DFkVd6vr+7kJLzOJRsvRgsbdoBrQYJbhQIv5OIedv6or 5gRNrvWdfQbGGeTHBJARVvLECowcvH8GG3xf8huddToL5P2NcVlEZ+AkD3EqxoryugYn 4RTzIsHmgrzMsz1T46m4P0gIGgddXzyVsB5dB7mKS2qLMxf5qBc2tsVuMhwColBAGUNj I/HW9h/T0gHG2Te7S+4PZh6jNQ0YxNnB0rPRYy+IOqIQU4dOD9Q48L8kCbISP2ANNfJg 8A8U9RiTqpVyiS9AYsQ2yYFHhTO5LubtFWR5abc97X7aMw74GJxYbnfIxxbLlaYClEI8 cz0A== X-Gm-Message-State: AOAM532n65Es3MSj7uI/cclI2y+SZb0Y+rdtLE22YZHdE8qd/1Yi3xRh Xb92LLS4LFHnbQ39HfMFN0yCDAnyU5Vfo0LsRjWHPRVnfznpo+w54uUz8aAzW8e5Z3BwVkuH+gq btSeDLYxIYF19dsLA2ow= X-Received: by 2002:ab0:310a:: with SMTP id e10mr2367690ual.126.1613640796157; Thu, 18 Feb 2021 01:33:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7WNY9BcAn24L7G6sXwNPfbFvBhVSSPHa+WWMeh7xgSxRVf6jBmurQ+opArOj/rH2zPJ2zSntvhI/BBkm1lBA= X-Received: by 2002:ab0:310a:: with SMTP id e10mr2367681ual.126.1613640795974; Thu, 18 Feb 2021 01:33:15 -0800 (PST) MIME-Version: 1.0 References: <1611890309-99135-1-git-send-email-huawei.xhw@alibaba-inc.com> <1611890309-99135-3-git-send-email-huawei.xhw@alibaba-inc.com> In-Reply-To: From: David Marchand Date: Thu, 18 Feb 2021 10:33:04 +0100 Message-ID: To: =?UTF-8?B?6LCi5Y2O5LyfKOatpOaXtuatpOWIu++8iQ==?= Cc: "Yigit, Ferruh" , Maxime Coquelin , dev , "Burakov, Anatoly" , xuemingl@nvidia.com, Gaetan Rivet , "Xia, Chenbo" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 2/2] bus/pci: support MMIO in PCI ioport accessors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 17, 2021 at 3:15 PM =E8=B0=A2=E5=8D=8E=E4=BC=9F(=E6=AD=A4=E6=97= =B6=E6=AD=A4=E5=88=BB=EF=BC=89 wrote: > > > On 2021/2/17 17:06, David Marchand wrote: > > On Fri, Jan 29, 2021 at 4:19 AM =E8=B0=A2=E5=8D=8E=E4=BC=9F(=E6=AD=A4= =E6=97=B6=E6=AD=A4=E5=88=BB=EF=BC=89 wrote: > >> @@ -517,6 +525,60 @@ > >> } > >> #endif > >> > >> +static inline uint8_t ioread8(void *addr) > >> +{ > >> + uint8_t val; > >> + > >> + val =3D (uint64_t)(uintptr_t)addr >=3D PIO_MAX ? > >> + *(volatile uint8_t *)addr : > >> + inb((unsigned long)addr); > > inb/outb and others are architecture (x86?) specific. > Yes, only X86 has PIO. Ok, thanks for confirming. > > > > The CI caught this issue, see build failures on ARM64. > > https://lab.dpdk.org/results/dashboard/results/results-uploads/test_run= s/82432e287bc94831b7a65d7cd6f05783/log_upload_file/2021/2/dpdk_b49c677a0d24= _15433_2021-02-01_00-15-59_NA.zip > > > > I can see the same issue with ppc64le. Just to be clear. This series can't be merged as it breaks non-x86 architectures. --=20 David Marchand